Closed
Bug 1476853
Opened 6 years ago
Closed 6 years ago
Enable block autoplay in Nightly only
Categories
(Core :: Audio/Video: Playback, enhancement, P2)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | verified |
People
(Reporter: cpearce, Assigned: cpearce)
References
Details
Attachments
(5 files)
59 bytes,
text/x-review-board-request
|
padenot
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
jya
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
jmaher
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
jchen
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
rbarker
:
review+
|
Details |
In order to gather feedback on our block autoplay implementation, we'd like to enable it in Nightly only.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 6•6 years ago
|
||
mozreview-review |
Comment on attachment 8993273 [details] Bug 1476853 - Don't block WebAudio autoplay by default. https://reviewboard.mozilla.org/r/258052/#review264978
Attachment #8993273 -
Flags: review?(padenot) → review+
Comment 7•6 years ago
|
||
mozreview-review |
Comment on attachment 8993274 [details] Bug 1476853 - Enable block autoplay on Nightly only on desktop. https://reviewboard.mozilla.org/r/258054/#review264990
Attachment #8993274 -
Flags: review?(jyavenard) → review+
Comment 8•6 years ago
|
||
mozreview-review |
Comment on attachment 8993275 [details] Bug 1476853 - Set autoplay to allowed for testing purposes. https://reviewboard.mozilla.org/r/258056/#review264994 thanks!
Attachment #8993275 -
Flags: review?(jmaher) → review+
Comment 9•6 years ago
|
||
mozreview-review |
Comment on attachment 8993277 [details] Bug 1476853 - Remove obsolete use of media.autoplay.enabled. https://reviewboard.mozilla.org/r/258060/#review264996
Attachment #8993277 -
Flags: review?(rbarker) → review+
Comment 10•6 years ago
|
||
:snorp is on PTO this week. Maybe ask :jchen for review?
Assignee | ||
Updated•6 years ago
|
Attachment #8993276 -
Flags: review?(snorp) → review?(nchen)
Assignee | ||
Comment 11•6 years ago
|
||
(In reply to Randall Barker [:rbarker] from comment #10) > :snorp is on PTO this week. Maybe ask :jchen for review? OK, thanks!
Comment 12•6 years ago
|
||
mozreview-review |
Comment on attachment 8993276 [details] Bug 1476853 - Enable block autoplay v2 on Nightly only on Fennec by default. https://reviewboard.mozilla.org/r/258058/#review265252
Attachment #8993276 -
Flags: review?(nchen) → review+
Comment 13•6 years ago
|
||
Pushed by cpearce@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ea9220c21a7b Don't block WebAudio autoplay by default. r=padenot https://hg.mozilla.org/integration/autoland/rev/7d8ce14346a3 Enable block autoplay on Nightly only on desktop. r=jya https://hg.mozilla.org/integration/autoland/rev/a44577a773a7 Set autoplay to allowed for testing purposes. r=jmaher https://hg.mozilla.org/integration/autoland/rev/82ace642ac7e Enable block autoplay v2 on Nightly only on Fennec by default. r=jchen https://hg.mozilla.org/integration/autoland/rev/8dcdd881fd09 Remove obsolete use of media.autoplay.enabled. r=rbarker
Comment 14•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/ea9220c21a7b https://hg.mozilla.org/mozilla-central/rev/7d8ce14346a3 https://hg.mozilla.org/mozilla-central/rev/a44577a773a7 https://hg.mozilla.org/mozilla-central/rev/82ace642ac7e https://hg.mozilla.org/mozilla-central/rev/8dcdd881fd09
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Comment 15•6 years ago
|
||
Chris, since this is sticking on nightly, could you please request a release notes addition for Nightly? Thanks https://wiki.mozilla.org/Release_Management/Release_Notes#How_to_nominate_a_bug_for_release_notes_addition.3F
Flags: needinfo?(cpearce)
Assignee | ||
Comment 16•6 years ago
|
||
(Requesting release note via "relnote-firefox?" but that didn't autofill a comment here with. I had to find the questions from the YouTube video. I assume that's a recent regression in b.m.o) Release note request: Block autoplay media with sound enabled by default in Firefox Nightly on desktop and Android. [Why this is notable]: This changes the default behaviour to block autoplay enabled, previously disabled by default. [Affects Firefox for Android]: Yes [Suggested wording]: Firefox Nightly by default now prompts for permission before allowing pages to automatically play media with sound. [Links]: TBD
relnote-firefox:
--- → ?
Flags: needinfo?(cpearce)
Updated•6 years ago
|
Comment 18•6 years ago
|
||
Any way to remove this feature for some url or on local filesystem (file:///) ? This is problematic when I have to make some tests on <audio>/<video> tags, making them play with javascript.
Comment 19•6 years ago
|
||
Verified, that block autoplay is enabled by default in Nightly.
Comment 20•5 years ago
|
||
Block autoplay was shipped to release in 66 and included in the release notes. I can't set the flag to 66+ at this point, but here's a link for posterity.
https://www.mozilla.org/firefox/66.0/releasenotes/
relnote-firefox:
? → ---
Comment 21•2 years ago
|
||
While reviewing 2+ year old Nightly differences, I found media.autoplay.block-webaudio
- which I believe is different from RyanVM's comment 20. Paul, is this something we can ship to release? Or maybe we should revert the Nightly behavior?
Flags: needinfo?(padenot)
Comment 22•2 years ago
|
||
We probably want to ship this now. Alastor, what do you think?
Flags: needinfo?(padenot) → needinfo?(alwu)
You need to log in
before you can comment on or make changes to this bug.
Description
•