Closed
Bug 1476928
Opened 7 years ago
Closed 7 years ago
Remove nsIURI.CloneIgnoringRef and nsIURI.CloneWithNewRef
Categories
(Core :: Networking, enhancement)
Core
Networking
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: valentin, Assigned: valentin)
References
Details
(Whiteboard: [necko-triaged][MemShrink])
Attachments
(1 file)
These methods are now irrelevant, since cloning is not needed anymore.
Moreover, this allows us to optimize these operations, since we don't need to clone/mutate when the ref we are trying to set (be it empty or not) already matches the ref on the URI. In that case, the "clone" becomes just an addref.
|
Assignee | |
Comment 1•7 years ago
|
||
The patch introduces NS_GetURIWithNewRef and NS_GetURIWithNewRef which perform the same function.
|
|
Assignee | |
Comment 2•7 years ago
|
||
|
||
Comment 3•7 years ago
|
||
Comment on attachment 8993318 [details]
Bug 1476928 - Remove nsIURI.CloneIgnoringRef and nsIURI.CloneWithNewRef
Junior Hsu has approved the revision.
https://phabricator.services.mozilla.com/D2239
Attachment #8993318 -
Flags: review+
Pushed by valentin.gosu@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/5288e1d49e71
Remove nsIURI.CloneIgnoringRef and nsIURI.CloneWithNewRef r=JuniorHsu
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
|
|
Assignee | |
Updated•7 years ago
|
Whiteboard: [necko-triaged] → [necko-triaged][MemShrink][qf]
|
||
Updated•3 years ago
|
Performance Impact: --- → ?
Whiteboard: [necko-triaged][MemShrink][qf] → [necko-triaged][MemShrink]
You need to log in
before you can comment on or make changes to this bug.
Description
•