Remove nsIURI.CloneIgnoringRef and nsIURI.CloneWithNewRef

RESOLVED FIXED in Firefox 63

Status

()

enhancement
RESOLVED FIXED
10 months ago
10 months ago

People

(Reporter: valentin, Assigned: valentin)

Tracking

(Blocks 1 bug)

unspecified
mozilla63
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox63 fixed)

Details

(Whiteboard: [necko-triaged][MemShrink][qf])

Attachments

(1 attachment)

(Assignee)

Description

10 months ago
These methods are now irrelevant, since cloning is not needed anymore.
Moreover, this allows us to optimize these operations, since we don't need to clone/mutate when the ref we are trying to set (be it empty or not) already matches the ref on the URI. In that case, the "clone" becomes just an addref.
(Assignee)

Comment 1

10 months ago
The patch introduces NS_GetURIWithNewRef and NS_GetURIWithNewRef which perform the same function.

Updated

10 months ago
Depends on: 1477377
Comment on attachment 8993318 [details]
Bug 1476928 - Remove nsIURI.CloneIgnoringRef and nsIURI.CloneWithNewRef

Junior Hsu has approved the revision.

https://phabricator.services.mozilla.com/D2239
Attachment #8993318 - Flags: review+

Comment 4

10 months ago
Pushed by valentin.gosu@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/5288e1d49e71
Remove nsIURI.CloneIgnoringRef and nsIURI.CloneWithNewRef r=JuniorHsu

Comment 5

10 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/5288e1d49e71
Status: NEW → RESOLVED
Last Resolved: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
(Assignee)

Updated

10 months ago
Whiteboard: [necko-triaged] → [necko-triaged][MemShrink][qf]
You need to log in before you can comment on or make changes to this bug.