Closed Bug 1477377 Opened 3 years ago Closed 3 years ago

Port |Bug 1476928 Remove nsIURI.CloneIgnoringRef and nsIURI.CloneWithNewRef|

Categories

(MailNews Core :: General, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 63.0

People

(Reporter: jorgk-bmo, Assigned: jorgk-bmo)

References

Details

Attachments

(2 files, 2 obsolete files)

As far as I can see, we don't used the methods internally, so it's just straight removals.
Attached patch 1477377-clone.patch (v1) (obsolete) — Splinter Review
This compiles with https://hg.mozilla.org/integration/autoland/rev/5288e1d49e71 applied.

Note that we do special things for nsIMsgMailNewsUrl and we have a cloneInternal() in the IDL, see: https://hg.mozilla.org/comm-central/rev/ddc5d8a70ab1. So I left that alone.
Attachment #8994189 - Flags: review?(valentin.gosu)
Comment on attachment 8994189 [details] [diff] [review]
1477377-clone.patch (v1)

Wait, all that cloneInternal stuff got removed in the end:
https://hg.mozilla.org/comm-central/rev/c2d11ad71eba

So I can cull much more.
Attachment #8994189 - Flags: review?(valentin.gosu)
Attached patch 1477377-clone.patch (v2) (obsolete) — Splinter Review
This should do it.
Attachment #8994189 - Attachment is obsolete: true
Attachment #8994191 - Flags: review?(valentin.gosu)
Comment on attachment 8994191 [details] [diff] [review]
1477377-clone.patch (v2)

Maybe still not right and the CloneInternal()s need to become Clone() again, thus reverting https://hg.mozilla.org/comm-central/rev/ddc5d8a70ab1.
Attachment #8994191 - Flags: review?(valentin.gosu)
Sorry about this noise, this should be it now.
Attachment #8994191 - Attachment is obsolete: true
Attachment #8994197 - Flags: review?(valentin.gosu)
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/0c6196bb63ea
Port bug 1476928: Remove CloneIgnoringRef() and CloneWithNewRef() methods. rs=bustage-fix
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 63.0
Version: 60 → Trunk
clang-cl on Windows 32 is very fussy. Let's see whether it's happy now:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=e7508e737da472a57d17de60037b8aafb26b75f8
Attachment #8994197 - Flags: review?(valentin.gosu) → review+
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/978a7b3ffb14
Follow-up: Fix clang-cl compile errors on Windows x86. rs=bustage-fix
Comment on attachment 8994314 [details] [diff] [review]
1477377-follow-up.patch

Review of attachment 8994314 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks
Attachment #8994314 - Flags: review+
You need to log in before you can comment on or make changes to this bug.