1477377 - Port |Bug 1476928 Remove nsIURI.CloneIgnoringRef and nsIURI.CloneWithNewRef|

Status: RESOLVED FIXED

(MailNews Core :: General, enhancement)

Description

[Jorg K (CEST = GMT+2)]

As far as I can see, we don't used the methods internally, so it's just straight removals.

Comment 1

[Jorg K (CEST = GMT+2)]

Attachment: 1477377-clone.patch (v1)

This compiles with https://hg.mozilla.org/integration/autoland/rev/5288e1d49e71 applied.

Note that we do special things for nsIMsgMailNewsUrl and we have a cloneInternal() in the IDL, see: https://hg.mozilla.org/comm-central/rev/ddc5d8a70ab1. So I left that alone.

Comment 2

[Jorg K (CEST = GMT+2)]

Comment on attachment 8994189 [details] [diff] [review]
1477377-clone.patch (v1)

Wait, all that cloneInternal stuff got removed in the end:
https://hg.mozilla.org/comm-central/rev/c2d11ad71eba

So I can cull much more.

Comment 3

[Jorg K (CEST = GMT+2)]

Attachment: 1477377-clone.patch (v2)

This should do it.

Comment 4

[Jorg K (CEST = GMT+2)]

Comment on attachment 8994191 [details] [diff] [review]
1477377-clone.patch (v2)

Maybe still not right and the CloneInternal()s need to become Clone() again, thus reverting https://hg.mozilla.org/comm-central/rev/ddc5d8a70ab1.

Comment 5

[Jorg K (CEST = GMT+2)]

Attachment: 1477377-clone.patch (v3)

Sorry about this noise, this should be it now.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0c6196bb63ea
Port bug 1476928: Remove CloneIgnoringRef() and CloneWithNewRef() methods. rs=bustage-fix

Comment 7

[Jorg K (CEST = GMT+2)]

Attachment: 1477377-follow-up.patch

clang-cl on Windows 32 is very fussy. Let's see whether it's happy now:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=e7508e737da472a57d17de60037b8aafb26b75f8

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/978a7b3ffb14
Follow-up: Fix clang-cl compile errors on Windows x86. rs=bustage-fix

Comment 9

[:aceman]

Comment on attachment 8994314 [details] [diff] [review]
1477377-follow-up.patch

Review of attachment 8994314 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks