1476948 - Suppress clang-cl warnings from the MIDL generated code in accessible/

Status: RESOLVED FIXED

(Core :: Disability Access APIs, enhancement)

Description

[Masatoshi Kimura [:emk]]

Although we don't have to suppress -Wextra-tokens (bug 1222531) anymore, some new warnings are added from the generated code.

Comment 1

[Masatoshi Kimura [:emk]]

Attachment: Bug 1476948 - Suppress clang-cl warnings from the MIDL generated code in accessible/.

Review commit: https://reviewboard.mozilla.org/r/258134/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/258134/

Comment 2

[Masatoshi Kimura [:emk]]

Comment on attachment 8993357 [details]
Bug 1476948 - Suppress clang-cl warnings from the MIDL generated code in accessible/.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/258134/diff/1-2/

Comment 3

[Nathan Froyd [:froydnj]]

Comment on attachment 8993357 [details]
Bug 1476948 - Suppress clang-cl warnings from the MIDL generated code in accessible/.

https://reviewboard.mozilla.org/r/258134/#review265104

::: accessible/interfaces/gecko/moz.build:25
(Diff revision 2)
> -#
> -#   #endif !_MIDL_USE_GUIDDEF_
> -#
> -# which clang-cl complains about.  MSVC doesn't, so turn this warning off.
>  if CONFIG['CC_TYPE'] == 'clang-cl':
> -    CFLAGS += ['-Wno-extra-tokens']
> +    CFLAGS += [

Has this warning gone away?  (Here and other places.)

Comment 4

[Masatoshi Kimura [:emk]]

Comment on attachment 8993357 [details]
Bug 1476948 - Suppress clang-cl warnings from the MIDL generated code in accessible/.

https://reviewboard.mozilla.org/r/258134/#review265104

> Has this warning gone away?  (Here and other places.)

Yes, generated files no longer contain `#endif !_MIDL_USE_GUIDDEF_` amd I didn' see `-Wextra-tokens` warning.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7fd7b91b7c2a
Suppress clang-cl warnings from the MIDL generated code in accessible/. r=froydnj

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/7fd7b91b7c2a

Comment 7

[Ionuț Goldan [:igoldan]]

Thank you for fixing some of the compiler warnings!

== Change summary for alert #14568 (as of Wed, 25 Jul 2018 08:35:33 GMT) ==

Improvements:

 17%  compiler warnings windows2012-32 debug static-analysis     1,293.25 -> 1,079.00
 16%  compiler warnings windows2012-32 opt static-analysis       1,299.25 -> 1,085.00
 16%  compiler warnings windows2012-64 debug static-analysis     1,320.25 -> 1,106.00
 16%  compiler warnings windows2012-64 opt static-analysis       1,326.25 -> 1,112.00

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=14568