Closed Bug 1477100 Opened 2 years ago Closed 2 years ago

Need to show in-field labels (small text and placeholder)

Categories

(Firefox :: WebPayments UI, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 63
Tracking Status
firefox63 --- verified

People

(Reporter: jgong, Assigned: jaws)

References

Details

(Whiteboard: [webpayments-reserve])

Attachments

(1 file, 1 obsolete file)

No description provided.
Need to show labels in field label and animation between empty and selected state.  For example, for City field the label should be "City *" in empty state and animate when user starts typing in selected state.
Animation is M4 and not needed for fx63.
Summary: Need to show in-field label and animation between empty and selected state → Need to show in-field label between empty and selected state
Whiteboard: [webpayments][triage] → [webpayments] [triage] [user-testing]
Whiteboard: [webpayments] [triage] [user-testing] → [webpayments-reserve]
Priority: P2 → P3
Summary: Need to show in-field label between empty and selected state → Need to show in-field labels (small text and placeholder)
See Also: → 1480886
Priority: P3 → P2
Flags: qe-verify?
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Priority: P2 → P1
Blocks: 1480886
See Also: 1480886
Show the labels as placeholders inside of the fields.
Attachment #8998631 - Attachment description: Bug 1477100 - Show the labels as placeholders inside of the fields. r?mattn → Bug 1477100 - Show the labels as placeholders inside of the fields. r?MattN
Attachment #8998249 - Attachment is obsolete: true
Flags: qe-verify? → qe-verify+
QA Contact: hani.yacoub
Comment on attachment 8998631 [details]
Bug 1477100 - Show the labels as placeholders inside of the fields. r?MattN

Matthew N. [:MattN] (PM if requests are blocking you) has approved the revision.
Attachment #8998631 - Flags: review+
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/32e2d0ddc56a
Show the labels as placeholders inside of the fields. r=MattN
Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8a7bbdede1c9
Show the labels as placeholders inside of the fields. r=MattN
Flags: needinfo?(jaws)
Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3575c52180c4
Scroll the country picker into view to fix browser_dropdowns.js. r=me
https://hg.mozilla.org/mozilla-central/rev/8a7bbdede1c9
https://hg.mozilla.org/mozilla-central/rev/3575c52180c4
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
Please wait to verify this bug until bug 1480886 lands as there are some temporary regressions about the address field positioning.
Duplicate of this bug: 1477104
The labels appear and are animated when their fields are active as the user starts to type.

However, in Edit mode, if there is a field with the red validation border triggered and the user clicks on the field, the label color will not turn to blue (as for the active state) until the user starts typing. 

Is this the expected behavior of the active state animation if an invalid field is selected?
Here is a screen recording of the behavior: https://streamable.com/ojmcn
Flags: needinfo?(jaws)
(In reply to Timea Babos from comment #14)
> The labels appear and are animated when their fields are active as the user
> starts to type.
> 
> However, in Edit mode, if there is a field with the red validation border
> triggered and the user clicks on the field, the label color will not turn to
> blue (as for the active state) until the user starts typing. 
> 
> Is this the expected behavior of the active state animation if an invalid
> field is selected?
> Here is a screen recording of the behavior: https://streamable.com/ojmcn

No, that's not expected. We should show the text as blue when the field is focused even if the field is marked as invalid. Can you file a follow-up bug to fix this?
Flags: needinfo?(jaws) → needinfo?(timea.babos)
Here it is: Bug 1488764. Will close this issue once the new one will be fixed. Thank you.
Flags: needinfo?(timea.babos)
Since Bug 1488764 is not an issue, I will mark this issue as Verified - Fixed based on Comment  14 on Windows 10, Ubuntu 18.04 and Mac OS 10.13.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.