Position the form fields for the address-form and basic-card-form according to the spec

VERIFIED FIXED in Firefox 63

Status

()

enhancement
P1
normal
VERIFIED FIXED
Last year
11 months ago

People

(Reporter: jaws, Assigned: MattN)

Tracking

Trunk
Firefox 63
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox63 fixed, firefox64 verified)

Details

(Whiteboard: [webpayments])

Attachments

(2 attachments, 1 obsolete attachment)

The current layout of the form fields is a bit squished together and doesn't fit the grid-based layout that the spec has.
Flags: qe-verify+
Priority: -- → P2
QA Contact: hani.yacoub
Whiteboard: [webpayments] [triage] → [webpayments-reserve]
Depends on: 1477100
See Also: 1477100
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Priority: P2 → P1
Attachment #8998662 - Attachment description: Bug 1480886 - Position the form fields for the address-form and basic-card-form according to the spec. → Bug 1480886 - Position the form fields for the address-form and basic-card-form according to the spec. r?MattN
Assignee: jaws → MattN+bmo
Whiteboard: [webpayments-reserve] → [webpayments]
Based on work by Jared Wein.

A follow-up will handle the persist checkbox and billing address.

Depends on D4164
Attachment #8998662 - Attachment is obsolete: true
Comment on attachment 9003632 [details]
Bug 1480886 - Move the autofill country warning message out of the <form>. r=sfoster

Sam Foster [:sfoster] has approved the revision.
Attachment #9003632 - Flags: review+
Comment on attachment 9003659 [details]
Bug 1480886 - Position the form fields for the address-form and basic-card-form according to the spec. r=sfoster

Sam Foster [:sfoster] has approved the revision.
Attachment #9003659 - Flags: review+
Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/mozilla-inbound/rev/63b68934f813
Move the autofill country warning message out of the <form>. r=sfoster
https://hg.mozilla.org/integration/mozilla-inbound/rev/55f933e0609f
Position the form fields for the address-form and basic-card-form according to the spec. r=sfoster
Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c066358cf6fc
Follow-up to disable the cc-type field. r=MattN
Backed out 2 changesets (bug 1480886) for browser-chrome failures on browser/extensions/formautofill/test/browser/browser_editAddressDialog.js. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#?job_id=196303118&repo=mozilla-inbound&lineNumber=15249

TEST-PASS | browser/extensions/formautofill/test/browser/browser_editAddressDialog.js | check family-name - 
14:44:32     INFO - Buffered messages finished
14:44:32     INFO - TEST-UNEXPECTED-FAIL | browser/extensions/formautofill/test/browser/browser_editAddressDialog.js | check organization - Got 02139, expected World Wide Web Consortium
14:44:32     INFO - Stack trace:
14:44:32     INFO - chrome://mochikit/content/browser-test.js:test_is:1304
14:44:32     INFO - chrome://mochitests/content/browser/browser/extensions/formautofill/test/browser/browser_editAddressDialog.js:test_saveAddress:91
14:44:32     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1102
14:44:32     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1093
14:44:32     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:995
14:44:32     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:795
14:44:32     INFO - Not taking screenshot here: see the one that was previously logged
14:44:32     INFO - TEST-UNEXPECTED-FAIL | browser/extensions/formautofill/test/browser/browser_editAddressDialog.js | check street-address - Got World Wide Web Consortium, expected 32 Vassar Street
14:44:32     INFO - MIT Room 32-G524
14:44:32     INFO - Stack trace:
14:44:32     INFO - chrome://mochikit/content/browser-test.js:test_is:1304
14:44:32     INFO - chrome://mochitests/content/browser/browser/extensions/formautofill/test/browser/browser_editAddressDialog.js:test_saveAddress:91
14:44:32     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1102
14:44:32     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1093
14:44:32     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:995
14:44:32     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:795
14:44:32     INFO - Not taking screenshot here: see the one that was previously logged
14:44:32     INFO - TEST-UNEXPECTED-FAIL | browser/extensions/formautofill/test/browser/browser_editAddressDialog.js | check address-level2 - Got 32 Vassar StreetMIT Room 32-G524, expected Cambridge
14:44:32     INFO - Stack trace:
14:44:32     INFO - chrome://mochikit/content/browser-test.js:test_is:1304
14:44:32     INFO - chrome://mochitests/content/browser/browser/extensions/formautofill/test/browser/browser_editAddressDialog.js:test_saveAddress:91
14:44:32     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1102
14:44:32     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1093
14:44:32     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:995
14:44:32     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:795
14:44:32     INFO - Not taking screenshot here: see the one that was previously logged
14:44:32     INFO - TEST-UNEXPECTED-FAIL | browser/extensions/formautofill/test/browser/browser_editAddressDialog.js | check address-level1 - Got Cambridge, expected MA
14:44:32     INFO - Stack trace:
14:44:32     INFO - chrome://mochikit/content/browser-test.js:test_is:1304
14:44:32     INFO - chrome://mochitests/content/browser/browser/extensions/formautofill/test/browser/browser_editAddressDialog.js:test_saveAddress:91
14:44:32     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1102
14:44:32     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1093
14:44:32     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:995
14:44:32     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:795
14:44:32     INFO - Not taking screenshot here: see the one that was previously logged
14:44:32     INFO - TEST-UNEXPECTED-FAIL | browser/extensions/formautofill/test/browser/browser_editAddressDialog.js | check postal-code - Got MA, expected 02139
14:44:32     INFO - Stack trace:
14:44:32     INFO - chrome://mochikit/content/browser-test.js:test_is:1304
14:44:32     INFO - chrome://mochitests/content/browser/browser/extensions/formautofill/test/browser/browser_editAddressDialog.js:test_saveAddress:91
14:44:32     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1102
14:44:32     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1093
14:44:32     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:995
14:44:32     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:795
14:44:32     INFO - TEST-PASS | browser/extensions/formautofill/test/browser/browser_editAddressDialog.js | check country - 
14:44:32     INFO - TEST-PASS | browser/extensions/formautofill/test/browser/browser_editAddressDialog.js | check tel - 
14:44:32     INFO - TEST-PASS | browser/extensions/formautofill/test/browser/browser_editAddressDialog.js | check email - 
14:44:32     INFO - Leaving test bound test_saveAddress
14:44:32     INFO - Entering test bound test_editAddress
14:44:32     INFO - expecting record retrievals: addresses
14:44:32     INFO - GECKO(960) | ++DOCSHELL 0x11dd35000 == 17 [pid = 960] [id = {9ff79517-19a2-394e-94f1-9c10b81f9023}]
14:44:32     INFO - GECKO(960) | ++DOMWINDOW == 34 (0x100864000) [pid = 960] [serial = 44] [outer = 0x0]
14:44:32     INFO - GECKO(960) | ++DOMWINDOW == 35 (0x122fbb000) [pid = 960] [serial = 45] [outer = 0x100864000]
14:44:32     INFO - must wait for load
14:44:32     INFO - must wait for focus

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=55f933e0609f69d6518de5d98ede9d46c73b42fc

Backout:

https://hg.mozilla.org/integration/mozilla-inbound/rev/15a4fb0d9e809a6e4254b394d6eab3bd8163d625
Flags: needinfo?(MattN+bmo)
Backout by dluca@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/23f2da29b443
Backed out changeset c066358cf6fc for Browser-chrome failures on  browser/extensions/formautofill/test/browser/browser_editAddressDialog.js. CLOSED TREE
Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/mozilla-inbound/rev/690f56519829
Move the autofill country warning message out of the <form>. r=sfoster
https://hg.mozilla.org/integration/mozilla-inbound/rev/ba1272b8b639
Position the form fields for the address-form and basic-card-form according to the spec. r=sfoster
Flags: needinfo?(MattN+bmo)
https://hg.mozilla.org/mozilla-central/rev/690f56519829
https://hg.mozilla.org/mozilla-central/rev/ba1272b8b639
Status: ASSIGNED → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
The current layout of the form fields for the address-form isn't squished together any more, comparing the latest Firefox Nightly 63.0a1(2018-08-29) with the spec.

But some of the fields (Organization, Country and form) order differs from the spec, and I'm not sure if that is intended, also in Nightly the field is displayed as "Country or Region" and on the spec is displayed "Country".
Flags: needinfo?(MattN+bmo)
(In reply to Hani Yacoub from comment #12)
> But some of the fields (Organization, Country and form) order differs from
> the spec, and I'm not sure if that is intended,

We've been discussing this with UX and will file a bug. It's in our spreadsheet from the Wednesday meeting to file remaining differences from the spec: https://docs.google.com/spreadsheets/d/1qY0GrH9vDu7bnqjiLtRplh4Y10af_48WqHK1PPAoxyo/edit#gid=468547005

> also in Nightly the field is
> displayed as "Country or Region" and on the spec is displayed "Country".

This is a mistake in the specs. The Mozilla policy is "Country or Region": https://wiki.mozilla.org/Lists_of_Countries_and_Regions
Flags: needinfo?(MattN+bmo)
Verified as fixed on Firefox Nightly 64.0a1 on Windows 10 x 64, Windows 7 x32, Mac OS X 10.12 and Ubuntu 16.04 x64.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.