Closed Bug 1477117 Opened Last year Closed Last year

Adding requestBillingAddress in PaymentOptions

Categories

(Core :: DOM: Web Payments, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: marcosc, Assigned: edenchuang)

References

()

Details

(Whiteboard: [webpayments-reserve][wptsync upstream])

Attachments

(4 files, 6 obsolete files)

14.03 KB, patch
edenchuang
: review+
Details | Diff | Splinter Review
20.74 KB, patch
edenchuang
: review+
Details | Diff | Splinter Review
8.94 KB, patch
edenchuang
: review+
Details | Diff | Splinter Review
31.45 KB, patch
edenchuang
: review+
Details | Diff | Splinter Review
Add ability to request payer's address, so tax can be computed by merchants.
Priority: -- → P3
Still sorting this out at the w3c :/ I think we are getting closer to a solution.
Summary: Payment Request: Add ability to request payer's address → Add ability to request billing address
Whiteboard: [webpayments][triage]
Summary: Add ability to request billing address → Add ability to explicitly request billing address from basic card
Summary: Add ability to explicitly request billing address from basic card → User changes payment method
Flags: qe-verify-
Whiteboard: [webpayments][triage] → [webpayments-reserve]
Marcos, During our triage today. MattN has indicated that he doesn't think that this bug is needed for M3.
No problem. Thanks for the info. 

After today's call with various standards folks, it looks like more things are getting moved around in the spec anyway... so will probably be another week or so before we reach consensus on a solution.
Priority: P3 → P2
The spec 

https://w3c.github.io/payment-method-basic-card/#steps-for-when-a-user-changes-payment-method
Summary: User changes payment method → Adding requestBillingAddress in PaymentOptions
Duplicate of this bug: 1508821
Eden, What is the status on this bug?
Flags: needinfo?(echuang)
1. Add a new attribute nsIPaymentOptions.requestBillingAddress.              
2. Add new XPCOM interfaces MethodChangeDetails, GeneralChangeDetails and BasicCardMethodChangeDetails for passing the method change details from UI code.
Assignee: nobody → echuang
Flags: needinfo?(echuang)
Attachment #9027808 - Flags: review?(amarchesini)
1. Add a new method nsIPaymentRequestService::ChangePaymentMethod for UI to inform merchant the payment method is changed by users.                    

2. Add a new method in PPaymentRequest.ipdl to passing the changing method information from the chrome process to the content process.                       

3. Add BasicCardChangeDetails dictionary in BasicCardPayment.webidl          

4. Create ChangeDetails, GeneralDetails and BasicCardDetails for saving the method information in the content process.
Attachment #9027809 - Flags: review?(amarchesini)
Save the changing method information in PaymentMethodChangeEvent and dispatch it.
Attachment #9027810 - Flags: review?(amarchesini)
Attachment #9027811 - Flags: review?(amarchesini)
Attachment #9027808 - Flags: review?(amarchesini) → review+
Comment on attachment 9027809 [details] [diff] [review]
Part 2 - Add new IPC method for passing the changing method information.

Review of attachment 9027809 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/payments/PaymentRequest.h
@@ +45,5 @@
> +    nsString postalCode;
> +    nsString sortingCode;
> +    nsString organization;
> +    nsString recipient;
> +    nsString phone;

These should all be mName, right?
Attachment #9027809 - Flags: review?(amarchesini) → review+
Attachment #9027810 - Flags: review?(amarchesini) → review+
Attachment #9027811 - Flags: review?(amarchesini) → review+
Attachment #9027810 - Attachment is obsolete: true
Attachment #9027959 - Flags: review+
Attachment #9027811 - Attachment is obsolete: true
Attachment #9027960 - Flags: review+
Keywords: checkin-needed
Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1809212f5f29
Part 1 - Create new XPCOM interface for changing the payment method. r=baku
https://hg.mozilla.org/integration/mozilla-inbound/rev/ddaac3335514
Part 2 - Add new IPC method for passing the changing method information. r=baku
https://hg.mozilla.org/integration/mozilla-inbound/rev/8ffc94b44c3e
Part 3 - dispatch the PaymentMethodChangeEvent. r=baku
https://hg.mozilla.org/integration/mozilla-inbound/rev/3b473ca68a57
Part 4 - mochitest for PaymentMethodChangeEvent. r=baku
Keywords: checkin-needed
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/14272 for changes under testing/web-platform/tests
Whiteboard: [webpayments-reserve] → [webpayments-reserve][wptsync upstream]
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
Fix the rooting hazard issue.
Attachment #9027959 - Attachment is obsolete: true
Flags: needinfo?(echuang)
Attachment #9028342 - Flags: review+
Update the testcase
Attachment #9027960 - Attachment is obsolete: true
Attachment #9028344 - Flags: review+
Keywords: checkin-needed
Pushed by ccoroiu@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4a5132e165d8
Part 1 - Create new XPCOM interface for changing the payment method. r=baku
https://hg.mozilla.org/integration/mozilla-inbound/rev/b3aea4b20b53
Part 2 - Add new IPC method for passing the changing method information. r=baku
https://hg.mozilla.org/integration/mozilla-inbound/rev/ae31de05b602
Part 3 - dispatch the PaymentMethodChangeEvent. r=baku
https://hg.mozilla.org/integration/mozilla-inbound/rev/ab5b1091c88e
Part 4 - mochitest for PaymentMethodChangeEvent. r=baku
Keywords: checkin-needed
You need to log in before you can comment on or make changes to this bug.