1477117 - Adding requestBillingAddress in PaymentOptions

Status: RESOLVED FIXED

(Core :: DOM: Web Payments, defect, P2)

Description

[Marcos Caceres [:marcosc]]

Add ability to request payer's address, so tax can be computed by merchants.

Comment 1

[Marcos Caceres [:marcosc]]

Still sorting this out at the w3c :/ I think we are getting closer to a solution.

Comment 2

[Marcos Caceres [:marcosc]]

The logic moved tho here: 
https://github.com/w3c/payment-method-basic-card/pull/53

But: 
https://github.com/w3c/payment-request/pull/749

Is still relevant.

Comment 3

[Jean Gong :jgong]

Marcos, During our triage today. MattN has indicated that he doesn't think that this bug is needed for M3.

Comment 4

[Marcos Caceres [:marcosc]]

No problem. Thanks for the info. 

After today's call with various standards folks, it looks like more things are getting moved around in the spec anyway... so will probably be another week or so before we reach consensus on a solution.

Comment 5

[Eden Chuang[:edenchuang]]

The spec 

https://w3c.github.io/payment-method-basic-card/#steps-for-when-a-user-changes-payment-method

Comment 7

[Jean Gong :jgong]

Eden, What is the status on this bug?

Comment 8

[Eden Chuang[:edenchuang]]

Attachment: Part 1 - Create new XPCOM interface for changing the payment method.

1. Add a new attribute nsIPaymentOptions.requestBillingAddress.              
2. Add new XPCOM interfaces MethodChangeDetails, GeneralChangeDetails and BasicCardMethodChangeDetails for passing the method change details from UI code.

Comment 9

[Eden Chuang[:edenchuang]]

Attachment: Part 2 - Add new IPC method for passing the changing method information.

1. Add a new method nsIPaymentRequestService::ChangePaymentMethod for UI to inform merchant the payment method is changed by users.                    

2. Add a new method in PPaymentRequest.ipdl to passing the changing method information from the chrome process to the content process.                       

3. Add BasicCardChangeDetails dictionary in BasicCardPayment.webidl          

4. Create ChangeDetails, GeneralDetails and BasicCardDetails for saving the method information in the content process.

Comment 10

[Eden Chuang[:edenchuang]]

Attachment: Part 3 - dispatch the PaymentMethodChangeEvent.

Save the changing method information in PaymentMethodChangeEvent and dispatch it.

Comment 11

[Eden Chuang[:edenchuang]]

Attachment: Part 4 - mochitest for PaymentMethodChangeEvent

Comment 12

[Andrea Marchesini [:baku]]

Comment on attachment 9027809 [details] [diff] [review]
Part 2 - Add new IPC method for passing the changing method information.

Review of attachment 9027809 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/payments/PaymentRequest.h
@@ +45,5 @@
> +    nsString postalCode;
> +    nsString sortingCode;
> +    nsString organization;
> +    nsString recipient;
> +    nsString phone;

These should all be mName, right?

Comment 13

[Eden Chuang[:edenchuang]]

Attachment: Part 1 - Create new XPCOM interface for changing the payment method.

Comment 14

[Eden Chuang[:edenchuang]]

Attachment: Part 2 - Add new IPC method for passing the changing method information.

Comment 15

[Eden Chuang[:edenchuang]]

Attachment: Part 3 - dispatch the PaymentMethodChangeEvent.

Comment 16

[Eden Chuang[:edenchuang]]

Attachment: Part 4 - mochitest for PaymentMethodChangeEvent

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1809212f5f29
Part 1 - Create new XPCOM interface for changing the payment method. r=baku
https://hg.mozilla.org/integration/mozilla-inbound/rev/ddaac3335514
Part 2 - Add new IPC method for passing the changing method information. r=baku
https://hg.mozilla.org/integration/mozilla-inbound/rev/8ffc94b44c3e
Part 3 - dispatch the PaymentMethodChangeEvent. r=baku
https://hg.mozilla.org/integration/mozilla-inbound/rev/3b473ca68a57
Part 4 - mochitest for PaymentMethodChangeEvent. r=baku

Comment 18

[Arthur Iakab [arthur_iakab]]

Backed out 4 changesets (bug 1477117) for causing hazard build bustage on payments/PaymentRequest.cpp:1066 CLOSED TREE

Backout revision https://hg.mozilla.org/integration/mozilla-inbound/rev/77c14850b8c700541cc1273f5b7f7f14fa60e713

Failed push https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=214234649&revision=3b473ca68a5777d754b2a9f79275497309eee9fb

Failure log:https://treeherder.mozilla.org/logviewer.html#?job_id=214229503&repo=mozilla-inbound

:edenchuang Could you please take a look?

Comment 19

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/14272 for changes under testing/web-platform/tests

Comment 20

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 21

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged

Comment 22

[Eden Chuang[:edenchuang]]

Attachment: Part 3 - dispatch the PaymentMethodChangeEvent.

Fix the rooting hazard issue.

Comment 23

[Eden Chuang[:edenchuang]]

Attachment: Part 4 - mochitest for PaymentMethodChangeEvent

Update the testcase

Comment 24

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4a5132e165d8
Part 1 - Create new XPCOM interface for changing the payment method. r=baku
https://hg.mozilla.org/integration/mozilla-inbound/rev/b3aea4b20b53
Part 2 - Add new IPC method for passing the changing method information. r=baku
https://hg.mozilla.org/integration/mozilla-inbound/rev/ae31de05b602
Part 3 - dispatch the PaymentMethodChangeEvent. r=baku
https://hg.mozilla.org/integration/mozilla-inbound/rev/ab5b1091c88e
Part 4 - mochitest for PaymentMethodChangeEvent. r=baku

Comment 25

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/4a5132e165d8
https://hg.mozilla.org/mozilla-central/rev/b3aea4b20b53
https://hg.mozilla.org/mozilla-central/rev/ae31de05b602
https://hg.mozilla.org/mozilla-central/rev/ab5b1091c88e