Closed Bug 1477401 Opened 3 years ago Closed 3 years ago

TB hangs if |file://some-file.png| is used in the signature block

Categories

(MailNews Core :: Composition, defect)

defect
Not set
normal

Tracking

(thunderbird_esr60 fixed, thunderbird62 wontfix, thunderbird63 fixed)

RESOLVED FIXED
Thunderbird 63.0
Tracking Status
thunderbird_esr60 --- fixed
thunderbird62 --- wontfix
thunderbird63 --- fixed

People

(Reporter: jorgk-bmo, Assigned: jorgk-bmo)

References

Details

Attachments

(2 files, 4 obsolete files)

Defective code in ReplaceFileURLs() in nsMsgCompose.cpp.
Attached patch 1477401-fix-hang.patch (obsolete) — Splinter Review
Assignee: nobody → jorgk
Status: NEW → ASSIGNED
Attachment #8993824 - Flags: review?(acelists)
Attached patch no-ws.patch (obsolete) — Splinter Review
Review this one instead, much easier ;-)
Attachment #8993825 - Flags: review?(acelists)
Attached patch 1477401-fix-hang2.patch (v2) (obsolete) — Splinter Review
Discussed this with Aceman on IRC, he prefers to treat the fPos==0 case equally badly. So here we go ;-)
Attachment #8993824 - Attachment is obsolete: true
Attachment #8993825 - Attachment is obsolete: true
Attachment #8993824 - Flags: review?(acelists)
Attachment #8993825 - Flags: review?(acelists)
Attachment #8993961 - Flags: review?(acelists)
Attached patch no-ws.patch (obsolete) — Splinter Review
This is easier to read.
Attachment #8993962 - Flags: review?(acelists)
Attached patch no-ws.patchSplinter Review
Had to fix offset = fPos - 1;
Attachment #8993961 - Attachment is obsolete: true
Attachment #8993962 - Attachment is obsolete: true
Attachment #8993961 - Flags: review?(acelists)
Attachment #8993962 - Flags: review?(acelists)
Attachment #8993964 - Flags: review?(acelists)
Comment on attachment 8993964 [details] [diff] [review]
1477401-fix-hang2.patch (v2b)

Review of attachment 8993964 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.
Attachment #8993964 - Flags: review?(acelists) → review+
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/068b782f89db
don't hang on bad signature block. r=aceman
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 63.0
Version: 60 → Trunk
Attachment #8993964 - Flags: approval-comm-esr60+
Attachment #8993964 - Flags: approval-comm-beta+
Attachment #8993964 - Flags: approval-comm-beta+
Depends on: 1495698
You need to log in before you can comment on or make changes to this bug.