Closed
Bug 1477401
Opened 7 years ago
Closed 7 years ago
TB hangs if |file://some-file.png| is used in the signature block
Categories
(MailNews Core :: Composition, defect)
MailNews Core
Composition
Tracking
(thunderbird_esr60 fixed, thunderbird62 wontfix, thunderbird63 fixed)
RESOLVED
FIXED
Thunderbird 63.0
People
(Reporter: jorgk-bmo, Assigned: jorgk-bmo)
References
Details
Attachments
(2 files, 4 obsolete files)
1.98 KB,
patch
|
Details | Diff | Splinter Review | |
3.31 KB,
patch
|
aceman
:
review+
jorgk-bmo
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
Defective code in ReplaceFileURLs() in nsMsgCompose.cpp.
Assignee | ||
Comment 1•7 years ago
|
||
Assignee | ||
Comment 2•7 years ago
|
||
Review this one instead, much easier ;-)
Attachment #8993825 -
Flags: review?(acelists)
Assignee | ||
Comment 3•7 years ago
|
||
Discussed this with Aceman on IRC, he prefers to treat the fPos==0 case equally badly. So here we go ;-)
Attachment #8993824 -
Attachment is obsolete: true
Attachment #8993825 -
Attachment is obsolete: true
Attachment #8993824 -
Flags: review?(acelists)
Attachment #8993825 -
Flags: review?(acelists)
Attachment #8993961 -
Flags: review?(acelists)
Assignee | ||
Comment 4•7 years ago
|
||
This is easier to read.
Attachment #8993962 -
Flags: review?(acelists)
Assignee | ||
Comment 5•7 years ago
|
||
Had to fix offset = fPos - 1;
Attachment #8993961 -
Attachment is obsolete: true
Attachment #8993962 -
Attachment is obsolete: true
Attachment #8993961 -
Flags: review?(acelists)
Attachment #8993962 -
Flags: review?(acelists)
Assignee | ||
Comment 6•7 years ago
|
||
Attachment #8993964 -
Flags: review?(acelists)
Comment on attachment 8993964 [details] [diff] [review]
1477401-fix-hang2.patch (v2b)
Review of attachment 8993964 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks.
Attachment #8993964 -
Flags: review?(acelists) → review+
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/068b782f89db
don't hang on bad signature block. r=aceman
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•7 years ago
|
Target Milestone: --- → Thunderbird 63.0
Version: 60 → Trunk
Assignee | ||
Updated•7 years ago
|
Attachment #8993964 -
Flags: approval-comm-esr60+
Attachment #8993964 -
Flags: approval-comm-beta+
Assignee | ||
Comment 9•7 years ago
|
||
status-thunderbird62:
--- → affected
status-thunderbird63:
--- → fixed
status-thunderbird_esr60:
--- → fixed
Assignee | ||
Updated•7 years ago
|
Assignee | ||
Updated•7 years ago
|
Attachment #8993964 -
Flags: approval-comm-beta+
You need to log in
before you can comment on or make changes to this bug.
Description
•