1495698 - Freeze by using HTML signatures referencing non-existent image

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Mario Sottile]

Attachment: firma.html

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:62.0) Gecko/20100101 Firefox/62.0
Build ID: 20180920131237

Steps to reproduce:

Debian 9 Mate 64x

I have 3 identities in my account. All of them has HTML signature. Some days ago, I could select any of them and signature worked OK. But I updated my system.
Now, the main one works... but, when I select any of the other... Thunderbirds freezes: I have to kill it.
Y have my signatures as html files, loaded by "Attach the signature from a file instead)...".
But, if I uncheck that option and paste html code in "Signature text" with "Use HTML..." checked, Thunderbird freezes.
If I uncheck "Use HTML....", it doesn't freeze... but signature appears as code.

I attach one signature HTML file.


Actual results:

Thunderbird freezes.


Expected results:

Show HTML signatures right using code or file.

Comment 1

[Jorg K (CEST = GMT+2)]

If tested this with your signature. That contains:
<p class="firma"><img src="file:///home/mario/circo3d-grafica/mails-headers-firmas/firma.png" alt="" border="0" width="250" height="75"></p>

I get a hang too, and I obviously don't have the file. If I change the source to a file I have, it works fine, and then changing it to an invalid filename it hangs again.

The debug window shows and endless loop:
[9476, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80520012: file c:/mozilla-source/comm-central/comm/mailnews/compose/src/nsMsgCompose.cpp, line 4284

Hmm, I thought I had already fixed this one in bug 1477401. I'll fix it.

To get you going again, make sure that the file exists on your machine.

Comment 3

[Jorg K (CEST = GMT+2)]

Attachment: 1495698-hang-non-existent-image.patch

Looks like we broke this in bug 1477401. This restores the original code
https://hg.mozilla.org/comm-central/rev/068b782f89db#l1.70
  offset = fPos - 1;
but takes care not to loop endlessly if fPos==0, which is what the other bug tried to address.

Comment 4

[:aceman]

Comment on attachment 9014342 [details] [diff] [review]
1495698-hang-non-existent-image.patch

Review of attachment 9014342 [details] [diff] [review]:
-----------------------------------------------------------------

OK, while there, please fix the "incompelte" at the start of that loop.
And also it is kinda unusual to have nsAutoString as argument to a function (nsMsgCompose::ReplaceFileURLs). So please change to nsAString if it compiles.

Comment 5

[Jorg K (CEST = GMT+2)]

There is no nsAString::Rfind(). You'd need to use PromiseFlatString() on the argument. I can change it to nsString().

Comment 6

[Wayne Mery (:wsmwk)]

Is it a regression?

Comment 7

[Jorg K (CEST = GMT+2)]

Yes, see comment #3.

Comment 8

[Jorg K (CEST = GMT+2)]

Attachment: 1495698-hang-non-existent-image.patch (v2)

Thanks, fixed the typo and made it nsString.

Comment 9

[:aceman]

Comment on attachment 9014596 [details] [diff] [review]
1495698-hang-non-existent-image.patch (v2)

Review of attachment 9014596 [details] [diff] [review]:
-----------------------------------------------------------------

What is the 'hand' in the commit message? Typo?

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ff185577e79d
Fix hang when HTML signature references non-existent image. r=aceman

Comment 11

[Jorg K (CEST = GMT+2)]

Beta (TB 63):
https://hg.mozilla.org/releases/comm-beta/rev/c527415f3f48f16b5ec20c2f59f4695a70fa820e

Comment 12

[Jorg K (CEST = GMT+2)]

TB 60.3 ESR:
https://hg.mozilla.org/releases/comm-esr60/rev/6e5794497bbb1d61772a15439b697e3f1b0c59fc