Closed Bug 1477448 Opened Last year Closed Last year

blob-invalidation: Crash in void mozilla::layers::DIGroup::PaintItemRange

Categories

(Core :: Graphics: WebRender, defect, critical)

x86_64
All
defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox-esr52 --- unaffected
firefox-esr60 --- unaffected
firefox61 --- unaffected
firefox62 --- unaffected
firefox63 --- fixed

People

(Reporter: darkspirit, Assigned: jrmuizel)

References

(Blocks 1 open bug)

Details

(Keywords: crash)

Crash Data

Attachments

(2 files)

Nvidia, GP106 [GeForce GTX 1060 6GB]

This bug was filed from the Socorro interface and is
report bp-ebd2e6e6-a34c-4542-9499-5f2180180720.
=============================================================

Top 10 frames of crashing thread:

0 xul.dll void mozilla::layers::DIGroup::PaintItemRange gfx/layers/wr/WebRenderCommandBuilder.cpp:707
1 xul.dll void mozilla::layers::DIGroup::PaintItemRange gfx/layers/wr/WebRenderCommandBuilder.cpp:713
2 xul.dll void mozilla::layers::DIGroup::EndGroup gfx/layers/wr/WebRenderCommandBuilder.cpp:624
3 xul.dll mozilla::layers::WebRenderCommandBuilder::CreateWebRenderCommandsFromDisplayList gfx/layers/wr/WebRenderCommandBuilder.cpp:1248
4 xul.dll nsDisplaySVGWrapper::CreateWebRenderCommands layout/painting/nsDisplayList.cpp:9823
5 xul.dll mozilla::layers::WebRenderCommandBuilder::CreateWebRenderCommandsFromDisplayList gfx/layers/wr/WebRenderCommandBuilder.cpp:1341
6 xul.dll nsDisplayTransform::CreateWebRenderCommands layout/painting/nsDisplayList.cpp:8336
7 xul.dll mozilla::layers::WebRenderCommandBuilder::CreateWebRenderCommandsFromDisplayList gfx/layers/wr/WebRenderCommandBuilder.cpp:1341
8 xul.dll nsDisplayTransform::CreateWebRenderCommands layout/painting/nsDisplayList.cpp:8336
9 xul.dll mozilla::layers::WebRenderCommandBuilder::CreateWebRenderCommandsFromDisplayList gfx/layers/wr/WebRenderCommandBuilder.cpp:1341

=============================================================
Crash Signature: [@ void mozilla::layers::DIGroup::PaintItemRange] → [@ void mozilla::layers::DIGroup::PaintItemRange] [@ mozilla::layers::DIGroup::PaintItemRange ]
OS: Windows 10 → All
Summary: Crash in void mozilla::layers::DIGroup::PaintItemRange → blob-invalidation: Crash in void mozilla::layers::DIGroup::PaintItemRange
https://app.datadoghq.com/ seems to trigger this bug quite often (2nd time for me today), unfortunately you need an account.
You can email it to me.
Assignee: nobody → jmuizelaar
I can reproduce it thanks.
Comment on attachment 8998364 [details] [diff] [review]
Ensure ToDeviceSpace() preserves EmptyRects

Review of attachment 8998364 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/wr/WebRenderCommandBuilder.cpp
@@ +384,5 @@
>    static IntRect
>    ToDeviceSpace(nsRect aBounds, Matrix& aMatrix, int32_t aAppUnitsPerDevPixel, LayerIntPoint aOffset)
>    {
> +    // RoundedOut can convert empty rectangles to non-empty ones
> +    // so special case them here

Maybe add a comment here that says that it's important to keep empty rects empty in order to satisfy assertions.
Attachment #8998364 - Flags: review?(mstange) → review+
(In reply to Jeff Muizelaar [:jrmuizel] from comment #5)
> Created attachment 8998364 [details] [diff] [review]
> Ensure ToDeviceSpace() preserves EmptyRects

Could you land this patch or is this bug blocked on something else? Thank you.
bp-ab2f8337-59dd-4402-b7e3-9d9670180822
Flags: needinfo?(jmuizelaar)
Pushed by jmuizelaar@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c79aceb5bf3d
Ensure ToDeviceSpace() preserves EmptyRects. r=mstange
Sorry, I forgot about this.
Flags: needinfo?(jmuizelaar)
https://hg.mozilla.org/mozilla-central/rev/c79aceb5bf3d
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Big perf wins:

== Change summary for alert #15276 (as of Wed, 22 Aug 2018 23:22:37 GMT) ==

Improvements:

 19%  tsvgx linux64-qr opt e10s stylo     328.51 -> 266.64
 18%  tsvgx windows10-64-qr opt e10s stylo357.56 -> 292.06

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=15276
That's an unexpected surprise.
See Also: → 1493616
You need to log in before you can comment on or make changes to this bug.