1477448 - blob-invalidation: Crash in void mozilla::layers::DIGroup::PaintItemRange

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Darkspirit]

Nvidia, GP106 [GeForce GTX 1060 6GB]

This bug was filed from the Socorro interface and is
report bp-ebd2e6e6-a34c-4542-9499-5f2180180720.
=============================================================

Top 10 frames of crashing thread:

0 xul.dll void mozilla::layers::DIGroup::PaintItemRange gfx/layers/wr/WebRenderCommandBuilder.cpp:707
1 xul.dll void mozilla::layers::DIGroup::PaintItemRange gfx/layers/wr/WebRenderCommandBuilder.cpp:713
2 xul.dll void mozilla::layers::DIGroup::EndGroup gfx/layers/wr/WebRenderCommandBuilder.cpp:624
3 xul.dll mozilla::layers::WebRenderCommandBuilder::CreateWebRenderCommandsFromDisplayList gfx/layers/wr/WebRenderCommandBuilder.cpp:1248
4 xul.dll nsDisplaySVGWrapper::CreateWebRenderCommands layout/painting/nsDisplayList.cpp:9823
5 xul.dll mozilla::layers::WebRenderCommandBuilder::CreateWebRenderCommandsFromDisplayList gfx/layers/wr/WebRenderCommandBuilder.cpp:1341
6 xul.dll nsDisplayTransform::CreateWebRenderCommands layout/painting/nsDisplayList.cpp:8336
7 xul.dll mozilla::layers::WebRenderCommandBuilder::CreateWebRenderCommandsFromDisplayList gfx/layers/wr/WebRenderCommandBuilder.cpp:1341
8 xul.dll nsDisplayTransform::CreateWebRenderCommands layout/painting/nsDisplayList.cpp:8336
9 xul.dll mozilla::layers::WebRenderCommandBuilder::CreateWebRenderCommandsFromDisplayList gfx/layers/wr/WebRenderCommandBuilder.cpp:1341

=============================================================

Comment 1

[Francois Guerraz]

https://app.datadoghq.com/ seems to trigger this bug quite often (2nd time for me today), unfortunately you need an account.

Comment 2

[Darkspirit]

Attachment: 2018-08-07_18-05-59.mp4

(In reply to Francois Guerraz from comment #1)
Thanks! I can reproduce. Who would like to receive my login data?

https://app.datadoghq.com/dash/host/551702142?live=false&from_ts=1533656605000&to_ts=1533656905000&page=0&is_auto=false&tile_size=m
bp-0653d3e9-fabb-4c31-89a9-d65fe0180807

Comment 3

[Jeff Muizelaar [:jrmuizel]]

You can email it to me.

Comment 4

[Jeff Muizelaar [:jrmuizel]]

I can reproduce it thanks.

Comment 5

[Jeff Muizelaar [:jrmuizel]]

Attachment: Ensure ToDeviceSpace() preserves EmptyRects

Comment 6

[Markus Stange [:mstange]]

Comment on attachment 8998364 [details] [diff] [review]
Ensure ToDeviceSpace() preserves EmptyRects

Review of attachment 8998364 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/wr/WebRenderCommandBuilder.cpp
@@ +384,5 @@
>    static IntRect
>    ToDeviceSpace(nsRect aBounds, Matrix& aMatrix, int32_t aAppUnitsPerDevPixel, LayerIntPoint aOffset)
>    {
> +    // RoundedOut can convert empty rectangles to non-empty ones
> +    // so special case them here

Maybe add a comment here that says that it's important to keep empty rects empty in order to satisfy assertions.

Comment 7

[Darkspirit]

"You have 8 days left in your trial"

Comment 8

[Darkspirit]

(In reply to Jeff Muizelaar [:jrmuizel] from comment #5)
> Created attachment 8998364 [details] [diff] [review]
> Ensure ToDeviceSpace() preserves EmptyRects

Could you land this patch or is this bug blocked on something else? Thank you.
bp-ab2f8337-59dd-4402-b7e3-9d9670180822

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c79aceb5bf3d
Ensure ToDeviceSpace() preserves EmptyRects. r=mstange

Comment 10

[Jeff Muizelaar [:jrmuizel]]

Sorry, I forgot about this.

Comment 11

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/c79aceb5bf3d

Comment 12

[Ionuț Goldan [:igoldan]]

Big perf wins:

== Change summary for alert #15276 (as of Wed, 22 Aug 2018 23:22:37 GMT) ==

Improvements:

 19%  tsvgx linux64-qr opt e10s stylo     328.51 -> 266.64
 18%  tsvgx windows10-64-qr opt e10s stylo357.56 -> 292.06

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=15276

Comment 13

[Jeff Muizelaar [:jrmuizel]]

That's an unexpected surprise.