1477540 - RemoteSpellcheckEngineChild::~RemoteSpel: -Werror=unused-result

Status: RESOLVED FIXED

(Core :: Spelling checker, defect)

Description

[Sylvestre Ledru [:Sylvestre]]

/root/firefox-gcc-last/extensions/spellcheck/hunspell/glue/RemoteSpellCheckEngineChild.cpp: In member function 'virtual mozilla::ipc::IPCResult mozilla::RemoteSpellcheckEngineChild::RecvNotifyOfCurrentDictionary(const nsString&, const intptr_t&)':
/root/firefox-gcc-last/extensions/spellcheck/hunspell/glue/RemoteSpellCheckEngineChild.cpp:61:45: error: ignoring return value of 'nsTArray_Impl<E, Alloc>::elem_type nsTArray_Impl<E, Alloc>::PopLastElement() [with E = mozilla::UniquePtr<mozilla::MozPromiseHolder<mozilla::MozPromise<bool, nsresult, false> > >; Alloc = nsTArrayInfallibleAllocator; nsTArray_Impl<E, Alloc>::elem_type = mozilla::UniquePtr<mozilla::MozPromiseHolder<mozilla::MozPromise<bool, nsresult, false> > >]', declared with attribute warn_unused_result [-Werror=unused-result]
     (void) mResponsePromises.PopLastElement();
                                             ^

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1477540 - Use RemoveLastElement instead of PopLastElement

The later is only interesting when the returned value is used

Review commit: https://reviewboard.mozilla.org/r/258608/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/258608/

Comment 2

[Brian Hackett [Laid off!]]

Comment on attachment 8994019 [details]
Bug 1477540 - Use RemoveLastElement instead of PopLastElement

https://reviewboard.mozilla.org/r/258608/#review265596

Thanks!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/061213ccc62a
Use RemoveLastElement instead of PopLastElement r=bhackett

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/061213ccc62a