1477630 - AS Router Snippets appear along with onboarding

Status: RESOLVED DUPLICATE of bug 1488758

(Firefox :: New Tab Page, defect, P2)

Description

[Giorgos Logiotatidis [:giorgos]]

Attachment: Screenshot from 2018-07-23 10-39-58.png

AS Router snippets should not appear unless onboarding has been completed to match the current implementation of snippets.


STR:
 - Setup a new profile on Fx 61
 - Set browser.newtabpage.activity-stream.asrouterExperimentEnabled to true
 - Set browser.newtabpage.activity-stream.asrouter.snippetsUrl to browser.newtabpage.activity-stream.asrouter.snippetsUrl;https://snippets.cdn.mozilla.net/6/Firefox/61.0.1/20180719220047/Linux_x86_64-gcc3/en-US/release/Linux/default/default/


Outcome:
 Snippets appear along with onboarding call. See attached screenshot.


Expected Outcome:
 Until onboarding tour is completed snippets must not appear.

Comment 1

[Giorgos Logiotatidis [:giorgos]]

We also need a mechanism to override onboarding and display a snippet for high priority cases. Do you need another bug for this Kate?

Comment 2

[Kate Hudson :k88hudson]

As the current plan is for the existing onboarding experience to be removed and replaced with a revised experience (only on about:welcome) (see https://bugzilla.mozilla.org/show_bug.cgi?id=1462415) further action should not be required to resolve this issue.

We can keep this issue open and resolve when 1462415 is resolved; if we change our plans, we may have to do something else to resolve the conflict.

Comment 3

[Giorgos Logiotatidis [:giorgos]]

(In reply to Giorgos Logiotatidis [:giorgos] from comment #1)
> We also need a mechanism to override onboarding and display a snippet for
> high priority cases. Do you need another bug for this Kate?

Kate is the override mechanism still required with the revised experience?

Comment 4

[Kate Hudson :k88hudson]

The override mechanism will not be required since there are no longer be any snippet-style onboarding messages (just a single overlay on about:welcome)

Comment 5

[Pascal Chevrel (relman team) -> :pascalc]

kate, what is the status of this bug with regard to our 63 release? Thanks

Comment 6

[Kate Hudson :k88hudson]

This will need to be fixed for 63 since we have now delayed the change-over of onboarding to 64. I think this should be covered by the pref consolidation in 1488758

Comment 7

[Ursula Sarracini (:ursula)]

This is fixed from bug 1488758 landing in Github. Closing this.