1477777 - Port bug 1476611 Flatten the "richlistbox" bindings to C-C

Status: RESOLVED FIXED

(Thunderbird :: General, enhancement)

Description

[Jorg K (CEST = GMT+2)]

As per bug 1476611 comment #9, M-C will straighten out some bindings after the removal of listbox.

So in part 1 they're removing unused methods from
toolkit/content/widgets/listbox.xml and
toolkit/content/widgets/richlistbox.xml

and in part 2 they're removing
toolkit/content/widgets/listbox.xml.

We're still extending listbox-base for attachments here:
https://dxr.mozilla.org/comm-central/rev/e5e1510b8d914bfa8439b21ba3f73e4f2e83e957/mail/base/content/mailWidgets.xml#23

Brian, do we need to fork listbox-base of can we extend something else?

Richard, can you help us here.

Comment 1

[Brian Grinstead [:bgrins]]

(In reply to Jorg K (GMT+2) from comment #0)
> As per bug 1476611 comment #9, M-C will straighten out some bindings after
> the removal of listbox.
> 
> So in part 1 they're removing unused methods from
> toolkit/content/widgets/listbox.xml and
> toolkit/content/widgets/richlistbox.xml
> 
> and in part 2 they're removing
> toolkit/content/widgets/listbox.xml.
> 
> We're still extending listbox-base for attachments here:
> https://dxr.mozilla.org/comm-central/rev/
> e5e1510b8d914bfa8439b21ba3f73e4f2e83e957/mail/base/content/mailWidgets.xml#23
> 
> Brian, do we need to fork listbox-base of can we extend something else?

We are folding listbox-base into richlistbox-base - so you might be able to extend richlistbox instead of listbox-base. You should be able to test if that works even ahead of Bug 1476611, since richlistbox already extends listbox-bsae.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: Bug1477777.patch

This makes the message header/ attachment list work again after the check-in of bug 1476611.

Tested with the patches on m-c applied.

Comment 3

[Jorg K (CEST = GMT+2)]

Comment on attachment 8994289 [details] [diff] [review]
Bug1477777.patch

This works surprisingly since we cook up our own attachment icons/text/size, etc. around here:
https://searchfox.org/comm-central/rev/f98fc73687c46fecad7b5f83b61e02ef081d1198/mail/base/content/mailWidgets.xml#465
I wonder whether we should just move that to richlist(items) in another bug.

Let's see what breaks (without having the M-C changes applied):
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=8e36d3830fa99b5a28ee637730922dc829fa9fc8

If nothing breaks, we could land this now without waiting for bug 1476611.

Comment 4

[Richard Marti (:Paenglab)]

I applied it without the m-c patches too and it worked. But of course run no tests.

Comment 5

[Jorg K (CEST = GMT+2)]

Comment on attachment 8994289 [details] [diff] [review]
Bug1477777.patch

Seems to work ;-)

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a08367c1e546
Port bug 1476611: Flatten the "richlistbox" bindings to TB. r=jorgk