1477818 - Periodic remote-settings update backed out due to test_remote_settings_poll.js failures

Status: RESOLVED FIXED

(Firefox :: Remote Settings Client, enhancement)

Description

[Ryan VanderMeulen [:RyanVM]]

Today's remote settings update caused failures in test_remote_settings_poll.js:
https://treeherder.mozilla.org/logviewer.html#?job_id=189517318&repo=autoland

This bustage affected both trunk and beta. Here's a link to the changeset in question, looks like a lot of tippytop.json changes in it.
https://hg.mozilla.org/integration/autoland/rev/469f678d1f15196b694297558e2f48891bffc420

Any idea what happened, Mathieu?

Comment 1

[Nan Jiang [:nanj]]

We (Activity Stream) did upload some Tippytop entries to remote settings on last Thursday in order to prepare bug 1437671 to land.

Mathieu, let me know if that's the cause of this bustage, we can pull those settings right away.

Comment 2

[Mathieu Leplatre [:leplatrem]]

> Any idea what happened, Mathieu?

In short, the test_remote_settings_poll.js was coupled to an Activity Stream collection that was published in production recently. Since it was published in production, a bot regularly commits the remote data in the code base (see Bug 1451040).

I don't have the details why the test would fail if the dumped data changes, but I now removed the coupling of the test with the dump: Bug 1476934 https://hg.mozilla.org/mozilla-central/rev/f00da9b0a455
 
Plus, the ActivityStream team decided that they wanted to disable the dump of remote data since it contains 3rd party urls etc. It should be all good now.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Does that mean bug 1476934 needs to land on Beta as well?

Comment 4

[Mathieu Leplatre [:leplatrem]]

> Does that mean bug 1476934 needs to land on Beta as well?

I didn't know that the periodic-updates job was already committing stuff on the beta tree.
So yes, it would make sense.

Comment 5

[Mathieu Leplatre [:leplatrem]]

I guess we can close this now that Bug 1476934 was verified in Beta