147789 - remove obsolete pref network.hosts.nntp_server

Status: RESOLVED FIXED

(MailNews Core :: Networking: NNTP, defect, P4)

Description

[Ariel Shkedi]

In defaults/pref/all.js there is a note that the default of 'news.mozilla.org'
needs to be changed to 'news' once the beta ends. So this is a reminder to do that.

The note is by, or to, 'sspitzer' but I don't know his email to add him as a CC.

Comment 1

[Mike Young]

Ring Ring....... Seth, Ben, 

has this been done, or is it still in neeed of being done? and what exactly does
this refer to? NS7 or Moz1.0?

Moz1.0 is almost out the door, so whichever it is, this should be looked at.

confirming since this seems to be known anyway.... 

Comment 2

[Ariel Shkedi]

Nominating for mozilla 1.0.1 and for the netscape (adt) release.

If this bug is determined to be invalid, at least remove the reminder message in
the prefs file, and close this bug.

Comment 3

[Jaime Rodriguez, Jr.]

pls have this reviewed by the Nav triage team, attach a patch, and get r/sr=
before nominating for checkin to the 1.0 branch. thanks!

removing adt1.0.1

Comment 4

[Samir Gehani]

-> MailNews

Comment 5

[Ariel Shkedi]

Does this need to be fixed? sspitzer? You added this, isn't it time to remove it
and change the default nntp_server back to just news?

Comment 6

[Ariel Shkedi]

Attachment: Patch to remove old text.

Change default nntp_sever to just 'news' instead of news.mozilla.org.

Comment 7

[[e-mail]]

Guessing here because the pref is never used :-)

Comment 8

[[e-mail]]

Comment on attachment 109665 [details] [diff] [review]
Patch to remove old text.

This is an unused pref to IMHO the correct fix is to remote the pref completely
and also the line in nsNntpService.cpp that refers to it.

Comment 9

[(not reading, please use [e-mail] instead)]

sorry for the spam.  making bugzilla reflect reality as I'm not working on these bugs.  filter on FOOBARCHEESE to remove these in bulk.

Comment 10

[Wayne Mery (:wsmwk)]

Neil in comment #8
> (From update of attachment 109665 [details] [diff] [review])
> This is an unused pref to IMHO the correct fix is to remote (sic) the pref completely
> and also the line in nsNntpService.cpp that refers to it.

If this pref is no longer appropriate, is there a need for a different implementation of default news server?

FWIW this was wontfixed in bug 8053 - perhaps for reasons that are no longer relevant.

Comment 11

[Wayne Mery (:wsmwk)]

see comment 10

Comment 12

[Magnus Melin [:mkmelin]]

Attachment: proposed fix

Remove it. 
Now, if I can only figure out the repo situation :/

Comment 13

[Magnus Melin [:mkmelin]]

changeset:   209:771f940f90f5
http://hg.mozilla.org/comm-central/index.cgi/rev/771f940f90f5

Checking in minimo/customization/all.js;
/cvsroot/mozilla/minimo/customization/all.js,v  <--  all.js
new revision: 1.55; previous revision: 1.54
done

mozilla-central part of the patch still to go...

Comment 14

[Magnus Melin [:mkmelin]]

pushed to mozilla-central also, changeset:   19107:853fde538b60
http://hg.mozilla.org/mozilla-central/rev/853fde538b60

->FIXED