1478183 - Update strings (including de) for about:welcome in Firefox 62

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Ed Lee :Mardak]

[Tracking Requested - why for this release]: about:welcome will be the default new user experience, and the de strings are not in beta 62.

Currently being exported to mozilla-central 63 in bug 1478144.

Comment 1

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/ea88051a288d

Comment 2

[Liz Henry (:lizzard) (relman/hg->git project)]

Flod, do you need to sign off on this before uplift to beta?

Comment 3

[Francesco Lodolo [:flod]]

(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #2)
> Flod, do you need to sign off on this before uplift to beta?

Double checked, but no need for sign off (these patches don't actually touch strings exposed to localization).

Comment 4

[Ed Lee :Mardak]

Attachment: de about:welcome 63

Looks to be good on nightly

Comment 5

[Ed Lee :Mardak]

Attachment: Bug 1478183 - Update strings (including de) for about:welcome in Firefox 62.

Review commit: https://reviewboard.mozilla.org/r/260546/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/260546/

Comment 6

[Ursula Sarracini (:ursula)]

Comment on attachment 8996471 [details]
Bug 1478183 - Update strings (including de) for about:welcome in Firefox 62.

https://reviewboard.mozilla.org/r/260546/#review267830

Thanks!

Comment 7

[Ed Lee :Mardak]

Attachment: cak plural form preference drop down

The string updates will also fix this plural form drop down issue for cak

Comment 8

[Ed Lee :Mardak]

Comment on attachment 8996471 [details]
Bug 1478183 - Update strings (including de) for about:welcome in Firefox 62.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/260546/diff/1-2/

Comment 9

[Ed Lee :Mardak]

Comment on attachment 8996471 [details]
Bug 1478183 - Update strings (including de) for about:welcome in Firefox 62.

Approval Request Comment
[Feature/Bug causing the regression]: about:welcome added in 62
[User impact if declined]: Some major locales will have untranslated first run experiences, e.g., de. Other locales would have outdated/incorrect strings, e.g., attachment 8996790 [details]
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: Not really
[Why is the change risky/not risky?]: Mainly updating strings and adding ja-JP-mac locale
[String changes made/needed]: Yes, but these are the translated strings and don't trigger additional translation.

Comment 10

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8996471 [details]
Bug 1478183 - Update strings (including de) for about:welcome in Firefox 62.

First run/about:welcome fixes for various locales. 
OK to uplift for beta 16.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/4a9fed27bebf