Closed Bug 1478183 Opened 2 years ago Closed 2 years ago

Update strings (including de) for about:welcome in Firefox 62

Categories

(Firefox :: New Tab Page, defect, P1)

defect

Tracking

()

RESOLVED FIXED
Firefox 62
Iteration:
63.3 - Aug 6
Tracking Status
firefox62 + fixed
firefox63 --- fixed

People

(Reporter: Mardak, Assigned: Mardak)

References

Details

User Story

https://github.com/mozilla/activity-stream/compare/firefox-62b11...firefox-62b16

Attachments

(3 files)

[Tracking Requested - why for this release]: about:welcome will be the default new user experience, and the de strings are not in beta 62.

Currently being exported to mozilla-central 63 in bug 1478144.
https://hg.mozilla.org/mozilla-central/rev/ea88051a288d
Target Milestone: --- → Firefox 63
Flod, do you need to sign off on this before uplift to beta?
Flags: needinfo?(francesco.lodolo)
(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #2)
> Flod, do you need to sign off on this before uplift to beta?

Double checked, but no need for sign off (these patches don't actually touch strings exposed to localization).
Flags: needinfo?(francesco.lodolo)
Attached image de about:welcome 63
Looks to be good on nightly
See Also: → 1478930
User Story: (updated)
Depends on: 1471514
Comment on attachment 8996471 [details]
Bug 1478183 - Update strings (including de) for about:welcome in Firefox 62.

https://reviewboard.mozilla.org/r/260546/#review267830

Thanks!
Attachment #8996471 - Flags: review?(usarracini) → review+
The string updates will also fix this plural form drop down issue for cak
Attachment #8996790 - Attachment description: Screen Shot 2018-07-31 at 10.19.23 AM.png → cak plural form preference drop down
Comment on attachment 8996471 [details]
Bug 1478183 - Update strings (including de) for about:welcome in Firefox 62.

Approval Request Comment
[Feature/Bug causing the regression]: about:welcome added in 62
[User impact if declined]: Some major locales will have untranslated first run experiences, e.g., de. Other locales would have outdated/incorrect strings, e.g., attachment 8996790 [details]
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: Not really
[Why is the change risky/not risky?]: Mainly updating strings and adding ja-JP-mac locale
[String changes made/needed]: Yes, but these are the translated strings and don't trigger additional translation.
Attachment #8996471 - Flags: approval-mozilla-beta?
Comment on attachment 8996471 [details]
Bug 1478183 - Update strings (including de) for about:welcome in Firefox 62.

First run/about:welcome fixes for various locales. 
OK to uplift for beta 16.
Attachment #8996471 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: Firefox 63 → Firefox 62
User Story: (updated)
Blocks: 1476959
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.