1478330 - Add infrastructure to generate enums from the rust definition instead of duplicating code.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P2)

Description

[Emilio Cobos Álvarez (:emilio)]

Going to need this to make appearance not suck.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1478330: Generate StyleDisplay using cbindgen. r=xidorn,heycam

We use the same setup WR uses, which is checking-in the files.

But I think it's much better than keeping the two things in sync manually :)

When you add a new value, you need to add it to the rust source, then run the
command, but since it doesn't need to build the style crate (it uses the Rust
AST, doesn't build) there's no problem.

Comment 2

[Phabricator Automation]

Comment on attachment 8994807 [details]
Bug 1478330: Generate StyleDisplay using cbindgen. r=xidorn,heycam

Cameron McCormack (:heycam) has approved the revision.

https://phabricator.services.mozilla.com/D2354

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/230ea1f373ff
Generate StyleDisplay using cbindgen. r=heycam

Comment 4

[Stefan Hindli [:stefan_hindli]]

Backed out changeset 230ea1f373ff (Bug 1478330) for Linting failure on a CLOSED TREE

Failure: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&fromchange=4e08eb5f94e73e34f331f8dce08f77e9953d525a&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-classifiedState=unclassified&selectedJob=190272675
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=190272675&repo=mozilla-inbound&lineNumber=110

[vcs 2018-07-26T13:39:19.117Z] transferred 2.42 GB in 77.7 seconds (31.9 MB/sec)
[vcs 2018-07-26T13:39:19.892Z] finished applying clone bundle
[vcs 2018-07-26T13:39:20.349Z] searching for changes
[vcs 2018-07-26T13:39:34.064Z] unhandled URLError; reason type: str; value: Internal Server ErrorPERFHERDER_DATA: {"framework": {"name": "vcs"}, "suites": [{"extraOptions": ["c3.xlarge"], "lowerIsBetter": true, "name": "clone_errored", "shouldAlert": false, "subtests": [], "value": 93.39171290397644}, {"extraOptions": ["c3.xlarge"], "lowerIsBetter": true, "name": "overall", "shouldAlert": false, "subtests": [], "value": 93.89301300048828}]}
[vcs 2018-07-26T13:39:34.064Z] abort: HTTP Error 500: Internal Server Error
[taskcluster 2018-07-26 13:39:36.140Z] === Task Finished ===
[taskcluster 2018-07-26 13:39:36.221Z] Artifact "public" not found at "/builds/worker/artifacts"
[taskcluster 2018-07-26 13:39:36.915Z] Unsuccessful task run with exit code: 255 completed in 131.302 seconds

Comment 5

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c17688bd7bfe
Backed out changeset 230ea1f373ff for Linting failure on a CLOSED TREE

Comment 6

[Emilio Cobos Álvarez (:emilio)]

That failure is not related to this patch. Looks like a server error.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4b1c6659a5f5
Generate StyleDisplay using cbindgen. r=heycam

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/4b1c6659a5f5