1478813 - Autogenerate ServoGeneratedStyleConsts.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P3)

Description

[Emilio Cobos Álvarez (:emilio)]

Per the discussion in bug 1478330.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Auto-generate ServoStyleConsts.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

https://phabricator.services.mozilla.com/D2447 is the current WIP, https://treeherder.mozilla.org/#/jobs?repo=try&revision=ca80bc8a53f979c3e3ec2348beec8bb30aac3d27 the current try results.

I need to figure out the windows toolchain stuff and the Linux x64 debug Bp failure.

Any hand on that would be appreciated, but otherwise I'll dig a bit more tomorrow :)

Comment 3

[Emilio Cobos Álvarez (:emilio)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a20d7407d600078d25974c8f818dc7faaf18a00a

Comment 4

[Phabricator Automation]

Comment on attachment 8995336 [details]
Auto-generate ServoStyleConsts.

Xidorn Quan [:xidorn] UTC+10 has approved the revision.

https://phabricator.services.mozilla.com/D2447

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Install cbindgen from the toolchain job instal of via cargo install. r=ted

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Attachment: Add cbindgen toolchain job and install via bootstrap. r=ted

And require it for taskcluster build already, because it doesn't harm and lets
me put all the yml changes in the same commit.

I gave up cross-compiling for OSX after a few tries and after realizing it
wasn't enough with cctools and such, but that I also needed the Mac SDK, for
which I don't have permission...

Comment 7

[(not currently active) Ted Mielczarek]

Comment on attachment 8997017 [details]
Add cbindgen toolchain job and install via bootstrap. r=ted

Ted Mielczarek [:ted] [:ted.mielczarek] has approved the revision.

Comment 8

[(not currently active) Ted Mielczarek]

Comment on attachment 8995336 [details]
Auto-generate ServoStyleConsts.

Ted Mielczarek [:ted] [:ted.mielczarek] has approved the revision.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/668856ac23b1
Add cbindgen toolchain job and install via bootstrap. r=ted

Comment 10

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/668856ac23b1

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4b9dcf8f2e6c
Auto-generate ServoStyleConsts. r=xidorn,ted

Comment 12

[Cosmin Sabou [:CosminS]]

Backed out changeset for build bustages because cbindgen is missing.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=4b9dcf8f2e6c1b9b295193d13647664f6cee3d07&filter-resultStatus=busted&selectedJob=194574443

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=194574387&repo=mozilla-inbound&lineNumber=1153

Backout link: https://hg.mozilla.org/integration/mozilla-inbound/rev/22d17330182c653df514ba1fa8b22e4e3d235f88

[task 2018-08-17T17:11:44.387Z] 17:11:44     INFO -  DEBUG: cbindgen: Trying /builds/worker/workspace/build/src/cbindgen/cbindgen
[task 2018-08-17T17:11:44.388Z] 17:11:44     INFO -  ERROR: Cannot find cbindgen
[task 2018-08-17T17:11:44.424Z] 17:11:44     INFO -  *** Fix above errors and then restart with\
[task 2018-08-17T17:11:44.426Z] 17:11:44     INFO -                 "/usr/bin/make -f client.mk build"
[task 2018-08-17T17:11:44.426Z] 17:11:44     INFO -  client.mk:123: recipe for target 'configure' failed
[task 2018-08-17T17:11:44.426Z] 17:11:44     INFO -  make: *** [configure] Error 1
[task 2018-08-17T17:11:44.438Z] 17:11:44     INFO -  Error running mach:
[task 2018-08-17T17:11:44.439Z] 17:11:44     INFO -      ['--log-no-times', 'static-analysis', 'autotest', '--intree-tool']
[task 2018-08-17T17:11:44.440Z] 17:11:44     INFO -  The error occurred in the implementation of the invoked mach command.
[task 2018-08-17T17:11:44.441Z] 17:11:44     INFO -  This should never occur and is likely a bug in the implementation of that
[task 2018-08-17T17:11:44.443Z] 17:11:44     INFO -  command. Consider filing a bug for this issue.
[task 2018-08-17T17:11:44.445Z] 17:11:44     INFO -  If filing a bug, please include the full output of mach, including this error
[task 2018-08-17T17:11:44.447Z] 17:11:44     INFO -  message.
[task 2018-08-17T17:11:44.449Z] 17:11:44     INFO -  The details of the failure are as follows:
[task 2018-08-17T17:11:44.450Z] 17:11:44     INFO -  AttributeError: 'NoneType' object has no attribute 'substs'
[task 2018-08-17T17:11:44.452Z] 17:11:44     INFO -    File "/builds/worker/workspace/build/src/python/mozbuild/mozbuild/mach_commands.py", line 1906, in autotest
[task 2018-08-17T17:11:44.454Z] 17:11:44     INFO -      "clang-tidy" + config.substs.get('BIN_SUFFIX', ''))
[task 2018-08-17T17:11:44.484Z] 17:11:44    ERROR - Return code: 1
[task 2018-08-17T17:11:44.485Z] 17:11:44  WARNING - setting return code to 2
[task 2018-08-17T17:11:44.486Z] 17:11:44    FATAL - 'mach static-analysis autotest --intree-tool' did not run successfully. Please check log for errors.
[task 2018-08-17T17:11:44.487Z] 17:11:44    FATAL - Running post_fatal callback...
[task 2018-08-17T17:11:44.488Z] 17:11:44    FATAL - Exiting -1
[task 2018-08-17T17:11:44.488Z] 17:11:44     INFO - [mozharness: 2018-08-17 17:11:44.488599Z] Finished static-analysis-autotest step (failed)
[task 2018-08-17T17:11:44.489Z] 17:11:44     INFO - Running post-run listener: _summarize
[task 2018-08-17T17:11:44.490Z] 17:11:44    ERROR - # TBPL FAILURE #
[task 2018-08-17T17:11:44.490Z] 17:11:44     INFO - [mozharness: 2018-08-17 17:11:44.490052Z] FxDesktopBuild summary:
[task 2018-08-17T17:11:44.491Z] 17:11:44    ERROR - # TBPL FAILURE #

Comment 13

[Emilio Cobos Álvarez (:emilio)]

Ah, missed some static analysis, valgrind jobs where I should add the cbindgen dependency. Should be trivial.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8fc7f2fb5ffc
Auto-generate ServoStyleConsts. r=xidorn,ted

Comment 15

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/8fc7f2fb5ffc