Closed Bug 1478338 Opened 3 years ago Closed 2 years ago
Configure scripts don't pass flake8
46 bytes, text/x-phabricator-request
|Details | Review|
Bug 1406668 attempted to enable flake8 on build/moz.configure/*.configure files, however due to a bug in our flake8 integration those files were not actually being linted unless you explicitly specified the file path. The flake8 integration issue was since fixed by bug 1473308, but I had to skip most of the *.configure files (they were either never flake8 compliant, or bustage slipped in after the fact). To re-enable them, remove this line: https://searchfox.org/mozilla-central/rev/bdfd20ef30d521b57d5b6feeda71325e8b4cad66/.flake8#8 Note there other *.configure scripts scattered around the tree that are skipped in there as well.
Sigh, does that mean we'll have even more rules to deal with? The rules for whitespace lines already make writing *.configure files annoying.
build/moz.configure/*.configure is almost green and almost didn't regress in 10 months. What are your concerns? (these checks are enabled at review phase btw)
Keeping it open for the other configure files
Assignee: nobody → sledru
Comment on attachment 8994829 [details] bug 1478338 - Fix some flake8 regression in moz.configure/ r?froydnj Nathan Froyd [:froydnj] has approved the revision. https://phabricator.services.mozilla.com/D2356
Attachment #8994829 - Flags: review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/4738f8111a82 Fix some flake8 regression in moz.configure/ r=froydnj
Backed out for linting failure at builds/worker/checkouts/gecko/build/moz.configure/android-ndk.configure:8 Push that caused the failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=4738f8111a82b484239f233967246be4e6bdbefd Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=190038597&repo=autoland&lineNumber=273 Backout: https://hg.mozilla.org/integration/autoland/rev/766820943ced2e64c7f06ff8f56b03909aba43b1
I will have a look, thanks!
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.