1478338 - Configure scripts don't pass flake8

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Andrew Halberstadt [:ahal]]

Bug 1406668 attempted to enable flake8 on build/moz.configure/*.configure files, however due to a bug in our flake8 integration those files were not actually being linted unless you explicitly specified the file path.

The flake8 integration issue was since fixed by bug 1473308, but I had to skip most of the *.configure files (they were either never flake8 compliant, or bustage slipped in after the fact).

To re-enable them, remove this line:
https://searchfox.org/mozilla-central/rev/bdfd20ef30d521b57d5b6feeda71325e8b4cad66/.flake8#8

Note there other *.configure scripts scattered around the tree that are skipped in there as well.

Comment 1

[Nathan Froyd [:froydnj]]

Sigh, does that mean we'll have even more rules to deal with?  The rules for whitespace lines already make writing *.configure files annoying.

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Attachment: bug 1478338 - Fix some flake8 regression in moz.configure/ r?froydnj

Comment 3

[Sylvestre Ledru [:Sylvestre]]

build/moz.configure/*.configure is almost green and almost didn't regress in 10 months.
What are your concerns? (these checks are enabled at review phase btw)

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Keeping it open for the other configure files

Comment 5

[Phabricator Automation]

Comment on attachment 8994829 [details]
bug 1478338 - Fix some flake8 regression in moz.configure/ r?froydnj

Nathan Froyd [:froydnj] has approved the revision.

https://phabricator.services.mozilla.com/D2356

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4738f8111a82
Fix some flake8 regression in moz.configure/ r=froydnj

Comment 7

[Andreea Pavel [:apavel]]

Backed out for linting failure at builds/worker/checkouts/gecko/build/moz.configure/android-ndk.configure:8

Push that caused the failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=4738f8111a82b484239f233967246be4e6bdbefd

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=190038597&repo=autoland&lineNumber=273

Backout: https://hg.mozilla.org/integration/autoland/rev/766820943ced2e64c7f06ff8f56b03909aba43b1

Comment 8

[Sylvestre Ledru [:Sylvestre]]

I will have a look, thanks!

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:sylvestre, maybe it's time to close this bug?

Comment 10

[Sylvestre Ledru [:Sylvestre]]

Closing, we should open a new bug to continue the work