Closed
Bug 1406668
Opened 7 years ago
Closed 7 years ago
Make build/moz.configure/*.configure compliant to the flake8 format + add to the list of directories to check
Categories
(Firefox Build System :: General, enhancement)
Firefox Build System
General
Tracking
(firefox58 fixed)
RESOLVED
FIXED
mozilla58
Tracking | Status | |
---|---|---|
firefox58 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: Sylvestre)
References
Details
Attachments
(1 file)
No description provided.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8916283 [details]
Bug 1406668 - Make build/moz.configure/*.configure compliant to the pep8 format + add to the list of directories to check
https://reviewboard.mozilla.org/r/187500/#review193058
::: commit-message-1e7b0:1
(Diff revision 3)
> +Bug 1406668 - Make build/moz.configure/*.configure compliant to the flake8 format + add to the list of directories to check r?glandium
The format is pep8. flake8 is the name of the program that checks for it (and more).
Is this the result of running autopep8, or was it manual?
::: build/moz.configure/rust.configure:134
(Diff revision 3)
> #
> # https://github.com/rust-lang/rust/blob/master/src/librustc_back/target/mod.rs
>
> # Avoid having to write out os+kernel for all the platforms where
> # they don't differ.
> - os_or_kernel = host_or_target.kernel if host_or_target.kernel == 'Linux' and host_or_target.os != 'Android' else host_or_target.os
> + os_or_kernel = (host_or_target.kernel
I bitrotted you here
::: build/moz.configure/windows.configure
(Diff revision 3)
> -
> option('--with-windows-version', nargs=1, default='603',
> help='Windows SDK version to target. Win 8.1 (603) is currently'
> 'the minimum supported version.')
> -
> @depends('--with-windows-version')
Removing those lines is so horrible.
Attachment #8916283 -
Flags: review?(mh+mozilla)
Comment hidden (mozreview-request) |
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8916283 [details]
Bug 1406668 - Make build/moz.configure/*.configure compliant to the pep8 format + add to the list of directories to check
https://reviewboard.mozilla.org/r/187500/#review193800
Attachment #8916283 -
Flags: review?(mh+mozilla) → review+
Comment 7•7 years ago
|
||
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.
hg error in cmd: hg rebase -s c7f9e07d1cfd -d 3c8730c5a21f: rebasing 425999:c7f9e07d1cfd "Bug 1406668 - Make build/moz.configure/*.configure compliant to the pep8 format + add to the list of directories to check r=glandium" (tip)
merging build/moz.configure/toolchain.configure
merging tools/lint/flake8.yml
warning: conflicts while merging build/moz.configure/toolchain.configure! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Comment 8•7 years ago
|
||
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.
hg error in cmd: hg rebase -s c7f9e07d1cfd -d 44d7a43c481a: rebasing 426048:c7f9e07d1cfd "Bug 1406668 - Make build/moz.configure/*.configure compliant to the pep8 format + add to the list of directories to check r=glandium"
merging build/moz.configure/toolchain.configure
merging tools/lint/flake8.yml
warning: conflicts while merging build/moz.configure/toolchain.configure! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Comment hidden (mozreview-request) |
Comment 10•7 years ago
|
||
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b526011049ee
Make build/moz.configure/*.configure compliant to the pep8 format + add to the list of directories to check r=glandium
Comment 11•7 years ago
|
||
Backed out for linting failures:
https://hg.mozilla.org/integration/autoland/rev/5f94b18b43935d86c632e25cbb12bf5f19827ce1
Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=b526011049eed2b052cb5dc93f7fa14a4f970c0b&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=136500021&repo=autoland
Flags: needinfo?(sledru)
Comment hidden (mozreview-request) |
Assignee | ||
Comment 13•7 years ago
|
||
For some reasons, the flake8 file was missing
Flags: needinfo?(sledru)
Comment 14•7 years ago
|
||
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4dc78384cb58
Make build/moz.configure/*.configure compliant to the pep8 format + add to the list of directories to check r=glandium
Comment 15•7 years ago
|
||
Backed out for flake8 linting failures:
https://treeherder.mozilla.org/logviewer.html#?job_id=136506091&repo=autoland
Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=4dc78384cb58c67de770ef207bbd700e7a982960&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=136506091&repo=autoland
[task 2017-10-12T13:07:16.454Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/build/moz.configure/java.configure:64:100 | line too long (114 > 99 characters) (E501)
[task 2017-10-12T13:07:16.454Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/build/moz.configure/old.configure:125:32 | SyntaxError: invalid syntax (E999)
[task 2017-10-12T13:07:16.454Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/build/moz.configure/toolchain.configure:467:100 | line too long (109 > 99 characters) (E501)
[task 2017-10-12T13:07:16.454Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/build/moz.configure/toolchain.configure:517:100 | line too long (158 > 99 characters) (E501)
[task 2017-10-12T13:07:16.454Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/build/moz.configure/toolchain.configure:1283:1 | expected 2 blank lines, found 1 (E302)
Flags: needinfo?(sledru)
Comment 16•7 years ago
|
||
Comment hidden (mozreview-request) |
Comment 18•7 years ago
|
||
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d14dd0e5c41a
Make build/moz.configure/*.configure compliant to the pep8 format + add to the list of directories to check r=glandium
Assignee | ||
Updated•7 years ago
|
Flags: needinfo?(sledru)
Comment 19•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•