Make build/moz.configure/*.configure compliant to the flake8 format + add to the list of directories to check

RESOLVED FIXED in Firefox 58

Status

enhancement
RESOLVED FIXED
2 years ago
10 months ago

People

(Reporter: sylvestre, Assigned: sylvestre)

Tracking

(Blocks 1 bug)

Trunk
mozilla58
Dependency tree / graph

Firefox Tracking Flags

(firefox58 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

2 years ago
No description provided.
Assignee

Updated

2 years ago
Depends on: 1406669
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 4

2 years ago
mozreview-review
Comment on attachment 8916283 [details]
Bug 1406668 - Make build/moz.configure/*.configure compliant to the pep8 format + add to the list of directories to check

https://reviewboard.mozilla.org/r/187500/#review193058

::: commit-message-1e7b0:1
(Diff revision 3)
> +Bug 1406668 - Make build/moz.configure/*.configure compliant to the flake8 format + add to the list of directories to check r?glandium

The format is pep8. flake8 is the name of the program that checks for it (and more).

Is this the result of running autopep8, or was it manual?

::: build/moz.configure/rust.configure:134
(Diff revision 3)
>          #
>          # https://github.com/rust-lang/rust/blob/master/src/librustc_back/target/mod.rs
>  
>          # Avoid having to write out os+kernel for all the platforms where
>          # they don't differ.
> -        os_or_kernel = host_or_target.kernel if host_or_target.kernel == 'Linux' and host_or_target.os != 'Android' else host_or_target.os
> +        os_or_kernel = (host_or_target.kernel

I bitrotted you here

::: build/moz.configure/windows.configure
(Diff revision 3)
> -
>  option('--with-windows-version', nargs=1, default='603',
>         help='Windows SDK version to target. Win 8.1 (603) is currently'
>              'the minimum supported version.')
> -
>  @depends('--with-windows-version')

Removing those lines is so horrible.
Attachment #8916283 - Flags: review?(mh+mozilla)
Comment hidden (mozreview-request)

Comment 6

2 years ago
mozreview-review
Comment on attachment 8916283 [details]
Bug 1406668 - Make build/moz.configure/*.configure compliant to the pep8 format + add to the list of directories to check

https://reviewboard.mozilla.org/r/187500/#review193800
Attachment #8916283 - Flags: review?(mh+mozilla) → review+

Comment 7

2 years ago
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s c7f9e07d1cfd -d 3c8730c5a21f: rebasing 425999:c7f9e07d1cfd "Bug 1406668 - Make build/moz.configure/*.configure compliant to the pep8 format + add to the list of directories to check r=glandium" (tip)
merging build/moz.configure/toolchain.configure
merging tools/lint/flake8.yml
warning: conflicts while merging build/moz.configure/toolchain.configure! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 8

2 years ago
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s c7f9e07d1cfd -d 44d7a43c481a: rebasing 426048:c7f9e07d1cfd "Bug 1406668 - Make build/moz.configure/*.configure compliant to the pep8 format + add to the list of directories to check r=glandium"
merging build/moz.configure/toolchain.configure
merging tools/lint/flake8.yml
warning: conflicts while merging build/moz.configure/toolchain.configure! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Comment hidden (mozreview-request)

Comment 10

2 years ago
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b526011049ee
Make build/moz.configure/*.configure compliant to the pep8 format + add to the list of directories to check r=glandium
Comment hidden (mozreview-request)
Assignee

Comment 13

2 years ago
For some reasons, the flake8 file was missing
Flags: needinfo?(sledru)

Comment 14

2 years ago
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4dc78384cb58
Make build/moz.configure/*.configure compliant to the pep8 format + add to the list of directories to check r=glandium
Backed out for flake8 linting failures:

https://treeherder.mozilla.org/logviewer.html#?job_id=136506091&repo=autoland

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=4dc78384cb58c67de770ef207bbd700e7a982960&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=136506091&repo=autoland

[task 2017-10-12T13:07:16.454Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/build/moz.configure/java.configure:64:100 | line too long (114 > 99 characters) (E501)
[task 2017-10-12T13:07:16.454Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/build/moz.configure/old.configure:125:32 | SyntaxError: invalid syntax (E999)
[task 2017-10-12T13:07:16.454Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/build/moz.configure/toolchain.configure:467:100 | line too long (109 > 99 characters) (E501)
[task 2017-10-12T13:07:16.454Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/build/moz.configure/toolchain.configure:517:100 | line too long (158 > 99 characters) (E501)
[task 2017-10-12T13:07:16.454Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/build/moz.configure/toolchain.configure:1283:1 | expected 2 blank lines, found 1 (E302)
Flags: needinfo?(sledru)
Comment hidden (mozreview-request)

Comment 18

2 years ago
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d14dd0e5c41a
Make build/moz.configure/*.configure compliant to the pep8 format + add to the list of directories to check r=glandium
Assignee

Updated

2 years ago
Flags: needinfo?(sledru)
https://hg.mozilla.org/mozilla-central/rev/d14dd0e5c41a
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58

Updated

a year ago
Product: Core → Firefox Build System
Blocks: 1478338
You need to log in before you can comment on or make changes to this bug.