1478419 - symbols fail to parse with mach talos-test --geckoProfile

Status: RESOLVED FIXED

(Testing :: Talos, defect)

Description

[Aria Beingessner [:Gankra]]

Attachment: talos-log.txt

on windows, using a version of central from yesterday, this is preventing me from properly profiling talos

mach buildsymbols succeeded fine, produced pdb/sym files that seems to contain some kind of coherent payload. mstange seemed to think the format of the output may have changed?

example method:

FUNC m 44d2 4e 0 mozilla::interceptor::FuncHook<mozilla::interceptor::WindowsDllInterceptor<mozilla::interceptor::VMSharingPolicyShared<mozilla::interceptor::MMPolicyInProcess,128> >,long (*)(wchar_t *,unsigned long *,_UNICODE_STRING *,void * *)>::SetDetour(mozilla::interceptor::WindowsDllInterceptor<mozilla::interceptor::VMSharingPolicyShared<mozilla::interceptor::MMPolicyInProcess,128> > &,char const *,long (*)(wchar_t *,unsigned long *,_UNICODE_STRING *,void * *))

Comment 2

[Markus Stange [:mstange]]

This is a line with an "m" in it. This has been added by a recent change to the sym format: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/773418

We need to update our parsing for that change.

Comment 3

[Matt Woodrow (:mattwoodrow)]

I got working symbols with this patch: https://hg.mozilla.org/try/rev/58532f7d754b9febb11aaa045360a387cdd7c2b4

Comment 4

[Markus Stange [:mstange]]

Nice, thanks! That made me realize that we have this bug in two places; both in Talos and in the geckoProfiler WebExtension API. Let's do the Talos part in this bug and the WebExtension part in bug 1483616.

Comment 5

[Markus Stange [:mstange]]

Matt, would you mind attaching your patch here so that I can r+ it?

Comment 6

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1478419 - Handle optional 'm' symbol in breakpad symbols. r?mstange

MozReview-Commit-ID: JwQJY75tQ4s

Comment 7

[Markus Stange [:mstange]]

Comment on attachment 9007954 [details]
Bug 1478419 - Handle optional 'm' symbol in breakpad symbols. r?mstange

Markus Stange [:mstange] has approved the revision.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d2338b4daaad
Handle optional 'm' symbol in breakpad symbols. r=mstange

Comment 9

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/d2338b4daaad