1478460 - sccache doesn't take into account -fsanitize-blacklist= file argument

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Tom Ritter [:tjr]]

As far as I can tell, if I pass -fsanitize-blacklist=path/file.txt into a build; and then change that file in a commit; it will not invalidate the cache.  It should (as this affects the compilation).

The correct fix is to have sccache take into account the file hash of any file arguments provided to it (I'm sure there are more than just fsanitize-blacklist).  

The short term fix is just to disable SCCACHE; although I'm a little confused how to do that via environment variables in try. There's USE_SCCACHE and SCCACHE_DISABLE...

Ted, do you have any thoughts on this?

Comment 1

[(not currently active) Ted Mielczarek]

It wouldn't be hard to add this. sccache doesn't have any magic, it just has lists of commandline arguments and how to handle them.

Disabling sccache is actually automatic nowadays, you just remove the sccache toolchain dependency from the build task definition (bug 1388573).

Comment 2

[(Away)]

I was about to file this and got sent here by the duplicate-detector; I lost several try-pushes to this issue this week.

Chris, any chance this is like a one-liner that you could easily add to sccache?

Comment 3

[Chris Manchester (limited bugmail, email directly)]

Sure, I'll take this.

Comment 4

[Chris Manchester (limited bugmail, email directly)]

PR is up at https://github.com/mozilla/sccache/pull/664

Comment 5

[(Away)]

Whoa, it really was a one-liner. \o/ Thanks!

Comment 6

[Chris Manchester (limited bugmail, email directly)]

This was merged, will be available the next time we pull a new rev into the tree.