Open Bug 1465549 Opened 2 years ago Updated 5 months ago

Create a Linux-Based CFI Build

Categories

(Firefox Build System :: General, enhancement, P3)

enhancement

Tracking

(Not tracked)

People

(Reporter: tjr, Unassigned)

References

(Depends on 3 open bugs, Blocks 1 open bug)

Details

Attachments

(1 obsolete file)

This bug tracks getting Control Flow Integrity running on Linux.
Depends on: 1465825
Depends on: 1465967
Depends on: 1466242
Comment on attachment 8982050 [details]
Bug 1465549 Enable -fsanitize=cfi-icall on the LTO build

https://reviewboard.mozilla.org/r/248094/#review255558


Code analysis found 1 defect in this patch:
 - 1 defect found by mozlint

You can run this analysis locally with:
 - `./mach lint path/to/file` (JS/Python)


If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx


::: build/moz.configure/toolchain.configure:1328
(Diff revision 3)
> +            ldflags.append("-fsanitize=cfi-icall")
> +            ldflags.append("-fno-sanitize-trap=cfi")
> +            ldflags.append("-fsanitize-recover=cfi")
> +
> +
>      # gcc and other compilers

Error: Too many blank lines (2) [flake8: E303]
Depends on: cfi-icall
No longer depends on: 1465825
No longer depends on: 1465967
Depends on: 1477722
Depends on: cfi-vcall
No longer depends on: 1459314
Depends on: 1478460
Depends on: 1481638
Attachment #8982050 - Attachment is obsolete: true
Version: Version 3 → 3 Branch
Assignee: tom → nobody
Priority: -- → P3
Version: 3 Branch → Trunk
You need to log in before you can comment on or make changes to this bug.