Closed Bug 1478516 Opened 3 years ago Closed 3 years ago

Disable "$x could not be verified for use in $y" warning in Add-On Manager

Categories

(Thunderbird :: Add-Ons: General, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
Thunderbird 63.0

People

(Reporter: darktrojan, Assigned: darktrojan)

Details

Attachments

(1 file)

Attached patch unsigned-1.diffSplinter Review
Since we don't do signed add-ons, there should be no warning about unsigned add-ons. If we tell the UI that all add-ons are signed, there's no warning.
Attachment #8995019 - Flags: review?(jorgk)
Comment on attachment 8995019 [details] [diff] [review]
unsigned-1.diff

Works for me, thanks. A couple of nits:
- the TB sheriff really appreciates a complete commit message incl. the bug number ;-)
- coding style is:
  function xx(args) or function (). Sadly it's already a mess in that file, so one
  bad one more doesn't matter. Or maybe I'll add the space myself now.
Attachment #8995019 - Flags: review?(jorgk) → review+
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/d682edf1fc66
Disable Add-On Manager warning about unsigned add-ons. r=jorgk DONTBUILD
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
I didn't add the space after all after counting what was already in the file. I realised that you attached the patch while submitting the bug, so there was no bug number yet to put into the commit message. All good :-)
Target Milestone: --- → Thunderbird 63.0
Yes! Much better, thanks for fixing this.
Status: RESOLVED → VERIFIED
Component: General → Add-Ons: General
You need to log in before you can comment on or make changes to this bug.