1478519 - Add support for CSS prefers-reduced-motion media feature for Gtk

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P3)

Description

[Hiroyuki Ikezoe (:hiro)]

I just noticed that there is a setting named 'gtk-enable-animation' which is corresponding to prefers-reduced-motion.

On GTK, I guess we can write an automation test to check the value is changed when the system setting is changed.

https://developer.gnome.org/gtk3/stable/GtkSettings.html#GtkSettings--gtk-enable-animations

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Forgot to setting Priority. :)

Comment 2

[Hiroyuki Ikezoe (:hiro)]

Attachment: Mochitest and relevant stuff needed for the test

This is the test what I am trying to write.

I think the mechanism introduced in the patch should work but doesn't work for now unfortunately since there are a couple of bugs I found (bug 1478576 and bug 1478212).  (I guess there are still other bugs).

Anyway, I didn't add any test cases in bug 1476212 (a prefers-reduced-motion bug for Windows), so I will go without the test case here.

Comment 3

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1478519 - Introduce a utility method calling some notification method for nsIPresShell.

Review commit: https://reviewboard.mozilla.org/r/259596/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/259596/

Comment 4

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1478519 - Support prefers-reduced-motion for GTK.

The corresponding setting for prefers-reduced-motion on GTK is
gtk-enable-animations I belive.

https://developer.gnome.org/gtk3/stable/GtkSettings.html#GtkSettings--gtk-enable-animations

Review commit: https://reviewboard.mozilla.org/r/259598/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/259598/

Comment 5

[Karl Tomlinson (:karlt)]

Comment on attachment 8995123 [details]
Bug 1478519 - Introduce a utility method calling some notification method for nsIPresShell.

https://reviewboard.mozilla.org/r/259596/#review266880

Given all methods here have the same signature, I expect a pointer to member
function parameter would be simpler.  If there is reason to prefer lambdas,
then feel free to ask :jimm for review.  (I'm just doing GTK-specific bits.)

::: widget/nsBaseWidget.h:323
(Diff revision 1)
>                               const mozilla::Maybe<ZoomConstraints>& aConstraints) override;
>  
>    bool AsyncPanZoomEnabled() const override;
>  
> +  template<typename NotificationFunc>
> +  void NotifyToPresShell(NotificationFunc&& aNotificationFunc);

NotifyPresShell() would be more natural in English.

Comment 6

[Karl Tomlinson (:karlt)]

Comment on attachment 8995124 [details]
Bug 1478519 - Support prefers-reduced-motion for GTK.

https://reviewboard.mozilla.org/r/259598/#review266882

::: widget/gtk/nsLookAndFeel.cpp:673
(Diff revision 1)
> +    case eIntID_PrefersReducedMotion:
> +    {
> +      GtkSettings *settings;

4 spaces in this file.

Opening brace after ':'

https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style#Control_Structures

Comment 7

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8995123 [details]
Bug 1478519 - Introduce a utility method calling some notification method for nsIPresShell.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/259596/diff/1-2/

Comment 8

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8995124 [details]
Bug 1478519 - Support prefers-reduced-motion for GTK.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/259598/diff/1-2/

Comment 9

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8995124 [details]
Bug 1478519 - Support prefers-reduced-motion for GTK.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/259598/diff/2-3/

Comment 10

[Karl Tomlinson (:karlt)]

Comment on attachment 8995123 [details]
Bug 1478519 - Introduce a utility method calling some notification method for nsIPresShell.

https://reviewboard.mozilla.org/r/259596/#review267174

Comment 11

[Hiroyuki Ikezoe (:hiro)]

Thank you!

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f0e52163b195
Introduce a utility method calling some notification method for nsIPresShell. r=karlt
https://hg.mozilla.org/integration/autoland/rev/1b66e350419f
Support prefers-reduced-motion for GTK. r=karlt

Comment 13

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/f0e52163b195
https://hg.mozilla.org/mozilla-central/rev/1b66e350419f