1478557 - Re-enable cargo commands that don't have outputs

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Chris Manchester (limited bugmail, email directly)]

The patch in bug 1468547 tries to index cargo commands by their outputs, but this isn't valid for build scripts that don't have outputs, so they were inadvertently turned off by that patch.

The command string is probably a better thing to use as a key...

Comment 1

[Chris Manchester (limited bugmail, email directly)]

Attachment: Bug 1478557 - Use the command string rather than output list as a key for cargo commands in the tup backend.

Review commit: https://reviewboard.mozilla.org/r/259536/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/259536/

Comment 2

[Michael Shal [:mshal]]

Comment on attachment 8995052 [details]
Bug 1478557 - Use the command string rather than output list as a key for cargo commands in the tup backend.

https://reviewboard.mozilla.org/r/259536/#review266738

This looks fine - is there a reason we need to run build scripts that don't actually produce anything?

Comment 3

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8995052 [details]
Bug 1478557 - Use the command string rather than output list as a key for cargo commands in the tup backend.

https://reviewboard.mozilla.org/r/259536/#review266738

At least one I found wants to be able to fail the build under certain circumstances (see bug 1478561). Others are producing output that's usually parsed by cargo but I think we're ignoring, we may need to re-visit this.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0f0af7e8440b
Use the command string rather than output list as a key for cargo commands in the tup backend. r=mshal

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/0f0af7e8440b