Closed Bug 1478557 Opened Last year Closed Last year

Re-enable cargo commands that don't have outputs

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set

Tracking

(firefox63 fixed)

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: chmanchester, Assigned: chmanchester)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

The patch in bug 1468547 tries to index cargo commands by their outputs, but this isn't valid for build scripts that don't have outputs, so they were inadvertently turned off by that patch.

The command string is probably a better thing to use as a key...
Comment on attachment 8995052 [details]
Bug 1478557 - Use the command string rather than output list as a key for cargo commands in the tup backend.

https://reviewboard.mozilla.org/r/259536/#review266738

This looks fine - is there a reason we need to run build scripts that don't actually produce anything?
Attachment #8995052 - Flags: review?(mshal) → review+
Comment on attachment 8995052 [details]
Bug 1478557 - Use the command string rather than output list as a key for cargo commands in the tup backend.

https://reviewboard.mozilla.org/r/259536/#review266738

At least one I found wants to be able to fail the build under certain circumstances (see bug 1478561). Others are producing output that's usually parsed by cargo but I think we're ignoring, we may need to re-visit this.
Pushed by cmanchester@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0f0af7e8440b
Use the command string rather than output list as a key for cargo commands in the tup backend. r=mshal
https://hg.mozilla.org/mozilla-central/rev/0f0af7e8440b
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.