1478661 - Replace IsComposited() with explicit alpha visual state

Status: VERIFIED FIXED

(Core :: Widget: Gtk, defect)

Description

[Martin Stránský [:stransky] (ni? me)]

+++ This bug was initially created as a clone of Bug #1478454 +++

The IsComposited() routine does not work reliable for WebRender backend with GLX visual recently. 

Also we don't have covered a situation when WebRender is enabled and we're on non-compositing WM (I don't know if such config is even possible) - let's throw warning at least.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1478661 - Replace IsComposited() with explicit alpha visual state,

IsComposited() does not reflect Visual selected by GLContextGLX::FindVisual()
which is used by WebRender which leads to shaped window rendering with WebRender.

IsComposited() is replaced by mHasAlphaVisual variable which is explicitly
set when we have an alpha visual and we don't need to use shape X11 extension.

Review commit: https://reviewboard.mozilla.org/r/259682/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/259682/

Comment 2

[Jan Horak [:jhorak]]

Comment on attachment 8995191 [details]
Bug 1478661 - Replace IsComposited() with explicit alpha visual state,

https://reviewboard.mozilla.org/r/259682/#review266676

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/abc5e13443a9
Replace IsComposited() with explicit alpha visual state, r=jhorak

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/abc5e13443a9

Comment 5

[Vlad Jiman]

Verified using Nightly 63.0a1 running on Ubuntu 16.04 LTS, the issue was not reproduced on this version. The bug was reproducing on FF 61 running on the same OS.