1357487 - Turn on OOP extensions by default on Linux

Status: VERIFIED FIXED

(WebExtensions :: General, defect, P2)

Comment 1

[:shell escalante]

waiting if jim is getting to popover stuff

Comment 2

[Andy McKay]

Marking as quantum flow p1 because this is about the ability to run webextensions in a seperate process.

Comment 3

[Andy McKay]

I went through the Quantum Flow release criteria and I don't believe Linux is a blocker for that. So taking off the :p1 designation.

Comment 4

[Darkspirit]

Nightly 56 x64 20170706100310 @ Debian Testing (Linux 4.9.0-3-amd64, Radeon RX480)
extensions.webextensions.remote;true works now (I have stylo enabled), but panels have fat black (webrender:red) borders, which is okay for testing
dom.ipc.processCount.extension;2 does not work, no addons are loaded then, I will wait patiently

Comment 6

[Darkspirit]

There is a problem with OOP Webextensions inside locationbar if the otherwise perfectly working GPU Process is enabled (for example for having some more stability while testing WebRender).
This might not be a blocker for this bug because the GPU Process is currently disabled by default on Linux.

Comment 10

[Kris Maglione [:kmag]]

Attachment: Bug 1357487: Enable OOP extensions by default on all platforms.

Review commit: https://reviewboard.mozilla.org/r/259428/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/259428/

Comment 11

[Andrew Swan [:aswan]]

Comment on attachment 8994917 [details]
Bug 1357487: Enable OOP extensions by default on all platforms.

https://reviewboard.mozilla.org/r/259428/#review266550

hooray!

Comment 12

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e5423d29aaf0b711e02b68b7340a2297dd6bfe16
Bug 1357487: Enable OOP extensions by default on all platforms. r=aswan

Comment 13

[Stefan Hindli [:stefan_hindli]]

Backed out changeset e5423d29aaf0 (Bug 1357487) for reftest failures in file:///Z:/task_1532567375/build/tests/reftest/tests/layout/reftests/css-blending/blend-difference-stacking.html on a CLOSED TREE

Failure: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-classifiedState=unclassified&fromchange=4e08eb5f94e73e34f331f8dce08f77e9953d525a&selectedJob=190152821
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=190152821&repo=mozilla-inbound&lineNumber=38618

01:37:09    ERROR -  REFTEST TEST-UNEXPECTED-FAIL | file:///Z:/task_1532567375/build/tests/reftest/tests/layout/reftests/css-blending/blend-difference-stacking.html == file:///Z:/task_1532567375/build/tests/reftest/tests/layout/reftests/css-blending/blend-difference-stacking-ref.html | image comparison, max difference: 221, number of differing pixels: 2

Comment 14

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/95039d4a54ce
Backed out changeset e5423d29aaf0 for reftest failures in file:///Z:/task_1532567375/build/tests/reftest/tests/layout/reftests/css-blending/blend-difference-stacking.html on a CLOSED TREE

Comment 15

[Stefan Hindli [:stefan_hindli]]

Sorry,
This is the correct failure for which this bug was backed out - https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&fromchange=4e08eb5f94e73e34f331f8dce08f77e9953d525a&selectedJob=190146187

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=190146187&repo=mozilla-inbound&lineNumber=2200


17:41:59     INFO - TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/browser_ext_browserAction_popup_preload.js | Test timed out - 
17:41:59     INFO - Not taking screenshot here: see the one that was previously logged
17:41:59     INFO - TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/browser_ext_browserAction_popup_preload.js | no tasks awaiting on messages - Got ["tabTitle"], expected []
17:41:59     INFO - Stack trace:
17:41:59     INFO - chrome://mochikit/content/browser-test.js:test_is:1305
17:41:59     INFO - chrome://mochikit/content/tests/SimpleTest/ExtensionTestUtils.js:ExtensionTestUtils.loadExtension/<:31
17:41:59     INFO - chrome://mochikit/content/browser-test.js:nextTest:705
17:41:59     INFO - chrome://mochikit/content/browser-test.js:timeoutFn:1200
17:41:59     INFO - setTimeout handler*chrome://mochikit/content/browser-test.js:Tester_execTest:1162
17:41:59     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:996
17:41:59     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:795
17:41:59     INFO - Not taking screenshot here: see the one that was previously logged
17:41:59     INFO - TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/browser_ext_browserAction_popup_preload.js | Extension left running at test shutdown - 
17:41:59     INFO - Stack trace:
17:41:59     INFO - chrome://mochikit/content/tests/SimpleTest/ExtensionTestUtils.js:ExtensionTestUtils.loadExtension/<:109
17:41:59     INFO - chrome://mochikit/content/browser-test.js:nextTest:705
17:41:59     INFO - chrome://mochikit/content/browser-test.js:timeoutFn:1200
17:41:59     INFO - setTimeout handler*chrome://mochikit/content/browser-test.js:Tester_execTest:1162
17:41:59     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:996
17:41:59     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:795
17:41:59     INFO - GECKO(1969) | MEMORY STAT | vsize 4559MB | residentFast 514MB | heapAllocated 116MB
17:41:59     INFO - TEST-OK | browser/components/extensions/test/browser/browser_ext_browserAction_popup_preload.js | took 45073ms
17:41:59     INFO - checking window state
17:41:59     INFO - Not taking screenshot here: see the one that was previously logged
17:41:59     INFO - TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/browser_ext_browserAction_popup_preload.js | Found a browser window after previous test timed out -

Comment 16

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ef1550969466fbe9049ee922735f020af82f66d6
Bug 1357487: Enable OOP extensions by default on all platforms. r=aswan

Comment 17

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/ef1550969466

Comment 18

[Pascal Chevrel:pascalc]

We mentioned that change in 61 release notes for macOS, therefore I'll add a note in 63 nightly notes with the same wording:

WebExtensions now run in their own process on Linux

Comment 19

[Bogdan Tara[:bogdan_tara | bogdant]]

Backed out changeset ef1550969466 (Bug 1357487) caused perf regressions & author didn't justified them.

Push with issues: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=ef1550969466fbe9049ee922735f020af82f66d6

Backout link: https://hg.mozilla.org/integration/mozilla-inbound/rev/ed6567a175dd6a9b9de58b8867f03db7a17ee330

Comment 20

[Pascal Chevrel:pascalc]

Note about this feature disabled from nightly 63 release notes following the backout.

Comment 21

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cb97b513e80eacbf60518002acd95f1591023bc7
Bug 1357487: Enable OOP extensions by default on all platforms. r=aswan

Comment 22

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/cb97b513e80e

Comment 23

[rugk]

BTW enabling extensions.webextensions.remote also disabled Firefox' JSON viewer on the manifest.json. I doubt this is intended.

See bug 1481012 for a related issue/problem with the JSON viewer for WebExtensions.

Comment 24

[Vlad Jiman]

Verified using Ubuntu 18.04 and FF Nightly running on latest build as of (04/08/2018). As the feature has also been validated previously, will be closing out this bug as well.