Closed Bug 1357487 Opened 3 years ago Closed 2 years ago

Turn on OOP extensions by default on Linux

Categories

(WebExtensions :: General, defect, P2)

defect

Tracking

(relnote-firefox 63+, firefox63+ fixed)

VERIFIED FIXED
mozilla63
Tracking Status
relnote-firefox --- 63+
firefox63 + fixed
Blocking Flags:
webextensions ?

People

(Reporter: kmag, Assigned: kmag)

References

(Depends on 1 open bug, Blocks 3 open bugs, Regressed 1 open bug)

Details

(Keywords: perf, Whiteboard: triaged[qf:p3])

Attachments

(1 file)

No description provided.
webextensions: --- → ?
waiting if jim is getting to popover stuff
Priority: -- → P2
Whiteboard: triaged
Marking as quantum flow p1 because this is about the ability to run webextensions in a seperate process.
Whiteboard: triaged → triaged[qf:p1]
I went through the Quantum Flow release criteria and I don't believe Linux is a blocker for that. So taking off the :p1 designation.
Whiteboard: triaged[qf:p1] → triaged[qf]
Whiteboard: triaged[qf] → triaged[qf:p3]
Nightly 56 x64 20170706100310 @ Debian Testing (Linux 4.9.0-3-amd64, Radeon RX480)
extensions.webextensions.remote;true works now (I have stylo enabled), but panels have fat black (webrender:red) borders, which is okay for testing
dom.ipc.processCount.extension;2 does not work, no addons are loaded then, I will wait patiently
Depends on: 1381810
Duplicate of this bug: 1381810
Depends on: 1406533
There is a problem with OOP Webextensions inside locationbar if the otherwise perfectly working GPU Process is enabled (for example for having some more stability while testing WebRender).
This might not be a blocker for this bug because the GPU Process is currently disabled by default on Linux.
See Also: → 1406230
Keywords: perf
Depends on: 1444595
No longer depends on: 1444595
Duplicate of this bug: 1457477
Duplicate of this bug: 1462388
Product: Toolkit → WebExtensions
Duplicate of this bug: 1477454
Comment on attachment 8994917 [details]
Bug 1357487: Enable OOP extensions by default on all platforms.

https://reviewboard.mozilla.org/r/259428/#review266550

hooray!
Attachment #8994917 - Flags: review?(aswan) → review+
Backed out changeset e5423d29aaf0 (Bug 1357487) for reftest failures in file:///Z:/task_1532567375/build/tests/reftest/tests/layout/reftests/css-blending/blend-difference-stacking.html on a CLOSED TREE

Failure: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-classifiedState=unclassified&fromchange=4e08eb5f94e73e34f331f8dce08f77e9953d525a&selectedJob=190152821
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=190152821&repo=mozilla-inbound&lineNumber=38618

01:37:09    ERROR -  REFTEST TEST-UNEXPECTED-FAIL | file:///Z:/task_1532567375/build/tests/reftest/tests/layout/reftests/css-blending/blend-difference-stacking.html == file:///Z:/task_1532567375/build/tests/reftest/tests/layout/reftests/css-blending/blend-difference-stacking-ref.html | image comparison, max difference: 221, number of differing pixels: 2
Flags: needinfo?(kmaglione+bmo)
Backout by shindli@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/95039d4a54ce
Backed out changeset e5423d29aaf0 for reftest failures in file:///Z:/task_1532567375/build/tests/reftest/tests/layout/reftests/css-blending/blend-difference-stacking.html on a CLOSED TREE
Sorry,
This is the correct failure for which this bug was backed out - https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&fromchange=4e08eb5f94e73e34f331f8dce08f77e9953d525a&selectedJob=190146187

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=190146187&repo=mozilla-inbound&lineNumber=2200


17:41:59     INFO - TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/browser_ext_browserAction_popup_preload.js | Test timed out - 
17:41:59     INFO - Not taking screenshot here: see the one that was previously logged
17:41:59     INFO - TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/browser_ext_browserAction_popup_preload.js | no tasks awaiting on messages - Got ["tabTitle"], expected []
17:41:59     INFO - Stack trace:
17:41:59     INFO - chrome://mochikit/content/browser-test.js:test_is:1305
17:41:59     INFO - chrome://mochikit/content/tests/SimpleTest/ExtensionTestUtils.js:ExtensionTestUtils.loadExtension/<:31
17:41:59     INFO - chrome://mochikit/content/browser-test.js:nextTest:705
17:41:59     INFO - chrome://mochikit/content/browser-test.js:timeoutFn:1200
17:41:59     INFO - setTimeout handler*chrome://mochikit/content/browser-test.js:Tester_execTest:1162
17:41:59     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:996
17:41:59     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:795
17:41:59     INFO - Not taking screenshot here: see the one that was previously logged
17:41:59     INFO - TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/browser_ext_browserAction_popup_preload.js | Extension left running at test shutdown - 
17:41:59     INFO - Stack trace:
17:41:59     INFO - chrome://mochikit/content/tests/SimpleTest/ExtensionTestUtils.js:ExtensionTestUtils.loadExtension/<:109
17:41:59     INFO - chrome://mochikit/content/browser-test.js:nextTest:705
17:41:59     INFO - chrome://mochikit/content/browser-test.js:timeoutFn:1200
17:41:59     INFO - setTimeout handler*chrome://mochikit/content/browser-test.js:Tester_execTest:1162
17:41:59     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:996
17:41:59     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:795
17:41:59     INFO - GECKO(1969) | MEMORY STAT | vsize 4559MB | residentFast 514MB | heapAllocated 116MB
17:41:59     INFO - TEST-OK | browser/components/extensions/test/browser/browser_ext_browserAction_popup_preload.js | took 45073ms
17:41:59     INFO - checking window state
17:41:59     INFO - Not taking screenshot here: see the one that was previously logged
17:41:59     INFO - TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/browser_ext_browserAction_popup_preload.js | Found a browser window after previous test timed out -
Depends on: 1478661
https://hg.mozilla.org/mozilla-central/rev/ef1550969466
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Depends on: 1478914
See Also: → 1479181
Depends on: 1479353
We mentioned that change in 61 release notes for macOS, therefore I'll add a note in 63 nightly notes with the same wording:

WebExtensions now run in their own process on Linux
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Note about this feature disabled from nightly 63 release notes following the backout.
https://hg.mozilla.org/mozilla-central/rev/cb97b513e80e
Status: REOPENED → RESOLVED
Closed: 2 years ago2 years ago
Resolution: --- → FIXED
Flags: needinfo?(kmaglione+bmo)
BTW enabling extensions.webextensions.remote also disabled Firefox' JSON viewer on the manifest.json. I doubt this is intended.

See bug 1481012 for a related issue/problem with the JSON viewer for WebExtensions.
Verified using Ubuntu 18.04 and FF Nightly running on latest build as of (04/08/2018). As the feature has also been validated previously, will be closing out this bug as well.
Status: RESOLVED → VERIFIED
Blocks: 1512818
Regressions: 1560835
You need to log in before you can comment on or make changes to this bug.