Closed Bug 1479008 Opened Last year Closed Last year

Install related dictionaries when a new langpack is installed

Categories

(Firefox :: Preferences, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 64
Tracking Status
firefox64 --- fixed

People

(Reporter: mstriemer, Assigned: mstriemer)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

When a user has a certain locale set for the langpack but they don't have the dictionary we should make it easier for them to get the dictionary.

This could be done by installing a dictionary when they install the langpack, or giving a one-click option near check spelling that will install a dictionary, or whatever else you can come up with that's a good idea.
Depends on: 1480874
Assignee: nobody → mstriemer
Priority: P3 → P2
The plan is to install the related dictionaries after the language pack is installed. Postponing any additional UI for now.
See Also: → 1493705
Summary: Improve installation of dictionaries for the active locale → Install related dictionaries when a new langpack is installed
The ideal case for the dictionaries JSON file is to pull it from remote settings. I don't seem to have VPN access to look at the data right now so this patch has the local file. I think we can roll with this for now but once I get access I'll look at filing a follow up or updating this patch.
Pushed by mstriemer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/77d3179f96db
Install related dictionaries after a langpack is installed r=leplatrem,aswan
Backed out changeset 77d3179f96db (Bug 1479008) for browser_browser_languages_subdialog.js failures

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=77d3179f96db09f41d591b62d341ba53604bc24c

Backout link: https://hg.mozilla.org/integration/autoland/rev/26c0053b13cb7ea1cce71210709fc30472f68671

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=206387910&repo=autoland&lineNumber=1060

08:33:47     INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_browser_languages_subdialog.js | Polish is now installed - 
08:33:47     INFO - Console message: 1539876821669	addons.xpi	WARN	Download of chrome://mochitests/content/browser/browser/components/preferences/in-content/tests/addons/pl-dictionary.xpi failed: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIZipReader.open]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: resource://gre/modules/addons/XPIInstall.jsm :: XPIPackage :: line 328"  data: no] Stack trace: XPIPackage()@resource://gre/modules/addons/XPIInstall.jsm:328
08:33:47     INFO - get()@resource://gre/modules/addons/XPIInstall.jsm:228
08:33:47     INFO - loadManifest()@resource://gre/modules/addons/XPIInstall.jsm:1557
08:33:47     INFO - Console message: [JavaScript Error: "Install failed: onDownloadFailed" {file: "resource://gre/modules/addons/XPIInstall.jsm" line: 1945}]
08:33:47     INFO - _callInstallListeners@resource://gre/modules/addons/XPIInstall.jsm:1945:34
08:33:47     INFO - downloadFailed@resource://gre/modules/addons/XPIInstall.jsm:2386:5
08:33:47     INFO - onStopRequest/<@resource://gre/modules/addons/XPIInstall.jsm:2359:11
08:33:47     INFO - 
08:33:47     INFO - Buffered messages finished
08:33:47     INFO - TEST-UNEXPECTED-FAIL | browser/components/preferences/in-content/tests/browser_browser_languages_subdialog.js | Uncaught exception - undefined - timed out after 50 tries.
08:33:47     INFO - Leaving test bound testInstallFromAMO
08:33:47     INFO - GECKO(1950) | 1539876826862	addons.xpi-utils	WARN	Add-on langpack-pl@firefox.mozilla.org is not correctly signed.
08:33:47     INFO - Console message: 1539876826862	addons.xpi-utils	WARN	Add-on langpack-pl@firefox.mozilla.org is not correctly signed.
08:33:47     INFO - GECKO(1950) | JavaScript error: , line 0: uncaught exception: undefined
08:33:47     INFO - GECKO(1950) | JavaScript error: , line 0: uncaught exception: undefined
08:33:47     INFO - Console message: [JavaScript Error: "uncaught exception: undefined"]
08:33:47     INFO - Console message: [JavaScript Error: "uncaught exception: undefined"]
08:33:47     INFO - GECKO(1950) | MEMORY STAT vsizeMaxContiguous not supported in this build configuration.
08:33:47     INFO - GECKO(1950) | MEMORY STAT | vsize 4460MB | residentFast 417MB | heapAllocated 160MB
08:33:47     INFO - TEST-OK | browser/components/preferences/in-content/tests/browser_browser_languages_subdialog.js | took 9970ms
08:33:47     INFO - Not taking screenshot here: see the one that was previously logged
08:33:47     INFO - TEST-UNEXPECTED-FAIL | browser/components/preferences/in-content/tests/browser_browser_languages_subdialog.js | Found an unexpected tab at the end of test run: about:preferences#general - 
08:33:47     INFO - checking window state
08:33:48     INFO - GECKO(1950) | Completed ShutdownLeaks collections in process 1957
08:33:48     INFO - GECKO(1950) | Completed ShutdownLeaks collections in process 1956
08:33:48     INFO - GECKO(1950) | Completed ShutdownLeaks collections in process 1954
08:33:48     INFO - GECKO(1950) | Completed ShutdownLeaks collections in process 1959
08:33:48     INFO - GECKO(1950) | Completed ShutdownLeaks collections in process 1958
08:33:48     INFO - GECKO(1950) | Completed ShutdownLeaks collections in process 1960
08:33:48     INFO - GECKO(1950) | Completed ShutdownLeaks collections in process 1955
08:33:49     INFO - GECKO(1950) | Completed ShutdownLeaks collections in process 1950
08:33:49     INFO - TEST-START | Shutdown
Flags: needinfo?(mstriemer)
Pushed by mstriemer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6b1ecbbb8427
Install related dictionaries after a langpack is installed r=leplatrem,aswan
This was missing the test XPI since I didn't upload the patch using `arc`. Should be fixed now.
Flags: needinfo?(mstriemer)
https://hg.mozilla.org/mozilla-central/rev/6b1ecbbb8427
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
You need to log in before you can comment on or make changes to this bug.