Closed Bug 1479312 Opened 2 years ago Closed 2 years ago
Navigation and Web Progress listeners out of browser-child .js
59 bytes, text/x-review-board-request
In addition to the extra base overhead of having these in a frame script rather than the shared JSM global, instantiating these from a frame script means that we have to re-evaluate their scripts in a new global for every frameloader we create, rather than just sharing a single instance of the scripts.
Comment on attachment 8995833 [details] Bug 1479312: Move WebNavigation and WebContent child listeners to JSMs. https://reviewboard.mozilla.org/r/260174/#review267388 uber-nit: commit msg says WebContent instead of WebProgress
Attachment #8995833 - Flags: review?(felipc) → review+
(In reply to :Felipe Gomes (needinfo me!) from comment #2) > uber-nit: commit msg says WebContent instead of WebProgress Yeah, sorry. I noticed that after I pushed, but it didn't seem worth updating for.
https://hg.mozilla.org/integration/mozilla-inbound/rev/d403426d1dcdd7b7cd5b51e62b7b71c5d69631a3 Bug 1479312: Move WebNavigation and WebProgress child listeners to JSMs. r=felipe
Backed out for eslint failure at builds/worker/checkouts/gecko/toolkit/modules/WebProgressChild.jsm Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=8b21457cfcd87dfa47ece25f87af1433d254275e Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=191467663&repo=mozilla-inbound&lineNumber=255 Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/52f62027c5e20813530da250108b3c76b3d2e0bd
:/ This is because of bug 1478305
https://hg.mozilla.org/integration/mozilla-inbound/rev/a68daa762119d5f2f67fdb2c29d2d70bf9ec89c8 Bug 1479312: Move WebNavigation and WebProgress child listeners to JSMs. r=felipe
Backed out for causing a big performance regression on OS X and as request by igoldan. https://hg.mozilla.org/mozilla-central/rev/fe6020e5c9d901a40fa2e7ea2f1ab2a36bf6d856
https://hg.mozilla.org/integration/mozilla-inbound/rev/d9c4348fdca4a4fd96e234aed4886f444834f1d5 Bug 1479312: Move WebNavigation and WebProgress child listeners to JSMs. r=felipe
You need to log in before you can comment on or make changes to this bug.