1479312 - Move WebNavigation and WebProgress listeners out of browser-child.js

Status: RESOLVED FIXED

(Toolkit :: General, enhancement)

Description

[Kris Maglione [:kmag]]

In addition to the extra base overhead of having these in a frame script rather than the shared JSM global, instantiating these from a frame script means that we have to re-evaluate their scripts in a new global for every frameloader we create, rather than just sharing a single instance of the scripts.

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1479312: Move WebNavigation and WebContent child listeners to JSMs.

Review commit: https://reviewboard.mozilla.org/r/260174/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/260174/

Comment 2

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8995833 [details]
Bug 1479312: Move WebNavigation and WebContent child listeners to JSMs.

https://reviewboard.mozilla.org/r/260174/#review267388

uber-nit: commit msg says WebContent instead of WebProgress

Comment 3

[Kris Maglione [:kmag]]

(In reply to :Felipe Gomes (needinfo me!) from comment #2)
> uber-nit: commit msg says WebContent instead of WebProgress

Yeah, sorry. I noticed that after I pushed, but it didn't seem worth updating for.

Comment 4

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d403426d1dcdd7b7cd5b51e62b7b71c5d69631a3
Bug 1479312: Move WebNavigation and WebProgress child listeners to JSMs. r=felipe

Comment 5

[Andreea Pavel [:apavel]]

Backed out for eslint failure at builds/worker/checkouts/gecko/toolkit/modules/WebProgressChild.jsm

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=8b21457cfcd87dfa47ece25f87af1433d254275e

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=191467663&repo=mozilla-inbound&lineNumber=255

Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/52f62027c5e20813530da250108b3c76b3d2e0bd

Comment 6

[Kris Maglione [:kmag]]

:/ This is because of bug 1478305

Comment 7

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a68daa762119d5f2f67fdb2c29d2d70bf9ec89c8
Bug 1479312: Move WebNavigation and WebProgress child listeners to JSMs. r=felipe

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/a68daa762119

Comment 9

[Cosmin Sabou [:CosminS]]

Backed out for causing a big performance regression on OS X and as request by igoldan. 

https://hg.mozilla.org/mozilla-central/rev/fe6020e5c9d901a40fa2e7ea2f1ab2a36bf6d856

Comment 10

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d9c4348fdca4a4fd96e234aed4886f444834f1d5
Bug 1479312: Move WebNavigation and WebProgress child listeners to JSMs. r=felipe

Comment 11

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/d9c4348fdca4