Closed
Bug 1489762
Opened 6 years ago
Closed 6 years ago
WebProgressChild.jsm forces creation of initial about:blank and thus slows down page loading
Categories
(Firefox :: General, defect, P3)
Firefox
General
Tracking
()
RESOLVED
FIXED
People
(Reporter: smaug, Assigned: mconley)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fxperf:p2])
The issue seems to be in _setupObjects. https://perfht.ml/2McpCG1 That profile is from otherwise horrible page bug https://bugzilla.mozilla.org/show_bug.cgi?id=1488164, but the issue is there anyhow.
Assignee | ||
Updated•6 years ago
|
Whiteboard: [fxperf]
Comment 1•6 years ago
|
||
Gijs is looking into this across several bugs, so CC'ing him to see if he has noticed this one yet
Comment 2•6 years ago
|
||
Giving this a p2 for now, assuming this isn't already accounted for in Gijs's todo list.
Whiteboard: [fxperf] → [fxperf:p2]
Updated•6 years ago
|
Priority: -- → P3
Comment hidden (obsolete) |
Comment hidden (obsolete) |
Comment 5•6 years ago
|
||
(In reply to :Gijs (he/him) from comment #3) > At a glance, this seems to have been regressed by bug 1479312. We used to go > to significant lengths in > https://hg.mozilla.org/mozreview/gecko/rev/d9c4348fdca4#l2.58 to avoid > creating the about:blank viewer. > > Kris, the mozreview comments are gone, was there a particular reason you > didn't keep those parts of setupObjects ? Not sure what you mean. As far as I can tell, I didn't change the logic there.
Flags: needinfo?(kmaglione+bmo)
Comment 6•6 years ago
|
||
We definitely do force the creation of a content viewer in content.js: https://searchfox.org/mozilla-central/rev/a0333927deabfe980094a14d0549b589f34cbe49/browser/base/content/content.js#53-54 But that is also definitely not new. That hack is there to preserve the previous behavior after I removed or lazified other code which eagerly touched `content`.
Comment 7•6 years ago
|
||
(In reply to Kris Maglione [:kmag] from comment #5) > (In reply to :Gijs (he/him) from comment #3) > > At a glance, this seems to have been regressed by bug 1479312. We used to go > > to significant lengths in > > https://hg.mozilla.org/mozreview/gecko/rev/d9c4348fdca4#l2.58 to avoid > > creating the about:blank viewer. > > > > Kris, the mozreview comments are gone, was there a particular reason you > > didn't keep those parts of setupObjects ? > > Not sure what you mean. As far as I can tell, I didn't change the logic > there. Yeah, sorry, I clearly misread this. setupJSON had guards (and still does) against this type of thing, but setupObjects doesn't. (In reply to Kris Maglione [:kmag] from comment #6) > We definitely do force the creation of a content viewer in content.js: > > https://searchfox.org/mozilla-central/rev/ > a0333927deabfe980094a14d0549b589f34cbe49/browser/base/content/content.js#53- > 54 Right, I'm aware of bug 1471327. Based on my experience so far fixing tests for bug 1362774, there's going to be a bunch of whack-a-mole to make a change there to avoid the about:blank creation. :-(
No longer blocks: 1479312
status-firefox62:
unaffected → ---
status-firefox63:
affected → ---
status-firefox64:
affected → ---
Keywords: regression
Comment 8•6 years ago
|
||
This code has been deleted.
Assignee: nobody → mconley
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•