Closed Bug 1479350 Opened 3 years ago Closed 3 years ago

"Phabricator Reviews Requested of You" lists bugs which I have reviewed

Categories

(bugzilla.mozilla.org :: Phabricator Integration, enhancement)

Production
enhancement
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: xidorn, Assigned: dkl)

Details

Attachments

(1 file)

45 bytes, text/x-github-pull-request
Details | Review
When I'm filing this bug, "Phabricator Reviews Requested of You" in my dashboard lists bug 1478813 pending for my review. However, I have submitted review of it as shown in bug 1478813 comment 4.

A possible reason of this being wrong is that, the patch in this bug is still pending for review from :ted, who is a blocking reviewer of that change.

Maybe the dashboard incorrectly thinks that anything is pending for review and listed me as a reviewer is pending for my review, which is not true when considering there can be multiple blocking reviewers.
This is due to how the API works currently with Phabricator. The status part of the results is the overall status of the revision, not the review status of each individual review (if more than one). We will need to look at how to change the dashboard to only show the individuals review status and show those in the list if the status is needs review.

The reason the revision you mentioned still displays in your list is because its overall status is still needing review and the other person has not reviewed yet.
Assignee: nobody → dkl
Status: NEW → ASSIGNED
Attached file github pr #695
Merged to master.
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.