1479411 - [remote-dbg-next] Temporarily remove actions and reducers

Status: RESOLVED FIXED

(DevTools :: about:debugging, enhancement)

Description

[Julian Descottes [:jdescottes]]

As discussed in today's meeting, we would like to simplify the current code as much as possible and move carefully as we add other actions.

Also the very first action we should add is probably the possibility to switch between the Connect page and the This-Firefox page, as it will allow use to split the work.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1479411 - Rename RuntimesPane to Sidebar;

Review commit: https://reviewboard.mozilla.org/r/260244/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/260244/

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1479411 - Rename RuntimeItem to SidebarItem;

Review commit: https://reviewboard.mozilla.org/r/260246/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/260246/

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1479411 - Move SidebarItem CSS variables to SidebarItem.css;

Review commit: https://reviewboard.mozilla.org/r/260248/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/260248/

Comment 4

[Julian Descottes [:jdescottes]]

Attachment: Bug 1479411 - Remove all actions and reducers from new about:debugging UI;

Review commit: https://reviewboard.mozilla.org/r/260250/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/260250/

Comment 5

[Daisuke Akatsuka (:daisuke)]

Comment on attachment 8995944 [details]
Bug 1479411 - Rename RuntimesPane to Sidebar;

https://reviewboard.mozilla.org/r/260244/#review267258

Comment 6

[Daisuke Akatsuka (:daisuke)]

Comment on attachment 8995945 [details]
Bug 1479411 - Rename RuntimeItem to SidebarItem;

https://reviewboard.mozilla.org/r/260246/#review267260

Comment 7

[Daisuke Akatsuka (:daisuke)]

Comment on attachment 8995946 [details]
Bug 1479411 - Move SidebarItem CSS variables to SidebarItem.css;

https://reviewboard.mozilla.org/r/260248/#review267262

Comment 8

[Daisuke Akatsuka (:daisuke)]

Comment on attachment 8995947 [details]
Bug 1479411 - Remove all actions and reducers from new about:debugging UI;

https://reviewboard.mozilla.org/r/260250/#review267264

Comment 9

[Belén [:ladybenko]]

Comment on attachment 8995946 [details]
Bug 1479411 - Move SidebarItem CSS variables to SidebarItem.css;

https://reviewboard.mozilla.org/r/260248/#review267268

Thanks! I made a minor comment about where to assign the CSS variables.

::: devtools/client/aboutdebugging-new/src/components/SidebarItem.css:5
(Diff revision 1)
>  /* This Source Code Form is subject to the terms of the Mozilla Public
>   * License, v. 2.0. If a copy of the MPL was not distributed with this
>   * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
>  
> +:root {

Since these aren't treated like global colors anymore, maybe it doesn't make sense to put them under `:root`. How about moving the color declarations to the component itself? Ex:

```
.sidebar-item {
  --sidebar-item-icon-color: var(--grey-30);
  /* ... */
}
```

Comment 10

[Julian Descottes [:jdescottes]]

Comment on attachment 8995946 [details]
Bug 1479411 - Move SidebarItem CSS variables to SidebarItem.css;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/260248/diff/1-2/

Comment 11

[Julian Descottes [:jdescottes]]

Comment on attachment 8995947 [details]
Bug 1479411 - Remove all actions and reducers from new about:debugging UI;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/260250/diff/1-2/

Comment 12

[Julian Descottes [:jdescottes]]

Thank you both for the reviews! I know it's painful to remove code so I'm glad this was done quickly.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/092a7bbeb69b
Rename RuntimesPane to Sidebar;r=daisuke
https://hg.mozilla.org/integration/autoland/rev/33a5b1e66919
Rename RuntimeItem to SidebarItem;r=daisuke
https://hg.mozilla.org/integration/autoland/rev/22dd2b91ec0d
Move SidebarItem CSS variables to SidebarItem.css;r=daisuke,ladybenko
https://hg.mozilla.org/integration/autoland/rev/2c9c2ae0f692
Remove all actions and reducers from new about:debugging UI;r=daisuke

Comment 14

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/092a7bbeb69b
https://hg.mozilla.org/mozilla-central/rev/33a5b1e66919
https://hg.mozilla.org/mozilla-central/rev/22dd2b91ec0d
https://hg.mozilla.org/mozilla-central/rev/2c9c2ae0f692