1479416 - [remote-dbg-next] Add "Connect" Sidebar Item

Status: RESOLVED FIXED

(DevTools :: about:debugging, enhancement, P1)

Description

[Julian Descottes [:jdescottes]]

Goal of this bug is to:
- add a second sidebar item "Connect"
- re-add actions and reducers
- add an action to switch between Connect and This Firefox

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1479416 - WIP add Connect sidebar item

This patch adds a new Connect sidebar item as well as a first action.

First maybe we can discuss about names and concepts.

I refer to the notion of page and selected page at the moment to
describe what will be displayed in the main panel. I was looking
for a generic term that could cover this-firefox, connect and the
device screen. "page" seems fine but I am open to other suggestions

I named the action file (and reducer) "ui", again because I was
aiming for something "global" or "top-level".

Then, what should be in the state. For now I only have the "selectedPage"
which can either be "this-firefox" or "connect" and should be checked
against the 'id' of each sidebar item to know which one is selected.

I kept a hardcoded list of sidebar items for now and I don't have them
in the state. Once we have devices added, I imagine we will build the list
of items by concatenating our 2 hardcoded items and the "device" SidebarItems.
But I could also see a sidebarItems entry in the state, which would contain
everything.

I also have open questions about how to set the default value and how to
dispatch the action properly without connecting all components, but I will
add inline comments.

Comment 2

[Julian Descottes [:jdescottes]]

Comment on attachment 8996233 [details]
Bug 1479416 - WIP add Connect sidebar item

Daisuke, Belén, please have a look at the patch here to add a first action. I added a length commit message and some inline comments in phabricator to give you some context behind my choices and what still feels unclear to me.

Comment 3

[Phabricator Automation]

Comment on attachment 8996233 [details]
Bug 1479416 - WIP add Connect sidebar item

Belén [:ladybenko] has approved the revision.

https://phabricator.services.mozilla.com/D2549

Comment 4

[:Harald Kirschner :digitarald]

Moving major about:debugging ng work into milestone 1, leaving m0 for prior bugfix work.

Comment 5

[Phabricator Automation]

Comment on attachment 8996233 [details]
Bug 1479416 - WIP add Connect sidebar item

Daisuke Akatsuka (:daisuke) has approved the revision.

https://phabricator.services.mozilla.com/D2549

Comment 6

[Phabricator Automation]

Comment on attachment 8996233 [details]
Bug 1479416 - WIP add Connect sidebar item

Belén [:ladybenko] has been removed from the revision.

https://phabricator.services.mozilla.com/D2549

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/42a9a104150d
Add Connect sidebar item to aboutdebugging-new;r=daisuke

Comment 8

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/42a9a104150d

Comment 9

[Daisuke Akatsuka (:daisuke)]

Comment on attachment 8996233 [details]
Bug 1479416 - WIP add Connect sidebar item

Let me clear the feedback flags since this bug was closed.