1479413 - Modify the way AS router handles snippet preview endpoints

Status: RESOLVED FIXED

(Firefox :: New Tab Page, enhancement, P1)

Description

[Andrei Oprea [:andreio]]

ASRouter should not cache the preview endpoint. When using this feature the user would load multiple preview endpoints and explore different snippet variants, if the endpoints are stored it would make useless server requests, it also prevents from "exiting" the preview mode. An endpoint should be active only if it's specified in the newtab page URL.
We should also document the entire process of: whitelisting a host, previewing a snippet, reading errors in the browser toolbox and navigating/using the ASRouter admin.

Comment 1

[Andrei Oprea [:andreio]]

ni giorgos: please let me know if you noticed other issues or there are other things we should update.

Comment 2

[Giorgos Logiotatidis [:giorgos]]

A note to explore adding the "This is a preview" banner on top as we originally discussed.

Comment 3

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4272

Comment 4

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/2e3c294f3a8ddaef5b84304cfaa2801c1d585faa
Fix Bug 1479413 - Remove preview provider and message after it has been displayed

Comment 5

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/f0da6152e262