1481559 - Add search filter, search pref and bug fixes to Activity Stream

Status: VERIFIED FIXED

(Firefox :: New Tab Page, enhancement)

Comment 1

[Ed Lee :Mardak]

Attachment: Bug 1481559 - Add search filter, search pref and bug fixes to Activity Stream

MozReview-Commit-ID: ANMt3NGC8HY

Comment 2

[Phabricator Automation]

Comment on attachment 8998301 [details]
Bug 1481559 - Add search filter, search pref and bug fixes to Activity Stream

Ursula Sarracini (:ursula) has approved the revision.

https://phabricator.services.mozilla.com/D2878

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ce04f86f84f4
Add search filter, search pref and bug fixes to Activity Stream r=ursula

Comment 4

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/ce04f86f84f4

Comment 5

[Natalia Csoregi [:nataliaCs]]

Backed out for browser_preferences_usage.js failures.

backout: https://hg.mozilla.org/mozilla-central/rev/ec96693b39bedee0114f444d3ce37ab0d98d6b06

push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=7d78ffbf4c4a31bfc808e80ea09c6c131328c4ad&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception

failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=192727360&repo=mozilla-central&lineNumber=1845

00:07:44     INFO - TEST-PASS | browser/base/content/test/performance/browser_preferences_usage.js | You need to run this test on a debug build. - 
00:07:44     INFO - Leaving test bound debug_only
00:07:44     INFO - Entering test bound startup
00:07:44     INFO - TEST-PASS | browser/base/content/test/performance/browser_preferences_usage.js | startupRecorder has prefStats - 
00:07:44     INFO - Buffered messages finished
00:07:44     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_preferences_usage.js | Whitelist item network.loadinfo.skip_type_assertion should be accessed at most 650 times. - 652 <= 650 - JS frame :: chrome://mochitests/content/browser/browser/base/content/test/performance/browser_preferences_usage.js :: checkPrefGetters :: line 46
00:07:44     INFO - Stack trace:
00:07:44     INFO - chrome://mochitests/content/browser/browser/base/content/test/performance/browser_preferences_usage.js:checkPrefGetters:46
00:07:44     INFO - chrome://mochitests/content/browser/browser/base/content/test/performance/browser_preferences_usage.js:startup:106
00:07:44     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1103
00:07:44     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1094
00:07:44     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:996
00:07:44     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:795
00:07:44     INFO - TEST-PASS | browser/base/content/test/performance/browser_preferences_usage.js | Whitelist item browser.startup.record should be accessed at least 200 times. - 200 <= 269 - 
00:07:44     INFO - TEST-PASS | browser/base/content/test/performance/browser_preferences_usage.js | Whitelist item browser.startup.record should be accessed at most 350 times. - 269 <= 350 - 
00:07:44     INFO - TEST-PASS | browser/base/content/test/performance/browser_preferences_usage.js | Whitelist item browser.search.log should be accessed at least 100 times. - 100 <= 190 - 
00:07:44     INFO - Not taking screenshot here: see the one that was previously logged
00:07:44     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_preferences_usage.js | Whitelist item browser.search.log should be accessed at most 150 times. - 190 <= 150 - JS frame :: chrome://mochitests/content/browser/browser/base/content/test/performance/browser_preferences_usage.js :: checkPrefGetters :: line 46
00:07:44     INFO - Stack trace:
00:07:44     INFO - chrome://mochitests/content/browser/browser/base/content/test/performance/browser_preferences_usage.js:checkPrefGetters:46
00:07:44     INFO - chrome://mochitests/content/browser/browser/base/content/test/performance/browser_preferences_usage.js:startup:106
00:07:44     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1103
00:07:44     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1094
00:07:44     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:996
00:07:44     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:795
00:07:44     INFO - TEST-PASS | browser/base/content/test/performance/browser_preferences_usage.js | Whitelist item layout.css.prefixes.webkit should be accessed at least 135 times. - 135 <= 168 -

Comment 6

[Andrei Oprea [:andreio]]

Attachment: Increase limit for pref access

https://bugzilla.mozilla.org/show_bug.cgi?id=1481559 Got backed out because of too many pref accesses.
browser.search.log should be accessed at most 150 times 
This is caused by our usage of `Services.search.currentEngine.searchForm` and will be fixed by https://bugzilla.mozilla.org/show_bug.cgi?id=1481447
network.loadinfo.skip_type_assertion should be accessed at most 650 times.
This is caused by adding new resources that we access `data/content/assets/glyph-pocket-save-16.svg`

Comment 7

[Ed Lee :Mardak]

Added andreio's patch with some increased numbers https://treeherder.mozilla.org/#/jobs?repo=try&revision=3238997de8e0299e566c1da9d8e8dc4431d4d921

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f99759ea7410
Add search filter, search pref and bug fixes to Activity Stream r=ursula

Comment 9

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/f99759ea7410

Comment 10

[Iulia Cristescu, QA [:JuliaC] (away, please needinfo? [e-mail])]

Marking this qe-verify + until all the actionable dependencies are verified.

Comment 11

[Cristian Fogel [:cfogel]]

Marking issue as verified and clearing flag since all the manually actionable dependencies have been checked.