Closed Bug 1479665 Opened 6 years ago Closed 6 years ago

Update libsrtp to 2.2.0-pre

Categories

(Core :: WebRTC: Networking, defect, P2)

Product:
Core
Component:
WebRTC: Networking
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla64
Tracking Flags:
Tracking Status
firefox64 --- fixed

People

(Reporter: drno, Assigned: drno)

References

Details

Attachments

(3 files, 2 obsolete files)

Summary: fix srtp updater script
46 bytes, text/x-phabricator-request
bwc
: review+
Details | Review
Bug 1479665: add GCM ciphers to SrtpFlow.
46 bytes, text/x-phabricator-request
bwc
: review+
Details | Review
Bug 1479665: update libsrtp to bb0412ee84ebe3d2916b45b19de72fabb183d9db. r=bwc
46 bytes, text/x-phabricator-request
bwc
: review+
Details | Review 
Update libsrtp to at least revision c111ad29eb903255b560874de02abf1ae99b524c from here https://github.com/cisco/libsrtp

That version allows to use NSS for libsrtp's crypto operations and also to switch to AES GCM.
Rank: 15
Summary: Update libsrtp → Update libsrtp to 2.2.0-pre
Depends on: 1480869
Depends on D2748
Attached file Summary: add GCM ciphers to SrtpFlow (obsolete) — 
Depends on D2749
Comment on attachment 8997611 [details]
Summary: update libsrtp to c111ad29eb903255b560874de02abf1ae99b524c

Byron Campen [:bwc] has approved the revision.

https://phabricator.services.mozilla.com/D2749
Attachment #8997611 - Flags: review+
Comment on attachment 8997610 [details]
Summary: fix srtp updater script

Byron Campen [:bwc] has approved the revision.

https://phabricator.services.mozilla.com/D2748
Attachment #8997610 - Flags: review+
Comment on attachment 8997612 [details]
Summary: add GCM ciphers to SrtpFlow

Byron Campen [:bwc] has approved the revision.

https://phabricator.services.mozilla.com/D2750
Attachment #8997612 - Flags: review+
Attachment #8997612 - Attachment is obsolete: true
Attachment #8997611 - Attachment is obsolete: true
add GCM ciphers to SrtpFlow
Attachment #9008614 - Attachment is obsolete: true
Attachment #9008614 - Attachment description: Bug 1479665: add GCM ciphers to SrtpFlow. r=bwc Depends on D2748 → Bug 1479665: add GCM ciphers to SrtpFlow.
Attachment #9008614 - Attachment is obsolete: false
update libsrtp to bb0412ee84ebe3d2916b45b19de72fabb183d9db
Comment on attachment 9008614 [details]
Bug 1479665: add GCM ciphers to SrtpFlow.

Byron Campen [:bwc] has approved the revision.
Attachment #9008614 - Flags: review+
Comment on attachment 9008615 [details]
Bug 1479665: update libsrtp to bb0412ee84ebe3d2916b45b19de72fabb183d9db. r=bwc

Byron Campen [:bwc] has approved the revision.
Attachment #9008615 - Flags: review+
Pushed by nohlmeier@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c8eec40da8fd
Summary: fix srtp updater script r=bwc
Pushed by nohlmeier@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9293d3493e0c
update libsrtp to bb0412ee84ebe3d2916b45b19de72fabb183d9db. r=bwc
Backed out for build bustages.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed,busted,exception&classifiedState=classified&revision=1a7771d373ff7fbc3e22e1a27a4c5fa8e0eb879f&selectedJob=199165115

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=199165115&repo=autoland&lineNumber=37085

Backout link: https://hg.mozilla.org/integration/autoland/rev/c1933b9ea68db8d335999adb12d306ed246cf3d1

[task 2018-09-13T20:40:25.146Z] 20:40:25     INFO -  /builds/worker/workspace/build/src/binutils/bin/ld: final link failed: bad value
[task 2018-09-13T20:40:25.147Z] 20:40:25     INFO -  clang-6.0: error: linker command failed with exit code 1 (use -v to see invocation)
[task 2018-09-13T20:40:25.147Z] 20:40:25     INFO -  /builds/worker/workspace/build/src/config/rules.mk:704: recipe for target 'libxul.so' failed
[task 2018-09-13T20:40:25.147Z] 20:40:25     INFO -  make[4]: *** [libxul.so] Error 1
[task 2018-09-13T20:40:25.147Z] 20:40:25     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/library'
[task 2018-09-13T20:40:25.147Z] 20:40:25     INFO -  /builds/worker/workspace/build/src/config/recurse.mk:74: recipe for target 'toolkit/library/target' failed
[task 2018-09-13T20:40:25.147Z] 20:40:25     INFO -  make[3]: *** [toolkit/library/target] Error 2
[task 2018-09-13T20:40:25.147Z] 20:40:25     INFO -  make[3]: *** Waiting for unfinished jobs....
[task 2018-09-13T20:40:54.187Z] 20:40:54     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver'
[task 2018-09-13T20:40:54.187Z] 20:40:54     INFO -  force-cargo-program-build
[task 2018-09-13T20:40:54.190Z] 20:40:54     INFO -  env   RUSTC_BOOTSTRAP=1 RUSTC_WRAPPER='/builds/worker/workspace/build/src/sccache2/sccache' CARGO_TARGET_DIR=. RUSTFLAGS='-C opt-level=2 -C debuginfo=2  ' RUSTC=/builds/worker/workspace/build/src/rustc/bin/rustc RUSTDOC=/builds/worker/workspace/build/src/rustc/bin/rustdoc RUSTFMT=/builds/worker/workspace/build/src/rustc/bin/rustfmt CC_i686_unknown_linux_gnu=" /builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/clang/bin/clang -std=gnu99 --target=i686-linux-gnu" CXX_i686_unknown_linux_gnu=" /builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/clang/bin/clang++ --target=i686-linux-gnu" CFLAGS_i686_unknown_linux_gnu="-I/builds/worker/workspace/build/src/obj-firefox/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -DNDEBUG=1 -DTRIMMED=1 -I/builds/worker/workspace/build/src/testing/geckodriver -I/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -DMOZILLA_CLIENT -Qunused-arguments -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -march=pentium-m -msse -msse2 -mfpmath=sse -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fno-strict-aliasing -ffunction-sections -fdata-sections -fno-math-errno -pthread -pipe -g -Xclang -load -Xclang /builds/worker/workspace/build/src/obj-firefox/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O2 -fno-omit-frame-pointer -Qunused-arguments -Wall -Wempty-body -Wignored-qualifiers -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments" CXXFLAGS_i686_unknown_linux_gnu="-I/builds/worker/workspace/build/src/obj-firefox/dist/stl_wrappers -I/builds/worker/workspace/build/src/obj-firefox/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -DNDEBUG=1 -DTRIMMED=1 -I/builds/worker/workspace/build/src/testing/geckodriver -I/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -Qunused-arguments -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Qunused-arguments -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++1z-compat -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -Wno-return-type-c-linkage -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -march=pentium-m -msse -msse2 -mfpmath=sse -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -Xclang -load -Xclang /builds/worker/workspace/build/src/obj-firefox/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O2 -fno-omit-frame-pointer" AR_i686_unknown_linux_gnu="ar"  MOZ_SRC=/builds/worker/workspace/build/src MOZ_DIST=/builds/worker/workspace/build/src/obj-firefox/dist LIBCLANG_PATH="/builds/worker/workspace/build/src/clang/lib" CLANG_PATH="/builds/worker/workspace/build/src/clang/bin/clang" PKG_CONFIG_ALLOW_CROSS=1 RUST_BACKTRACE=full MOZ_TOPOBJDIR=/builds/worker/workspace/build/src/obj-firefox CARGO_INCREMENTAL=0 MOZ_CARGO_WRAP_LDFLAGS="-lpthread -Wl,-z,noexecstack -Wl,-z,text -Wl,-z,relro -Wl,-z,nocopyreloc -Wl,--build-id=sha1 -Wl,-rpath-link,/builds/worker/workspace/build/src/obj-firefox/dist/bin -Wl,-rpath-link,/usr/local/lib" MOZ_CARGO_WRAP_LD=" /builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/clang/bin/clang -std=gnu99 --target=i686-linux-gnu" CARGO_TARGET_I686_UNKNOWN_LINUX_GNU_LINKER=/builds/worker/workspace/build/src/build/cargo-linker /builds/worker/workspace/build/src/rustc/bin/cargo rustc  --release --frozen --manifest-path /builds/worker/workspace/build/src/testing/geckodriver/Cargo.toml -vv --bin geckodriver --target=i686-unknown-linux-gnu
[task 2018-09-13T20:40:54.190Z] 20:40:54     INFO -     Compiling nodrop v0.1.12
[task 2018-09-13T20:40:54.191Z] 20:40:54     INFO -     Compiling cfg-if v0.1.2
[task 2018-09-13T20:40:54.191Z] 20:40:54     INFO -     Compiling libc v0.2.43
[task 2018-09-13T20:40:54.191Z] 20:40:54     INFO -     Compiling byteorder v1.2.1
[task 2018-09-13T20:40:54.191Z] 20:40:54     INFO -     Compiling memoffset v0.2.1
[task 2018-09-13T20:40:54.191Z] 20:40:54     INFO -     Compiling lazy_static v1.0.1
[task 2018-09-13T20:40:54.191Z] 20:40:54     INFO -     Compiling scopeguard v0.3.2
[task 2018-09-13T20:40:54.191Z] 20:40:54     INFO -     Compiling slab v0.4.1
[task 2018-09-13T20:40:54.191Z] 20:40:54     INFO -     Compiling build_const v0.2.0
[task 2018-09-13T20:40:54.192Z] 20:40:54     INFO -     Compiling lazycell v0.6.0
[task 2018-09-13T20:40:54.192Z] 20:40:54     INFO -     Compiling futures v0.1.23
[task 2018-09-13T20:40:54.192Z] 20:40:54     INFO -     Compiling cc v1.0.23
[task 2018-09-13T20:40:54.192Z] 20:40:54     INFO -     Compiling unicode-xid v0.1.0
[task 2018-09-13T20:40:54.192Z] 20:40:54     INFO -     Compiling num-traits v0.2.0
[task 2018-09-13T20:40:54.192Z] 20:40:54     INFO -     Compiling void v1.0.2
[task 2018-09-13T20:40:54.192Z] 20:40:54     INFO -     Compiling fnv v1.0.5
[task 2018-09-13T20:40:54.192Z] 20:40:54     INFO -       Running `/builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/rustc/bin/rustc --crate-name nodrop third_party/rust/nodrop/src/lib.rs --crate-type lib --emit=dep-info,link -C opt-level=2 -C panic=abort -C codegen-units=1 -C metadata=c796d0e76d506e0d -C extra-filename=-c796d0e76d506e0d --out-dir /builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./i686-unknown-linux-gnu/release/deps --target i686-unknown-linux-gnu -C linker=/builds/worker/workspace/build/src/build/cargo-linker -L dependency=/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./i686-unknown-linux-gnu/release/deps -L dependency=/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./release/deps --cap-lints warn -C opt-level=2 -C debuginfo=2`
[task 2018-09-13T20:40:54.193Z] 20:40:54     INFO -       Running `/builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/rustc/bin/rustc --crate-name cfg_if third_party/rust/cfg-if/src/lib.rs --crate-type lib --emit=dep-info,link -C opt-level=2 -C panic=abort -C codegen-units=1 -C metadata=00be98b2f57e12f7 -C extra-filename=-00be98b2f57e12f7 --out-dir /builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./i686-unknown-linux-gnu/release/deps --target i686-unknown-linux-gnu -C linker=/builds/worker/workspace/build/src/build/cargo-linker -L dependency=/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./i686-unknown-linux-gnu/release/deps -L dependency=/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./release/deps --cap-lints warn -C opt-level=2 -C debuginfo=2`
[task 2018-09-13T20:40:54.193Z] 20:40:54     INFO -       Running `/builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/rustc/bin/rustc --crate-name libc third_party/rust/libc/src/lib.rs --crate-type lib --emit=dep-info,link -C opt-level=2 -C panic=abort -C codegen-units=1 --cfg 'feature="default"' --cfg 'feature="use_std"' -C metadata=e097ae6a6f3392f2 -C extra-filename=-e097ae6a6f3392f2 --out-dir /builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./i686-unknown-linux-gnu/release/deps --target i686-unknown-linux-gnu -C linker=/builds/worker/workspace/build/src/build/cargo-linker -L dependency=/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./i686-unknown-linux-gnu/release/deps -L dependency=/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./release/deps --cap-lints warn -C opt-level=2 -C debuginfo=2`
[task 2018-09-13T20:40:54.193Z] 20:40:54     INFO -       Running `/builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/rustc/bin/rustc --crate-name byteorder third_party/rust/byteorder/src/lib.rs --crate-type lib --emit=dep-info,link -C opt-level=2 -C panic=abort -C codegen-units=1 --cfg 'feature="default"' --cfg 'feature="std"' -C metadata=301e016a472dd7e6 -C extra-filename=-301e016a472dd7e6 --out-dir /builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./i686-unknown-linux-gnu/release/deps --target i686-unknown-linux-gnu -C linker=/builds/worker/workspace/build/src/build/cargo-linker -L dependency=/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./i686-unknown-linux-gnu/release/deps -L dependency=/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./release/deps --cap-lints warn -C opt-level=2 -C debuginfo=2`
[task 2018-09-13T20:40:54.193Z] 20:40:54     INFO -       Running `/builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/rustc/bin/rustc --crate-name memoffset third_party/rust/memoffset/src/lib.rs --crate-type lib --emit=dep-info,link -C opt-level=2 -C panic=abort -C codegen-units=1 -C metadata=4da635f68070db16 -C extra-filename=-4da635f68070db16 --out-dir /builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./i686-unknown-linux-gnu/release/deps --target i686-unknown-linux-gnu -C linker=/builds/worker/workspace/build/src/build/cargo-linker -L dependency=/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./i686-unknown-linux-gnu/release/deps -L dependency=/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./release/deps --cap-lints warn -C opt-level=2 -C debuginfo=2`
[task 2018-09-13T20:40:54.193Z] 20:40:54     INFO -       Running `/builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/rustc/bin/rustc --crate-name lazy_static third_party/rust/lazy_static/src/lib.rs --crate-type lib --emit=dep-info,link -C opt-level=2 -C panic=abort -C codegen-units=1 -C metadata=4fd1aa27e6671ff3 -C extra-filename=-4fd1aa27e6671ff3 --out-dir /builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./i686-unknown-linux-gnu/release/deps --target i686-unknown-linux-gnu -C linker=/builds/worker/workspace/build/src/build/cargo-linker -L dependency=/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./i686-unknown-linux-gnu/release/deps -L dependency=/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./release/deps --cap-lints warn -C opt-level=2 -C debuginfo=2`
[task 2018-09-13T20:40:54.194Z] 20:40:54     INFO -       Running `/builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/rustc/bin/rustc --crate-name build_const third_party/rust/build_const/src/lib.rs --crate-type lib --emit=dep-info,link -C opt-level=2 -C codegen-units=1 --cfg 'feature="default"' --cfg 'feature="std"' -C metadata=af20a5962662a68e -C extra-filename=-af20a5962662a68e --out-dir /builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./release/deps -L dependency=/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./release/deps --cap-lints warn`
[task 2018-09-13T20:40:54.194Z] 20:40:54     INFO -       Running `/builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/rustc/bin/rustc --crate-name scopeguard third_party/rust/scopeguard/src/lib.rs --crate-type lib --emit=dep-info,link -C opt-level=2 -C panic=abort -C codegen-units=1 -C metadata=45e54760277ada48 -C extra-filename=-45e54760277ada48 --out-dir /builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./i686-unknown-linux-gnu/release/deps --target i686-unknown-linux-gnu -C linker=/builds/worker/workspace/build/src/build/cargo-linker -L dependency=/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./i686-unknown-linux-gnu/release/deps -L dependency=/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./release/deps --cap-lints warn -C opt-level=2 -C debuginfo=2`
[task 2018-09-13T20:40:54.195Z] 20:40:54     INFO -       Running `/builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/rustc/bin/rustc --crate-name slab third_party/rust/slab/src/lib.rs --crate-type lib --emit=dep-info,link -C opt-level=2 -C panic=abort -C codegen-units=1 -C metadata=ff1ec316969a44f9 -C extra-filename=-ff1ec316969a44f9 --out-dir /builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./i686-unknown-linux-gnu/release/deps --target i686-unknown-linux-gnu -C linker=/builds/worker/workspace/build/src/build/cargo-linker -L dependency=/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./i686-unknown-linux-gnu/release/deps -L dependency=/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./release/deps --cap-lints warn -C opt-level=2 -C debuginfo=2`
[task 2018-09-13T20:40:54.195Z] 20:40:54     INFO -       Running `/builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/rustc/bin/rustc --crate-name lazycell third_party/rust/lazycell/src/lib.rs --crate-type lib --emit=dep-info,link -C opt-level=2 -C panic=abort -C codegen-units=1 -C metadata=6a5f2ad9061f605d -C extra-filename=-6a5f2ad9061f605d --out-dir /builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./i686-unknown-linux-gnu/release/deps --target i686-unknown-linux-gnu -C linker=/builds/worker/workspace/build/src/build/cargo-linker -L dependency=/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./i686-unknown-linux-gnu/release/deps -L dependency=/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./release/deps --cap-lints warn -C opt-level=2 -C debuginfo=2`
[task 2018-09-13T20:40:54.196Z] 20:40:54     INFO -       Running `/builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/rustc/bin/rustc --crate-name cc third_party/rust/cc/src/lib.rs --crate-type lib --emit=dep-info,link -C opt-level=2 -C codegen-units=1 -C metadata=8fbaebaa22aff886 -C extra-filename=-8fbaebaa22aff886 --out-dir /builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./release/deps -L dependency=/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./release/deps --cap-lints warn`
[task 2018-09-13T20:40:54.196Z] 20:40:54     INFO -       Running `/builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/rustc/bin/rustc --crate-name futures third_party/rust/futures/src/lib.rs --crate-type lib --emit=dep-info,link -C opt-level=2 -C panic=abort -C codegen-units=1 --cfg 'feature="default"' --cfg 'feature="use_std"' --cfg 'feature="with-deprecated"' -C metadata=1ef6d9664a45d7eb -C extra-filename=-1ef6d9664a45d7eb --out-dir /builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./i686-unknown-linux-gnu/release/deps --target i686-unknown-linux-gnu -C linker=/builds/worker/workspace/build/src/build/cargo-linker -L dependency=/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./i686-unknown-linux-gnu/release/deps -L dependency=/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./release/deps --cap-lints warn -C opt-level=2 -C debuginfo=2`
[task 2018-09-13T20:40:54.196Z] 20:40:54     INFO -       Running `/builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/rustc/bin/rustc --crate-name num_traits third_party/rust/num-traits/src/lib.rs --crate-type lib --emit=dep-info,link -C opt-level=2 -C panic=abort -C codegen-units=1 --cfg 'feature="default"' --cfg 'feature="std"' -C metadata=803f7e63d19283d3 -C extra-filename=-803f7e63d19283d3 --out-dir /builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./i686-unknown-linux-gnu/release/deps --target i686-unknown-linux-gnu -C linker=/builds/worker/workspace/build/src/build/cargo-linker -L dependency=/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./i686-unknown-linux-gnu/release/deps -L dependency=/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./release/deps --cap-lints warn -C opt-level=2 -C debuginfo=2`
[task 2018-09-13T20:40:54.196Z] 20:40:54     INFO -       Running `/builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/rustc/bin/rustc --crate-name void third_party/rust/void/src/lib.rs --crate-type lib --emit=dep-info,link -C opt-level=2 -C panic=abort -C codegen-units=1 -C metadata=8b3013d4142bd32a -C extra-filename=-8b3013d4142bd32a --out-dir /builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./i686-unknown-linux-gnu/release/deps --target i686-unknown-linux-gnu -C linker=/builds/worker/workspace/build/src/build/cargo-linker -L dependency=/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./i686-unknown-linux-gnu/release/deps -L dependency=/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./release/deps --cap-lints warn -C opt-level=2 -C debuginfo=2`
[task 2018-09-13T20:40:54.198Z] 20:40:54     INFO -       Running `/builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/rustc/bin/rustc --crate-name unicode_xid third_party/rust/unicode-xid/src/lib.rs --crate-type lib --emit=dep-info,link -C opt-level=2 -C codegen-units=1 --cfg 'feature="default"' -C metadata=990dc22d5e4af502 -C extra-filename=-990dc22d5e4af502 --out-dir /builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./release/deps -L dependency=/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./release/deps --cap-lints warn`
[task 2018-09-13T20:40:54.198Z] 20:40:54     INFO -       Running `/builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/rustc/bin/rustc --crate-name fnv third_party/rust/fnv/lib.rs --crate-type lib --emit=dep-info,link -C opt-level=2 -C panic=abort -C codegen-units=1 -C metadata=7603ea44f73cc6a3 -C extra-filename=-7603ea44f73cc6a3 --out-dir /builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./i686-unknown-linux-gnu/release/deps --target i686-unknown-linux-gnu -C linker=/builds/worker/workspace/build/src/build/cargo-linker -L dependency=/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./i686-unknown-linux-gnu/release/deps -L dependency=/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./release/deps --cap-lints warn -C opt-level=2 -C debuginfo=2`
[task 2018-09-13T20:40:54.198Z] 20:40:54     INFO -     Compiling serde v1.0.66
[task 2018-09-13T20:40:54.198Z] 20:40:54     INFO -       Running `/builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/rustc/bin/rustc --crate-name build_script_build third_party/rust/serde/build.rs --crate-type bin --emit=dep-info,link -C opt-level=2 -C codegen-units=1 --cfg 'feature="default"' --cfg 'feature="std"' -C metadata=a8fe32f3cbeaed02 -C extra-filename=-a8fe32f3cbeaed02 --out-dir /builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./release/build/serde-a8fe32f3cbeaed02 -L dependency=/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./release/deps --cap-lints warn`
[task 2018-09-13T20:40:54.198Z] 20:40:54     INFO -     Compiling matches v0.1.6
[task 2018-09-13T20:40:54.198Z] 20:40:54     INFO -       Running `/builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/rustc/bin/rustc --crate-name matches third_party/rust/matches/lib.rs --crate-type lib --emit=dep-info,link -C opt-level=2 -C panic=abort -C codegen-units=1 -C metadata=15d02ae9f326657b -C extra-filename=-15d02ae9f326657b --out-dir /builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./i686-unknown-linux-gnu/release/deps --target i686-unknown-linux-gnu -C linker=/builds/worker/workspace/build/src/build/cargo-linker -L dependency=/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./i686-unknown-linux-gnu/release/deps -L dependency=/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./release/deps --cap-lints warn -C opt-level=2 -C debuginfo=2`
[task 2018-09-13T20:40:54.198Z] 20:40:54     INFO -     Compiling adler32 v1.0.2
[task 2018-09-13T20:40:54.198Z] 20:40:54     INFO -       Running `/builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/rustc/bin/rustc --crate-name adler32 third_party/rust/adler32/src/lib.rs --crate-type lib --emit=dep-info,link -C opt-level=2 -C panic=abort -C codegen-units=1 -C metadata=394a0292d3d657e7 -C extra-filename=-394a0292d3d657e7 --out-dir /builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./i686-unknown-linux-gnu/release/deps --target i686-unknown-linux-gnu -C linker=/builds/worker/workspace/build/src/build/cargo-linker -L dependency=/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./i686-unknown-linux-gnu/release/deps -L dependency=/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./release/deps --cap-lints warn -C opt-level=2 -C debuginfo=2`
[task 2018-09-13T20:40:54.199Z] 20:40:54     INFO -     Compiling itoa v0.4.1
[task 2018-09-13T20:40:54.200Z] 20:40:54     INFO -       Running `/builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/rustc/bin/rustc --crate-name itoa third_party/rust/itoa/src/lib.rs --crate-type lib --emit=dep-info,link -C opt-level=2 -C panic=abort -C codegen-units=1 --cfg 'feature="default"' --cfg 'feature="std"' -C metadata=63d98720c6044e38 -C extra-filename=-63d98720c6044e38 --out-dir /builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./i686-unknown-linux-gnu/release/deps --target i686-unknown-linux-gnu -C linker=/builds/worker/workspace/build/src/build/cargo-linker -L dependency=/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./i686-unknown-linux-gnu/release/deps -L dependency=/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./release/deps --cap-lints warn -C opt-level=2 -C debuginfo=2`
[task 2018-09-13T20:40:54.200Z] 20:40:54     INFO -  warning: variable does not need to be mutable
Flags: needinfo?(drno)
Sorry for landing these patches in a bad order. But I really don't get how I'm suppose to land a commit series (with Lando).

I'm also a little confused why only the middle commit got backed out, and not all commits from this bug? Was it because I didn't mark them with 'Part X'?

I just relanded the middle patch again, because since the last commit didn't get backed out everything should compile now.
https://hg.mozilla.org/mozilla-central/rev/c8eec40da8fd
https://hg.mozilla.org/mozilla-central/rev/9293d3493e0c
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox64: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Sorry but this is not closed, because this code part https://hg.mozilla.org/integration/autoland/rev/70a5176eca98 is missing from the merge (because it got backed out and I had to reland it later).
Status: RESOLVED → REOPENED
Flags: needinfo?(drno) → needinfo?(nerli)
Resolution: FIXED → ---
https://hg.mozilla.org/mozilla-central/rev/70a5176eca98
Status: REOPENED → RESOLVED
Closed: 6 years ago → 6 years ago
Resolution: --- → FIXED
Flags: needinfo?(nerli)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: