1479708 - Required date input still has a clear button

Status: RESOLVED FIXED

(Toolkit :: XUL Widgets, defect, P3)

Description

[Maxime Corteel]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:61.0) Gecko/20100101 Firefox/61.0
Build ID: 20180704194937

Steps to reproduce:

Create a form with a required date input and set its value. (See https://codepen.io/anon/pen/VBQeQW)


Actual results:

The input contains a clear button.


Expected results:

It shouldn't, because if you clear the input, the validation will always fail.
I'm not completely sure if it's a bug or a feature, but it doesn't make much sense.

Comment 1

[Sean Voisen (:svoisen)]

(In reply to Maxime Corteel from comment #0)

> It shouldn't, because if you clear the input, the validation will always
> fail.
> I'm not completely sure if it's a bug or a feature, but it doesn't make much
> sense.

I believe this is a bug. Chrome correctly hides the clear button when the required attribute is set.

Comment 2

[Sean Voisen (:svoisen)]

Putting this in Toolkit > XUL Widgets since it appears the current datetimebox widget does not appear to respect the required attribute.

The method updateResetButtonVisibility in datetimebox.xml looks to see if any field is non-empty in the widget, and if it is, sets the mResetButton visibility to visible.

See https://searchfox.org/mozilla-central/source/toolkit/content/widgets/datetimebox.xml#1373

Comment 3

[François Freitag]

Attachment: Bug 1479708 - Hide required date time input reset button. r=emilio

Comment 4

[François Freitag]

Attachment: Bug 1479708 - Hide required date time input reset button. r=emilio

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a506f9517ba2
Hide required date time input reset button. r=emilio

Comment 7

[Andreea Pavel [:apavel]]

Backed out for failing test_input_datetime_reset_button.html

Push with failures https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=258262109&resultStatus=testfailed%2Cbusted%2Cexception&revision=a506f9517ba274ad95efdb8b5dfc4239d1a72684

Failure log https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=258262109&repo=autoland&lineNumber=5665

Backout: https://hg.mozilla.org/integration/autoland/rev/62164e4678c0d4f2f728760da00d5386bc2d3b58

Comment 8

[François Freitag]

Attachment: Bug 1479708 - Hide required date time input reset button. r=emilio

Comment 9

[François Freitag]

Sorry the change had to be backed out. The test failure wasn’t caught earlier because the try server run did not test the mobile version.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3d066652bc2f
Hide required date time input reset button. r=emilio

Comment 11

[Andrei Ciure[:andrei_ciure]]

https://hg.mozilla.org/mozilla-central/rev/3d066652bc2f