1567191 - Datetime input attribute value changes is not correct

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect, P3)

Description

[Emilio Cobos Álvarez (:emilio)]

This datetime-specific attribute change handling code is in nsDateTimeControlFrame::AttributeChanged.

But since it was rewritten in bug 1496242, the UA widget may live while there is no frame (this was not the case with the XBL implementation). This means that attribute changes that happen while the <input> doesn't have a frame (due to various reasons, but it's probably easily testable giving it display: none) are not observed by the UA widget, ending up in potentially broken states.

The attribute change handling should live in HTMLInputElement::AttributeChanged, not nsDateTimeControlFrame.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

I'll fix this after bug 1479708, to make the change there easier :)

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Self nag

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1567191 - Move datetime input widget attribute handling code to HTMLInputElement. r=smaug

It's the only sound place now that we use Shadow DOM, since the widget exists
when we have no frames.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f8cd1dc356e0
Move datetime input widget attribute handling code to HTMLInputElement. r=smaug

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/f8cd1dc356e0