Closed Bug 1479755 Opened 2 years ago Closed 2 years ago

Fix threading assertions/safety in AndroidDynamicToolbarAnimator

Categories

(Core :: Graphics: WebRender, enhancement, P3)

Other Branch
enhancement

Tracking

()

RESOLVED WONTFIX

People

(Reporter: kats, Unassigned)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [gfx-noted])

AndroidDynamicToolbarAnimator has a bunch of stuff that runs on the "compositor" thread, and asserts as much. However, with WR, we introduced the notion of the updater and sampler threads in APZ. Now some of the AndroidDynamicToolbarAnimator functions that used to run on the compositor thread really run on the updater/sampler threads, which are different from the compositor threads. We should update the asserts accordingly and ensure there's no thread safety issues with the changes.
Priority: -- → P3
This will be obsoleted by bug 1498699, because we're just not going to have the dynamic toolbar and WR at the same time. At least for now.
Status: NEW → RESOLVED
Closed: 2 years ago
Depends on: 1498699
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.