1498699 - Support products on Android without the dynamic toolbar

Status: RESOLVED FIXED

(Core :: Panning and Zooming, enhancement)

Description

[Kartikaya Gupta (email:[e-mail])]

The dynamic toolbar is specific to Fennec. GeckoView-based products won't be using it (at least for now). So we should only instantiate AndroidDynamicToolbarAnimator and the run the related code if we're on Fennec, rather than unconditionally inside MOZ_WIDGET_ANDROID blocks.

Comment 1

[Botond Ballo [:botond]]

I thought we were already doing this with the pref browser.chrome.dynamictoolbar, but you're right that the AndroidDynamicToolbarAnimator is still created if the pref is set to false. (I guess it just doesn't get the necessary messages from Java to actually do anything?)

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Yeah, we create the AndroidDynamicToolbarAnimator but most of the code is no-op unless it's enabled. However there are a couple of codepaths (the NotifyLayersUpdated and FirstPaint messages, in particular) which are used even if browser.chrome.dynamictoolbar is false. The patches I have this bug involve moving that code out of AndroidDynamicToolbarAnimator and then allowing the instantiation to be skipped.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&revision=8d4f442eaa4fd0724a33e93950d5207cde3edfd4

Patches are pretty final unless there are try failures.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3f7262b9339a81d436e13af39b34b3b9c06e610a fixes the build failures for non-Android.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1498699 - Move the LAYERS_UPDATED notification from AndroidDynamicToolbarAnimator to UiCompositorControllerParent. r?jnicol

This extracts code that is conceptually unrelated to the dynamic toolbar
from the dynamic toolbar codebase. It is a stepping stone to being able
to not instantiate the AndroidDynamicToolbarAnimator at all for
non-Fennec android products.

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1498699 - Move the FIRST_PAINT notification from AndroidDynamicToolbarAnimator to UiCompositorControllerParent. r?jnicol

Depends on D8657

Comment 7

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1498699 - Only create the AndroidDynamicToolbarAnimator for Fennec. r?jnicol

The bulk of this is adjusting the code that tries to use the toolbar to
have appropriate null checks instead of asserting it will exist. The
creation of the animator instance is now guarded by a IsFennec
condition.

Depends on D8658

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dcd095eb8910
Move the LAYERS_UPDATED notification from AndroidDynamicToolbarAnimator to UiCompositorControllerParent. r=jnicol
https://hg.mozilla.org/integration/autoland/rev/da505775320b
Move the FIRST_PAINT notification from AndroidDynamicToolbarAnimator to UiCompositorControllerParent. r=jnicol
https://hg.mozilla.org/integration/autoland/rev/8866a66f7659
Only create the AndroidDynamicToolbarAnimator for Fennec. r=jnicol

Comment 9

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/dcd095eb8910
https://hg.mozilla.org/mozilla-central/rev/da505775320b
https://hg.mozilla.org/mozilla-central/rev/8866a66f7659