1480450 - Tracking Protection needs to honor the browser.contentblocking.enabled pref

Status: RESOLVED FIXED

(Firefox :: Protections UI, enhancement, P1)

Description

[Johann Hofmann [:johannh]]

browser.contentblocking.enabled (introduced in bug 1476217) is the central preference that users can use to turn off all types of content blocking: Tracking Protection, FastBlock, Third Party storage restrictions, etc.

This means Tracking Protection should honor it and not block when the pref is set to false.

Comment 1

[François Marier [:francois]]

Johann, do we still need tracking annotations when content blocking is off? Are we displaying the number of trackers or something like that in the revamped UI?

Comment 2

[Johann Hofmann [:johannh]]

(In reply to François Marier [:francois] from comment #1)
> Johann, do we still need tracking annotations when content blocking is off?
> Are we displaying the number of trackers or something like that in the
> revamped UI?

Looking at the spec, yes, there's still the "Blockable Content Detected on this Site" text which we need to display even when browser.contentblocking.enabled is false. So we always need tracking annotations.

Comment 3

[Johann Hofmann [:johannh]]

(But no, there's no display of number of trackers currently planned.) :)

Comment 4

[François Marier [:francois]]

Does this part of the UI need to be updated?

https://searchfox.org/mozilla-central/rev/aff5d4ad5d7fb2919d267cbc23b1d87ae3cf0110/browser/base/content/browser-trackingprotection.js#248-257

Comment 5

[Johann Hofmann [:johannh]]

(In reply to François Marier [:francois] from comment #4)
> Does this part of the UI need to be updated?
> 
> https://searchfox.org/mozilla-central/rev/
> aff5d4ad5d7fb2919d267cbc23b1d87ae3cf0110/browser/base/content/browser-
> trackingprotection.js#248-257

No, UI updates for FastBlock are covered by bug 1476218. :)

Comment 6

[François Marier [:francois]]

Attachment: Bug 1480450 - Use correct resource url for chrome test. r=dimi!

Comment 7

[François Marier [:francois]]

Attachment: Bug 1480450 - Move TP tests to using async/await and promises. r=dimi!

There are no actual changes/additions to these tests.

Depends on D3130

Comment 8

[François Marier [:francois]]

Attachment: Bug 1480450 - Honor browser.contentblocking.enabled in tracking protection. r=dimi!

Depends on D3131

Comment 9

[Dimi Lee [:dimi]]

Comment on attachment 8999292 [details]
Bug 1480450 - Use correct resource url for chrome test. r=dimi!

Dimi Lee[:dimi][:dlee] has approved the revision.

Comment 10

[Dimi Lee [:dimi]]

Comment on attachment 8999293 [details]
Bug 1480450 - Move TP tests to using async/await and promises. r=dimi!

Dimi Lee[:dimi][:dlee] has approved the revision.

Comment 11

[Dimi Lee [:dimi]]

Comment on attachment 8999294 [details]
Bug 1480450 - Honor browser.contentblocking.enabled in tracking protection. r=dimi!

Dimi Lee[:dimi][:dlee] has approved the revision.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bb02d7d281cb
Use correct resource url for chrome test. r=dimi!

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cf5e3a3105dc
Move TP tests to using async/await and promises. r=dimi!

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/34d3b10c54eb
Honor browser.contentblocking.enabled in tracking protection. r=dimi!

Comment 15

[Andrei Ciure[:aciure]]

Backed out 1 changesets (bug 1480450) for mochitest/test_trackingprotection_bug1157081.html failures

push that caused the backout: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=34d3b10c54ebd19d277f23684fb651688c0ef68c&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-classifiedState=unclassified

failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-classifiedState=unclassified&fromchange=6c752dc707f5bc5557bc558d8737c143c658727c&selectedJob=193708298&filter-searchStr=Linux+x64+opt+Mochitests+test-linux64%2Fopt-mochitest-chrome-3+M%28c3%29

https://treeherder.mozilla.org/logviewer.html#?job_id=193708298&repo=autoland

backout: https://hg.mozilla.org/integration/autoland/rev/3049a5cc847bf692e3f1d9e69837d1b03c918a8f

Comment 16

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/bb02d7d281cb

Comment 17

[François Marier [:francois]]

Reopening since this got partially backed out (see comment 14).

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cd55c4ac10c3
Honor browser.contentblocking.enabled in tracking protection. r=dimi!

Comment 19

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/cd55c4ac10c3

Comment 20

[François Marier [:francois]]

Things got a bit messy with partial backout and the lost middle patch, but in the end, all three patches got merged onto central:

https://hg.mozilla.org/mozilla-central/rev/bb02d7d281cb (comment 12)
https://hg.mozilla.org/mozilla-central/rev/cf5e3a3105dc (comment 13)
https://hg.mozilla.org/mozilla-central/rev/cd55c4ac10c3 (comment 18)