Closed Bug 1480450 Opened Last year Closed Last year

Tracking Protection needs to honor the browser.contentblocking.enabled pref

Categories

(Firefox :: Protections UI, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 63
Tracking Status
firefox63 --- fixed

People

(Reporter: johannh, Assigned: francois)

References

(Blocks 2 open bugs)

Details

Attachments

(3 files)

browser.contentblocking.enabled (introduced in bug 1476217) is the central preference that users can use to turn off all types of content blocking: Tracking Protection, FastBlock, Third Party storage restrictions, etc.

This means Tracking Protection should honor it and not block when the pref is set to false.
Assignee: nobody → francois
Status: NEW → ASSIGNED
Priority: -- → P1
Summary: Tracking Protection needs to honor the browser.contentblocking.enabled pref → Tracking Protection and annotations need to honor the browser.contentblocking.enabled pref
Johann, do we still need tracking annotations when content blocking is off? Are we displaying the number of trackers or something like that in the revamped UI?
Flags: needinfo?(jhofmann)
(In reply to François Marier [:francois] from comment #1)
> Johann, do we still need tracking annotations when content blocking is off?
> Are we displaying the number of trackers or something like that in the
> revamped UI?

Looking at the spec, yes, there's still the "Blockable Content Detected on this Site" text which we need to display even when browser.contentblocking.enabled is false. So we always need tracking annotations.
Flags: needinfo?(jhofmann)
(But no, there's no display of number of trackers currently planned.) :)
Summary: Tracking Protection and annotations need to honor the browser.contentblocking.enabled pref → Tracking Protection needs to honor the browser.contentblocking.enabled pref
See Also: → 1482306
(In reply to François Marier [:francois] from comment #4)
> Does this part of the UI need to be updated?
> 
> https://searchfox.org/mozilla-central/rev/
> aff5d4ad5d7fb2919d267cbc23b1d87ae3cf0110/browser/base/content/browser-
> trackingprotection.js#248-257

No, UI updates for FastBlock are covered by bug 1476218. :)
Flags: needinfo?(jhofmann)
There are no actual changes/additions to these tests.

Depends on D3130
Comment on attachment 8999292 [details]
Bug 1480450 - Use correct resource url for chrome test. r=dimi!

Dimi Lee[:dimi][:dlee] has approved the revision.
Attachment #8999292 - Flags: review+
Comment on attachment 8999293 [details]
Bug 1480450 - Move TP tests to using async/await and promises. r=dimi!

Dimi Lee[:dimi][:dlee] has approved the revision.
Attachment #8999293 - Flags: review+
Comment on attachment 8999294 [details]
Bug 1480450 - Honor browser.contentblocking.enabled in tracking protection. r=dimi!

Dimi Lee[:dimi][:dlee] has approved the revision.
Attachment #8999294 - Flags: review+
Pushed by fmarier@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bb02d7d281cb
Use correct resource url for chrome test. r=dimi!
Pushed by fmarier@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cf5e3a3105dc
Move TP tests to using async/await and promises. r=dimi!
Pushed by fmarier@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/34d3b10c54eb
Honor browser.contentblocking.enabled in tracking protection. r=dimi!
https://hg.mozilla.org/mozilla-central/rev/bb02d7d281cb
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
Reopening since this got partially backed out (see comment 14).
Status: RESOLVED → REOPENED
Flags: needinfo?(francois)
Resolution: FIXED → ---
Pushed by fmarier@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cd55c4ac10c3
Honor browser.contentblocking.enabled in tracking protection. r=dimi!
https://hg.mozilla.org/mozilla-central/rev/cd55c4ac10c3
Status: REOPENED → RESOLVED
Closed: Last yearLast year
Resolution: --- → FIXED
Things got a bit messy with partial backout and the lost middle patch, but in the end, all three patches got merged onto central:

https://hg.mozilla.org/mozilla-central/rev/bb02d7d281cb (comment 12)
https://hg.mozilla.org/mozilla-central/rev/cf5e3a3105dc (comment 13)
https://hg.mozilla.org/mozilla-central/rev/cd55c4ac10c3 (comment 18)
Blocks: 1580351
You need to log in before you can comment on or make changes to this bug.