Closed Bug 1480506 Opened Last year Closed Last year

Top Search Shortcuts should allow user to unpin

Categories

(Firefox :: New Tab Page, enhancement, P1)

enhancement

Tracking

()

VERIFIED FIXED
Firefox 63
Iteration:
63.4 - Aug 20
Tracking Status
firefox62 --- verified
firefox63 --- verified

People

(Reporter: k88hudson, Assigned: ursula)

References

(Blocks 1 open bug)

Details

User Story

https://mozilla.invisionapp.com/share/U7N6JJGZ4RB#/screens

Attachments

(2 files)

Top Search Shortcuts should have a context menu in users can remove it.
Severity: normal → enhancement
Priority: -- → P2
Summary: Top Search Shortcuts should be unpinnable → Top Search Shortcuts should allow user to unpin
Iteration: --- → 63.4 - Aug 20
Sounds like we might want to remove some other top site context menu options, e.g., "open in new /private window"
Can you add a spec for the context menu here?
Flags: needinfo?(abenson)
Depends on: 1480518
Assignee: nobody → usarracini
Status: NEW → ASSIGNED
Priority: P2 → P1
There is some utility to being able to open a new window and/or private window and performing a search BUT if those prove problematic from an engineering perspective, we can omit those from this first phase. That means our context menu would be:

[] Unpin
----------
[] Open in a New Window (optional depending on eng difficulty)
[] Open in a New Private Window (optional depending on eng difficulty)
----------
[] Dismiss


If we go without new window actions:


[] Unpin
----------
[] Dismiss
Assignee: usarracini → nobody
Status: ASSIGNED → NEW
No longer depends on: 1480518
Flags: needinfo?(abenson)
Priority: P1 → P2
Assignee: nobody → usarracini
Status: NEW → ASSIGNED
Depends on: 1480518
Priority: P2 → P1
Commits pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/1ca281b56f3fc0fb5a9d03f4969f2747416d2ce3
Fix Bug 1480506 - Top Search Shortcuts should allow user to unpin

https://github.com/mozilla/activity-stream/commit/d42c0394d74c9d95ef148702579e89cf73a4c303
Merge pull request #4295 from sarracini/bug_1480506

Fix Bug 1480506 - Top Search Shortcuts should allow user to unpin
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Blocks: 1482205
I have verified this on Windows 10 x64, Arch Linux and Mac 10.13.3 with the latest version of "Firefox Nightly" and I can confirm that the "Top Search Shortcuts" can be unpinned or dismissed from the context menu.
Status: RESOLVED → VERIFIED
Blocks: 1482398
I have verified that the search shortcuts can be unpinned or dismissed via a context menu in the latest Beta (62.0b18 Build ID 20180816151750) on Windows 10, Mac 10.13 and Arch Linux x64.
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.