1480506 - Top Search Shortcuts should allow user to unpin

Status: VERIFIED FIXED

(Firefox :: New Tab Page, enhancement, P1)

Description

[Kate Hudson :k88hudson]

Top Search Shortcuts should have a context menu in users can remove it.

Comment 1

[Ed Lee :Mardak]

Sounds like we might want to remove some other top site context menu options, e.g., "open in new /private window"

Comment 2

[Kate Hudson :k88hudson]

Can you add a spec for the context menu here?

Comment 3

[Aaron Benson]

There is some utility to being able to open a new window and/or private window and performing a search BUT if those prove problematic from an engineering perspective, we can omit those from this first phase. That means our context menu would be:

[] Unpin
----------
[] Open in a New Window (optional depending on eng difficulty)
[] Open in a New Private Window (optional depending on eng difficulty)
----------
[] Dismiss


If we go without new window actions:


[] Unpin
----------
[] Dismiss

Comment 4

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4292

Comment 5

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4295

Comment 6

[[github robot]]

Commits pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/1ca281b56f3fc0fb5a9d03f4969f2747416d2ce3
Fix Bug 1480506 - Top Search Shortcuts should allow user to unpin

https://github.com/mozilla/activity-stream/commit/d42c0394d74c9d95ef148702579e89cf73a4c303
Merge pull request #4295 from sarracini/bug_1480506

Fix Bug 1480506 - Top Search Shortcuts should allow user to unpin

Comment 7

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/972b3c48c6e9

Comment 8

[Marius Coman [:mcoman], Ecosystem QA]

I have verified this on Windows 10 x64, Arch Linux and Mac 10.13.3 with the latest version of "Firefox Nightly" and I can confirm that the "Top Search Shortcuts" can be unpinned or dismissed from the context menu.

Comment 9

[Ed Lee :Mardak]

https://hg.mozilla.org/releases/mozilla-beta/rev/9e752b54a20f425449e1f00bf3adefa903f8051a

Comment 10

[Ciprian Muresan [:cmuresan], Ecosystem QA]

I have verified that the search shortcuts can be unpinned or dismissed via a context menu in the latest Beta (62.0b18 Build ID 20180816151750) on Windows 10, Mac 10.13 and Arch Linux x64.