1480541 - Remove em-dash from search string dropdown text when the search query is empty

Status: VERIFIED FIXED

(Firefox :: New Tab Page, enhancement, P3)

Description

[Kate Hudson :k88hudson]

We have discussed that removing the em-dash from the "– Search with Amazon" drop down text UI.

Comment 1

[Drew Willcoxon :adw]

(In reply to Kate Hudson :k88hudson from comment #0)
> We have discussed that removing the em-dash from the "– Search with Amazon"
> drop down text UI.

But IIRC only before the user has typed a search string.  Once the user starts typing something, we should keep the dash between the search string and the "Search with".

i.e., right now, if you type only a search alias, the first result in the urlbar is " – Search with Foo".  It should probably only be "Search with Foo".

Comment 2

[Drew Willcoxon :adw]

Attachment: Bug 1480541 - Remove em-dash from search string dropdown text when the search query is empty. r?mak

Comment 3

[Marco Bonardo [:mak]]

Comment on attachment 8998388 [details]
Bug 1480541 - Remove em-dash from search string dropdown text when the search query is empty. r?mak

Marco Bonardo [::mak] (Away 9-26 Aug) has approved the revision.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/36642e9b970a
Remove em-dash from search string dropdown text when the search query is empty. r=mak

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/36642e9b970a

Comment 6

[Ed Lee :Mardak]

https://hg.mozilla.org/releases/mozilla-beta/rev/78f22251dd11e53e3fa18e89c28cf314824f8ea3

Comment 7

[Ciprian Muresan [:cmuresan], Formerly of Ecosystem QA - please needinfo @mcoman for things regarding the team]

I have verified that the issue is no longer reproducible in the latest Nightly (63.0a1, Build ID 20180816100035) and Beta (62.0b18 Build ID 20180816151750) on Windows 10, Mac 10.13 and Arch Linux x64.