Closed
Bug 1480645
Opened 6 years ago
Closed 6 years ago
Remove nsIWebBrowserFocus
Categories
(Core :: DOM: Navigation, enhancement, P2)
Core
DOM: Navigation
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: qdot, Assigned: qdot)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
Only implemented by nsWebBrowser, only accessed via C++ in TabChild. One less interface to QI to, especially if we just store a RefPtr<nsWebBrowser> ptr in TabChild instead of constantly routing through nsIWebBrowser.
|
Assignee | |
Updated•6 years ago
|
Component: General → Document Navigation
Priority: -- → P2
Product: Toolkit → Core
|
|
Assignee | |
Comment 1•6 years ago
|
||
Only implemented by nsWebBrowser, only 2 methods used in TabChild. Move methods to nsWebBrowser implementation and remove unused methods, change names to something more obvious, and remove interface. MozReview-Commit-ID: 4WwBrVWQEVy
|
||
Comment 2•6 years ago
|
||
Comment on attachment 8997629 [details] Bug 1480645 - Remove nsIWebBrowserFocus; r=nika :Nika Layzell has approved the revision. https://phabricator.services.mozilla.com/D2752
Attachment #8997629 -
Flags: review+
Pushed by kmachulis@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/82e7fc398926 Remove nsIWebBrowserFocus; r=nika
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/82e7fc398926
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•