1480665 - [motion-1] Implement ray() function for offset-path

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P3)

Description

[Boris Chiou [:boris]]

Bug 1429298 implements offset-path and path() function, and according to the spec, we still need to support another shape-like function, ray() [1]. We could put all of them together into StyleShapeSource.

[1] https://drafts.fxtf.org/motion-1/#valdef-offsetpath-ray

Comment 1

[Boris Chiou [:boris]]

The spec issue to explain contain in ray(): https://github.com/w3c/fxtf-drafts/issues/363.

Comment 2

[Boris Chiou [:boris]]

Attachment: Bug 1480665 - Support ray() in offset-path and make it animatable.

1. Add generics::motion::OffsetPath, and use specified Angle and
   computed Angle to define specified OffsetPath and computed OffsetPath.
2. Add ray function into OffsetPath.

Comment 3

[Boris Chiou [:boris]]

Attachment: Bug 1480665 - Implement the contain flag for ray() function.

Basically, the math calculation logic is from the github repo of the spec
author, Eric:
https://github.com/ewilligers/petrogale-purpureicollis/blob/20b7403d85d664eb943232e2a34bc95b6f4a8b62/ray.py#L311-L363

Comment 4

[Boris Chiou [:boris]]

Attachment: Bug 1480665 - Make ray() animatable.

This is splitted from the first patch only for review.

I will merge this into the previous patch after review.

Comment 5

[Boris Chiou [:boris]]

A tool which generates the reference result, from Eric: https://petrogale-purpureicollis.appspot.com/ray/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6db0fd0a2252
Support ray() in offset-path and make it animatable. r=emilio,birtles
https://hg.mozilla.org/integration/autoland/rev/6d6be499b832
Implement the contain flag for ray() function. r=birtles

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/19126 for changes under testing/web-platform/tests

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 9

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/6db0fd0a2252
https://hg.mozilla.org/mozilla-central/rev/6d6be499b832

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot