1581237 - [motion-1] Use the correct containing box for ray()

Status: RESOLVED FIXED

(Core :: CSS Transitions and Animations, enhancement, P3)

Description

[Boris Chiou [:boris]]

The definition of the containing box for ray() is not clear in the spec. Once the spec issue is resolved or we got a conclusion, we should update the implementation in Bug 1480665.

Comment 1

[Boris Chiou [:boris]]

Attachment: Bug 1581237 - Use <coord-box> as the reference box of the containing block for ray().

So now we use <coord-box> to decide which box we should use. Also, we
have to tweak the calculation of path length to take the top left point
into consideration, for padding-box and content-box.

Note:
offset-path-ray-011.html
offset-path-ray-012.html
offset-path-ray-013.html
offset-path-ray-014.html
are in the upstream repo, so the test number starts from 015.

Also, border-box is the default value, so other tests should cover it.

Comment 2

[Boris Chiou [:boris]]

Attachment: Bug 1581237 - Rename RayReferenceData as PathReferenceData.

The data in PathReferenceData could be used for basic shape as well, so
I'd like to rename it. Also, use nsPoint for the current position and
use nsRect for the rect of containing block so we can reuse some
functions in ShapeUtils without redundant conversions, for Bug 1598156.

Also, fix the missing serialization of mBorderBox in layers message.

Comment 3

[Phabricator Automation]

Comment on attachment 9339188 [details]
Bug 1581237 - Rename RayReferenceData as PathReferenceData.

Revision D181008 was moved to bug 1598156. Setting attachment 9339188 [details] to obsolete.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a3c49585335c
Use <coord-box> as the reference box of the containing block for ray(). r=emilio

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/40604 for changes under testing/web-platform/tests

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/a3c49585335c

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot