1480714 - Unifinder does not remember the last selected state on startup

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Richard Marti (:Paenglab)]

The Unifinder falls always back to "Events in the next 7 Days" on startup. Changes after the start are stored until restart.

Comment 1

[Philipp Kewisch [:Fallen][📱📆]]

Would be worth checking if this wasn't the same way before. I seem to remember that given "All Events" had perf issues, we decided to always reset to something known to not produce any, so that users that select "All Events" wouldn't be stuck with a slow Lightning forever.

Comment 2

[Richard Marti (:Paenglab)]

Then this should only happen when "All Events" is set but this also resets when it's set to "Today's Events" which should be less perf using than "Events in the next 7 Days".

Comment 3

[Philipp Kewisch [:Fallen][📱📆]]

wfm

Comment 4

[Richard Marti (:Paenglab)]

nfm. It resets after restart to "Events in the next 7 Days" of TB.

Comment 5

[Philipp Kewisch [:Fallen][📱📆]]

Oh sorry, I was a bit brief. I meant a patch that changes it to only reset if it is a bad perf view like "All Events" would work for me.

Comment 6

[[:MakeMyDay]]

This is always set to 7 days, regardless of you configured today or 14 days before closing TB. Persistiting to xulstore works, its a matter of not restoring the predating configuration at startup.

Comment 7

[Geoff Lankow (:darktrojan)]

Attachment: 1480714-unifinder-startup-1.diff

This fixes the cause of the problem with the menulists (not just this one, but they are rare), and also another stuff-up I made: blocking the loading of the tree view until after the loading of the tree view.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b01c98478582
Menulists do not properly return to the last selected state on startup. r=philipp