Closed Bug 1480752 Opened 6 years ago Closed 6 years ago

Date fields in Task views header not correctly aligned

Categories

(Calendar :: Tasks, enhancement)

Product:
Calendar
Component:
Tasks
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
6.2.2.1

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file, 1 obsolete file)

Task-label-align.patch
1.00 KB, patch
Paenglab
: review+
Fallen
: approval-calendar-esr+
Details | Diff | Splinter Review 
The "start date" and the "due date" aren't correctly aligned in the task view header pane. probably a fallout of the m-c reworking of the textboxes. I see the same on TB 60.
Attached patch Task-label-align.patch (obsolete) — — Splinter Review 
Overriding the textbox.plain margins helps.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8997407 - Flags: review?(makemyday)
Attachment #8997407 - Flags: approval-calendar-esr?(philipp)
Attachment #8997407 - Flags: approval-calendar-beta?(philipp)
Comment on attachment 8997407 [details] [diff] [review]
Task-label-align.patch

Review of attachment 8997407 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, r+ with the indentation fixed.

::: calendar/base/themes/common/calendar-task-view.css
@@ +43,5 @@
> +.item-date-row > .selectable-label {
> +  margin-top: 1px !important;
> +  margin-bottom: 2px !important;
> +  margin-inline-start: 6px !important;
> +  margin-inline-end: 5px !important;

indentation
Attachment #8997407 - Flags: review?(makemyday) → review+
Attached patch Task-label-align.patch — — Splinter Review 
Fixed indentation.
Attachment #8997407 - Attachment is obsolete: true
Attachment #8997407 - Flags: approval-calendar-esr?(philipp)
Attachment #8997407 - Flags: approval-calendar-beta?(philipp)
Attachment #8997425 - Flags: review+
Attachment #8997425 - Flags: approval-calendar-esr?(philipp)
Attachment #8997425 - Flags: approval-calendar-beta?(philipp)
Keywords: checkin-needed
Depends on: 1480714
Depends on: 1480785
No longer depends on: 1480714, 1480785
Attachment #8997425 - Flags: approval-calendar-esr?(philipp)
Attachment #8997425 - Flags: approval-calendar-esr+
Attachment #8997425 - Flags: approval-calendar-beta?(philipp)
Attachment #8997425 - Flags: approval-calendar-beta+
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/a2612a08775d
Align the date labels in task header pane. r=MakeMyDay
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 6.5
Attachment #8997425 - Flags: approval-calendar-beta+
Target Milestone: 6.2 → 6.2.1
Target Milestone: 6.2.1 → 6.2.2
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: