Closed
Bug 1480743
Opened 6 years ago
Closed 6 years ago
[remote-dbg-next] Reuse or copy styles from other about:pages (common.css)
Categories
(DevTools :: about:debugging, enhancement, P1)
DevTools
about:debugging
Tracking
(firefox63 fixed)
RESOLVED
FIXED
Firefox 63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: jdescottes, Assigned: jdescottes)
References
Details
Attachments
(1 file)
The original about:debugging is importing common.css (chrome://global/skin/in-content/common.css) and reuses some of the classnames expected by common.css for about pages.
For instance, sidebars (in about:preferences or about:debugging) or structured as follows:
#categories
.category
.category-image
.category-name
We can either duplicate their styles here, at the risk of being out of sync with other about:pages, or we can leverage common.css for styles.
Assignee | ||
Comment 1•6 years ago
|
||
This is just what our styles would look like if we fully reused
styles from common.css.
The alternative is to duplicate the styling. Reusing styles from
common.css should help us remain in sync with the other about
pages. But it means that the CSS/classnames/(maybe markup) for all
the "widgets" from common.css will probably look different from the
rest of our code.
Assignee | ||
Comment 2•6 years ago
|
||
Comment on attachment 8997414 [details]
Bug 1480743 - Update styles in aboutdebugging-new to match other about:pages;r=daisuke
Feel free to review the patch. I would like to know which option you prefer here:
- reuse the CSS and styles from common.css
- duplicate the styles and rewrite them "our way"
Attachment #8997414 -
Flags: feedback?(dakatsuka)
Attachment #8997414 -
Flags: feedback?(balbeza)
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•6 years ago
|
||
We discussed this during today's aboutdebugging standup.
As long as the changes do not force us to modify the markup significantly and that we clearly document common.css classnames as such in our components (something I haven't done yet in my patch), reusing common.css seems reasonable.
Assignee | ||
Comment 4•6 years ago
|
||
Comment on attachment 8997414 [details]
Bug 1480743 - Update styles in aboutdebugging-new to match other about:pages;r=daisuke
Got feedback from Daisuke this morning, summarized above. Leaving f? flag for Belén.
Attachment #8997414 -
Flags: feedback?(dakatsuka)
Updated•6 years ago
|
Attachment #8997414 -
Attachment description: Bug 1480743 - WIP reuse styles from common.css → Bug 1480743 - Reuse styles from common.css in aboutdebugging-new;r=daisuke
Assignee | ||
Comment 5•6 years ago
|
||
After discussing with Belén and checking with Daisuke, since our sidebar items will be much more complex than the default ones from common.css, if we reuse classnames and styles from common.css our CSS will be hard to understand and maintain.
Therefore the decision here is to:
- duplicate styles in this bug
- in a follow up, push for using CSS variables in common.css (and reuse them in our stylesheets).
Updated•6 years ago
|
Attachment #8997414 -
Attachment description: Bug 1480743 - Reuse styles from common.css in aboutdebugging-new;r=daisuke → Bug 1480743 - Update styles in aboutdebugging-new to match other about:pages;r=daisuke
Comment 6•6 years ago
|
||
Comment on attachment 8997414 [details]
Bug 1480743 - Update styles in aboutdebugging-new to match other about:pages;r=daisuke
Daisuke Akatsuka (:daisuke) has approved the revision.
https://phabricator.services.mozilla.com/D2717
Attachment #8997414 -
Flags: review+
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5880526fbd95
Update styles in aboutdebugging-new to match other about:pages;r=daisuke
Comment 8•6 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
Updated•6 years ago
|
Attachment #8997414 -
Flags: feedback?(balbeza) → feedback+
Updated•6 years ago
|
Priority: P3 → P1
You need to log in
before you can comment on or make changes to this bug.
Description
•